nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/Source/WebCore/svg/properties
History
Said Abou-Hallawa a165b63d9c Make the 'targetElement' argument of the SVG animators to be a reference 
https://bugs.webkit.org/show_bug.cgi?id=228132

Reviewed by Simon Fraser.

It is clear that many SVG animators functions assume the argument
'targetElement' is not nullptr. Also the caller SVGAnimateElementBase
makes sure its targetElement() is not nullptr before calling any of its
animator's functions.

* svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::setTargetElement):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues):
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::SVGAnimateElementBase::startAnimation):
(WebCore::SVGAnimateElementBase::calculateAnimatedValue):
(WebCore::SVGAnimateElementBase::applyResultsToTarget):
(WebCore::SVGAnimateElementBase::stopAnimation):
(WebCore::SVGAnimateElementBase::calculateDistance):
* svg/SVGElement.cpp:
(WebCore::SVGElement::commitPropertyChange):
* svg/properties/SVGAnimatedPropertyAnimator.h:
* svg/properties/SVGAnimatedPropertyAnimatorImpl.h:
* svg/properties/SVGAnimatedPropertyPairAnimator.h:
* svg/properties/SVGAnimatedPropertyPairAnimatorImpl.h:
* svg/properties/SVGAnimationAdditiveFunction.h:
* svg/properties/SVGAnimationAdditiveListFunctionImpl.h:
(WebCore::SVGAnimationLengthListFunction::animate):
(WebCore::SVGAnimationNumberListFunction::animate):
(WebCore::SVGAnimationPointListFunction::animate):
(WebCore::SVGAnimationTransformListFunction::animate):
* svg/properties/SVGAnimationAdditiveValueFunctionImpl.cpp:
(WebCore::SVGAnimationColorFunction::colorFromString):
(WebCore::SVGAnimationIntegerFunction::calculateDistance const):
* svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
(WebCore::SVGAnimationAngleFunction::animate):
(WebCore::SVGAnimationColorFunction::animate):
(WebCore::SVGAnimationLengthFunction::animate):
(WebCore::SVGAnimationNumberFunction::animate):
(WebCore::SVGAnimationPathSegListFunction::animate):
(WebCore::SVGAnimationRectFunction::animate):
* svg/properties/SVGAnimationDiscreteFunction.h:
(WebCore::SVGAnimationDiscreteFunction::animate):
* svg/properties/SVGAnimationDiscreteFunctionImpl.h:
* svg/properties/SVGAnimationFunction.h:
(WebCore::SVGAnimationFunction::calculateDistance const):
(WebCore::SVGAnimationFunction::addFromAndToValues):
* svg/properties/SVGAttributeAnimator.cpp:
(WebCore::SVGAttributeAnimator::isAnimatedStylePropertyAniamtor const):
(WebCore::SVGAttributeAnimator::invalidateStyle):
(WebCore::SVGAttributeAnimator::applyAnimatedStylePropertyChange):
(WebCore::SVGAttributeAnimator::removeAnimatedStyleProperty):
(WebCore::SVGAttributeAnimator::applyAnimatedPropertyChange):
* svg/properties/SVGAttributeAnimator.h:
(WebCore::SVGAttributeAnimator::setFromAndToValues):
(WebCore::SVGAttributeAnimator::setFromAndByValues):
(WebCore::SVGAttributeAnimator::calculateDistance const):
* svg/properties/SVGPrimitivePropertyAnimator.h:
* svg/properties/SVGPropertyAnimator.h:
(WebCore::SVGPropertyAnimator::adjustForInheritance const):
(WebCore::SVGPropertyAnimator::computeInheritedCSSPropertyValue const):

* svg/properties/SVGPropertyOwnerRegistry.h:
* svg/properties/SVGPropertyRegistry.h:
Fix a typo in the name of setAnimatedPropertyDirty().

* svg/properties/SVGValuePropertyAnimator.h:
* svg/properties/SVGValuePropertyAnimatorImpl.h:
* svg/properties/SVGValuePropertyListAnimator.h:
* svg/properties/SVGValuePropertyListAnimatorImpl.h:


Canonical link: https://commits.webkit.org/239835@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 		2021-07-21 03:33:43 +00:00
..
SVGAnimatedDecoratedProperty.h
…
SVGAnimatedPrimitiveProperty.h
…
SVGAnimatedProperty.cpp
…
SVGAnimatedProperty.h Remove <wtf/Optional.h> 2021-06-02 06:45:51 +00:00
SVGAnimatedPropertyAccessor.h
…
SVGAnimatedPropertyAccessorImpl.h
…
SVGAnimatedPropertyAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimatedPropertyAnimatorImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimatedPropertyImpl.h
…
SVGAnimatedPropertyList.h
…
SVGAnimatedPropertyPairAccessor.h
…
SVGAnimatedPropertyPairAccessorImpl.h
…
SVGAnimatedPropertyPairAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimatedPropertyPairAnimatorImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimatedValueProperty.h
…
SVGAnimationAdditiveFunction.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimationAdditiveListFunction.h
…
SVGAnimationAdditiveListFunctionImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimationAdditiveValueFunction.h
…
SVGAnimationAdditiveValueFunctionImpl.cpp Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimationAdditiveValueFunctionImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimationDiscreteFunction.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimationDiscreteFunctionImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAnimationFunction.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAttributeAnimator.cpp Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGAttributeAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGDecoratedEnumeration.h
…
SVGDecoratedPrimitive.h
…
SVGDecoratedProperty.h
…
SVGList.h
…
SVGMemberAccessor.h
…
SVGPointerMemberAccessor.h
…
SVGPrimitiveList.h
…
SVGPrimitivePropertyAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGPrimitivePropertyAnimatorImpl.h
…
SVGProperty.h Remove <wtf/Optional.h> 2021-06-02 06:45:51 +00:00
SVGPropertyAccessor.h
…
SVGPropertyAccessorImpl.h
…
SVGPropertyAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGPropertyAnimatorFactory.h
…
SVGPropertyList.h
…
SVGPropertyOwner.h
…
SVGPropertyOwnerRegistry.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGPropertyRegistry.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGPropertyTraits.cpp
…
SVGPropertyTraits.h
…
SVGSharedPrimitiveProperty.h
…
SVGValueProperty.h
…
SVGValuePropertyAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGValuePropertyAnimatorImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGValuePropertyList.h
…
SVGValuePropertyListAnimator.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00
SVGValuePropertyListAnimatorImpl.h Make the 'targetElement' argument of the SVG animators to be a reference 2021-07-21 03:33:43 +00:00