nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/Source/WebCore/testing
History
Kyle Piddington 38045a526a WebGL via Metal experimental feature does not correctly toggle metal backend 
https://bugs.webkit.org/show_bug.cgi?id=229267
<rdar://81855735>

Source/WebCore:

Patch by Kyle Piddington <kpiddington@apple.com> on 2021-08-19
Reviewed by Dean Jackson.

GraphicsContextGLAttributes defines 'useMetal' as 'true' by default.
Since this branch was only checking if Metal was enabled via the
setting, rather than checking the status of the flag, the metal backend
was never disabled, even when requested.

Tests: webgl/webgl-metal-disabled.html
       webgl/webgl-metal-enabled.html

* WebCore.xcodeproj/project.pbxproj:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
* testing/Internals.cpp:
(WebCore::Internals::requestedMetal):
* testing/Internals.h:
* testing/Internals.idl:
* testing/Internals.mm:
(WebCore::Internals::platformSupportsMetal):

LayoutTests:

Add tests to verify WebGL feature flag works as intended.

Patch by Kyle Piddington <kpiddington@apple.com> on 2021-08-19
Reviewed by Dean Jackson.

* webgl/webgl-metal-disabled-expected.txt: Added.
* webgl/webgl-metal-disabled.html: Added.
* webgl/webgl-metal-enabled-expected.txt: Added.
* webgl/webgl-metal-enabled.html: Added.

Canonical link: https://commits.webkit.org/240682@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 		2021-08-19 16:28:04 +00:00
..
cocoa Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
js Deduplicate logging channel algorithms 2021-08-07 18:50:12 +00:00
FakeXRBoundsPoint.h
…
FakeXRBoundsPoint.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
FakeXRButtonStateInit.h
…
FakeXRButtonStateInit.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
FakeXRInputSourceInit.h
…
FakeXRInputSourceInit.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
FakeXRRigidTransformInit.h
…
FakeXRRigidTransformInit.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
FakeXRViewInit.h Remove <wtf/Optional.h> 2021-06-02 06:45:51 +00:00
FakeXRViewInit.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
GCObservation.cpp
…
GCObservation.h
…
GCObservation.idl
…
InternalSettings.cpp [iOS] Page background color does not update after UIUserInterfaceLevel change 2021-07-26 19:18:07 +00:00
InternalSettings.h [iOS] Page background color does not update after UIUserInterfaceLevel change 2021-07-26 19:18:07 +00:00
InternalSettings.idl [iOS] Page background color does not update after UIUserInterfaceLevel change 2021-07-26 19:18:07 +00:00
Internals.cpp WebGL via Metal experimental feature does not correctly toggle metal backend 2021-08-19 16:28:04 +00:00
Internals.h WebGL via Metal experimental feature does not correctly toggle metal backend 2021-08-19 16:28:04 +00:00
Internals.idl WebGL via Metal experimental feature does not correctly toggle metal backend 2021-08-19 16:28:04 +00:00
Internals.mm WebGL via Metal experimental feature does not correctly toggle metal backend 2021-08-19 16:28:04 +00:00
InternalsMapLike.cpp
…
InternalsMapLike.h
…
InternalsMapLike.idl
…
InternalsSetLike.cpp
…
InternalsSetLike.h
…
InternalsSetLike.idl
…
LegacyMockCDM.cpp
…
LegacyMockCDM.h
…
MallocStatistics.h
…
MallocStatistics.idl
…
MemoryInfo.h
…
MemoryInfo.idl
…
MockApplePaySetupFeature.cpp
…
MockApplePaySetupFeature.h
…
MockCDMFactory.cpp Reduce use of reinterpret_cast<> in the codebase 2021-06-08 17:35:15 +00:00
MockCDMFactory.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
MockCDMFactory.idl
…
MockContentFilter.cpp Use Vector<uint8_t> instead of Vector<char> to store bytes in SharedBuffer 2021-06-05 01:16:43 +00:00
MockContentFilter.h Use Vector<uint8_t> instead of Vector<char> to store bytes in SharedBuffer 2021-06-05 01:16:43 +00:00
MockContentFilterSettings.cpp
…
MockContentFilterSettings.h
…
MockContentFilterSettings.idl
…
MockGamepad.cpp
…
MockGamepad.h
…
MockGamepadProvider.cpp
…
MockGamepadProvider.h
…
MockLibWebRTCPeerConnection.cpp Update libwebrtc to M92 2021-06-10 14:38:22 +00:00
MockLibWebRTCPeerConnection.h Update libwebrtc to M92 2021-06-10 14:38:22 +00:00
MockMediaSessionCoordinator.cpp Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
MockMediaSessionCoordinator.h Reduce use of legacy EventLoopEventQueue and EventLoopTaskQueue 2021-06-06 19:13:07 +00:00
MockPageOverlay.cpp
…
MockPageOverlay.h
…
MockPageOverlay.idl
…
MockPageOverlayClient.cpp Remove duplicate LayerTreeAsText enums and use an OptionSet<> 2021-08-19 15:47:35 +00:00
MockPageOverlayClient.h Remove duplicate LayerTreeAsText enums and use an OptionSet<> 2021-08-19 15:47:35 +00:00
MockPayment.h
…
MockPaymentAddress.h
…
MockPaymentAddress.idl
…
MockPaymentContact.h
…
MockPaymentContactFields.h
…
MockPaymentContactFields.idl
…
MockPaymentCoordinator.cpp [Payment Request] `additionalShippingMethods` are not used if a `paymentMethodType` is provided 2021-07-30 00:28:45 +00:00
MockPaymentCoordinator.h Unreviewed, reverting r279546, r279554, r279558 and r279567. 2021-07-07 03:12:05 +00:00
MockPaymentCoordinator.idl [Payment Request] upstream new features 2021-06-08 22:15:18 +00:00
MockPaymentError.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
MockPaymentError.idl
…
MockPaymentMethod.h
…
MockPreviewLoaderClient.cpp
…
MockPreviewLoaderClient.h
…
MockWebAuthenticationConfiguration.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
MockWebAuthenticationConfiguration.idl Allow using the platform authenticator on non-Touch ID Macs according to Internal requirements 2021-04-16 23:52:30 +00:00
ServiceWorkerInternals.cpp Clean up App Privacy Report code 2021-07-08 20:54:04 +00:00
ServiceWorkerInternals.h Clean up App Privacy Report code 2021-07-08 20:54:04 +00:00
ServiceWorkerInternals.idl Clean up App Privacy Report code 2021-07-08 20:54:04 +00:00
ServiceWorkerInternals.mm
…
TypeConversions.h [WebIDL] Assigning a value outside the float range to a 'float' attribute should throw a TypeError 2021-06-19 02:16:19 +00:00
TypeConversions.idl [WebIDL] Assigning a value outside the float range to a 'float' attribute should throw a TypeError 2021-06-19 02:16:19 +00:00
WebCoreTestShimLibrary.cpp
…
WebFakeXRDevice.cpp SimulatedXRDevice::shutDownTrackingAndRendering() should clear it's GraphicsContextGL to ensure the resource is cleaned up quickly 2021-06-13 18:42:45 +00:00
WebFakeXRDevice.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebFakeXRDevice.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
WebFakeXRInputController.cpp [WebXR] Optional button test is incorrect 2021-04-22 21:56:07 +00:00
WebFakeXRInputController.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebFakeXRInputController.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
WebXRTest.cpp Use frameData instead of scheduleOnNextFrame calls in WebFakeXRDevice 2021-04-07 12:27:54 +00:00
WebXRTest.h Remove <wtf/Optional.h> 2021-06-02 06:45:51 +00:00
WebXRTest.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00
XRSimulateUserActivationFunction.h
…
XRSimulateUserActivationFunction.idl Move RuntimeEnabledFeatures to Settings (Part 1) 2021-04-17 20:07:30 +00:00