nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/animation/request-animation-frame-in-...

5 lines
129 B
Plaintext
Raw Permalink Normal View History

REGRESSION (WEBPROCESS_WINDOWSERVER_BLOCKING): requestAnimationFrame Stops Completing https://bugs.webkit.org/show_bug.cgi?id=190884 Reviewed by Dean Jackson. Source/WebCore: Only notify display refresh monitors with matching display ID. Test: fast/animation/request-animation-frame-in-two-pages.html * platform/graphics/DisplayRefreshMonitorManager.cpp: (WebCore::DisplayRefreshMonitorManager::displayWasUpdated): * platform/graphics/DisplayRefreshMonitorManager.h: Source/WebKit: Since the Web page currently owns the display link on the UI process side, the display link will be deleted in the UI process when a Web page is closed. This is incorrect, since a display link can be reused between Web pages in the WebContent process. This patch moves the ownership of the UI process display links to the Web process object to address this issue. Also, the display ID of the display being updated is included in the message to the WebContent process. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::resetStateAfterProcessExited): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/WebProcessProxy.h: * UIProcess/WebProcessProxy.messages.in: * UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::DisplayLink): (WebKit::DisplayLink::displayLinkCallback): * UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::displayID const): * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::startDisplayLink): Deleted. (WebKit::WebPageProxy::stopDisplayLink): Deleted. * UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::startDisplayLink): (WebKit::WebProcessProxy::stopDisplayLink): * WebProcess/WebPage/DrawingArea.h: * WebProcess/WebPage/DrawingArea.messages.in: * WebProcess/WebPage/mac/DrawingAreaMac.cpp: (WebKit::DisplayRefreshMonitorMac::create): (WebKit::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac): (WebKit::DisplayRefreshMonitorMac::~DisplayRefreshMonitorMac): (WebKit::DisplayRefreshMonitorMac::requestRefreshCallback): (WebKit::DrawingArea::createDisplayRefreshMonitor): (WebKit::DrawingArea::displayWasRefreshed): Deleted. * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::displayWasRefreshed): LayoutTests: * TestExpectations: * fast/animation/request-animation-frame-in-two-pages-expected.txt: Added. * fast/animation/request-animation-frame-in-two-pages.html: Added. * platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/206388@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-11-14 18:43:21 +00:00
This test succeeds if RAF is resumed in a page from where another page with RAF was opened and then closed.
Window closed.
PASS