nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/animation
History
Antti Koivisto 6cf98622d1 Animated pseudo element style resolved against wrong parent style 
https://bugs.webkit.org/show_bug.cgi?id=223990
rdar://74997361

Reviewed by Antoine Quint.
Source/WebCore:

In createAnimatedElementUpdate we get the parent and parent box styles from the parent stack.
This is wrong for pseudo elements. Their parent style should the host style which is not pushed to the stack.

This matters in style adjuster which may apply wrong adjustments as a result.

Test: fast/animation/pseudo-element-style-adjuster.html

* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoStyle):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Make static and provide the parent and parent box styles as parameters.

* style/StyleTreeResolver.h:

LayoutTests:

* fast/animation/pseudo-element-style-adjuster-expected.html: Added.
* fast/animation/pseudo-element-style-adjuster.html: Added.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Canonical link: https://commits.webkit.org/235962@main
 		2021-03-31 12:16:18 +00:00
..
resources Source/WebCore: 2020-05-13 23:28:34 +00:00
script-tests REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure 2020-02-11 11:31:58 +00:00
animation-display-style-adjustment-expected.html REGRESSION (r273003): Animated style may lose original display property value 2021-03-09 21:17:43 +00:00
animation-display-style-adjustment.html REGRESSION (r273003): Animated style may lose original display property value 2021-03-09 21:17:43 +00:00
animation-element-removal-expected.txt REGRESSION (r222040): Crash navigating out of gfycat.com url 2017-09-27 15:32:55 +00:00
animation-element-removal.html REGRESSION (r222040): Crash navigating out of gfycat.com url 2017-09-27 15:32:55 +00:00
animation-mixed-transform-crash-expected.html REGRESSION (222040): Google Maps Street View CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::PropertyWrapperAcceleratedTransform::blend const + 92 2017-09-26 15:51:55 +00:00
animation-mixed-transform-crash.html REGRESSION (222040): Google Maps Street View CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::PropertyWrapperAcceleratedTransform::blend const + 92 2017-09-26 15:51:55 +00:00
animation-position-crash-expected.html Animated keyframe style needs to go through full style adjuster 2021-02-17 17:27:21 +00:00
animation-position-crash.html Animated keyframe style needs to go through full style adjuster 2021-02-17 17:27:21 +00:00
animation-style-update-size-expected.txt 100% CPU on homedepot.com page 2016-10-15 08:27:19 +00:00
animation-style-update-size.html 100% CPU on homedepot.com page 2016-10-15 08:27:19 +00:00
css-animation-resuming-when-visible-expected.txt CSS transitions added while page is not visible do not start when the page becomes visible 2017-06-09 17:52:42 +00:00
css-animation-resuming-when-visible-with-style-change-expected.txt REGRESSION (r217997): mint.com header renders incorrectly when initially loaded 2017-06-14 15:40:51 +00:00
css-animation-resuming-when-visible-with-style-change.html [Web Animations] Turn Web Animations with CSS integration on 2018-09-27 09:49:52 +00:00
css-animation-resuming-when-visible-with-style-change2-expected.txt REGRESSION (r217997): mint.com header renders incorrectly when initially loaded 2017-06-14 15:40:51 +00:00
css-animation-resuming-when-visible-with-style-change2.html [Web Animations] Turn Web Animations with CSS integration on 2018-09-27 09:49:52 +00:00
css-animation-resuming-when-visible.html [Web Animations] Turn Web Animations with CSS integration on 2018-09-27 09:49:52 +00:00
css-animation-throttling-lowPowerMode-expected.txt [iOS] Throttle CSS animations to 30fps in low power mode 2017-03-06 23:07:50 +00:00
css-animation-throttling-lowPowerMode.html Unreviewed, rolling out r255158, 255405 and r255486 2020-02-13 17:11:28 +00:00
height-auto-transition-computed-value-expected.html REGRESSION (r193610): Drop down menu doesn’t expand at allofbach.com 2016-05-10 15:27:02 +00:00
height-auto-transition-computed-value.html [Web Animations] Turn Web Animations with CSS integration on 2018-09-27 09:49:52 +00:00
keyframe-rendererless-element-crash-expected.txt Crash in KeyframeEffect::getAnimatedStyle 2020-03-11 14:40:27 +00:00
keyframe-rendererless-element-crash.html Crash in KeyframeEffect::getAnimatedStyle 2020-03-11 14:40:27 +00:00
keyframe-with-font-size-in-em-units-expected.txt Crash when using 'em' units to specify font-size inside animation keyframe. 2014-07-30 03:51:31 +00:00
keyframe-with-font-size-in-em-units.html Crash when using 'em' units to specify font-size inside animation keyframe. 2014-07-30 03:51:31 +00:00
pseudo-element-style-adjuster-expected.html Animated pseudo element style resolved against wrong parent style 2021-03-31 12:16:18 +00:00
pseudo-element-style-adjuster.html Animated pseudo element style resolved against wrong parent style 2021-03-31 12:16:18 +00:00
request-animation-frame-callback-id-expected.txt
…
request-animation-frame-callback-id.html [RequestAnimationFrame] Remove vendor prefix 2012-10-12 19:48:38 +00:00
request-animation-frame-cancel-expected.txt [RequestAnimationFrame] Remove vendor prefix 2012-10-12 19:48:38 +00:00
request-animation-frame-cancel.html Merge split script tests 2017-05-24 22:53:00 +00:00
request-animation-frame-cancel2-expected.txt [mac] requestAnimationFrame support for mac port 2011-08-29 16:38:56 +00:00
request-animation-frame-cancel2.html [ Mac ] fast/animation/request-animation-frame-cancel2.html is flaky failing. 2020-05-05 18:44:58 +00:00
request-animation-frame-detach-element-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
request-animation-frame-detach-element.html Tools: 2017-05-04 21:46:39 +00:00
request-animation-frame-detach-element2-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
request-animation-frame-detach-element2.html Tools: 2017-05-04 21:46:39 +00:00
request-animation-frame-disabled-expected.txt
…
request-animation-frame-disabled.html Use window.internals instead of overridePreference to set WebCore settings in tests 2017-06-23 18:48:01 +00:00
request-animation-frame-during-modal-expected.txt
…
request-animation-frame-during-modal.html Tools: 2017-05-04 21:46:39 +00:00
request-animation-frame-expected.txt REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing 2020-01-27 18:39:00 +00:00
request-animation-frame-iframe-expected.txt Sync requestAnimationFrame callback to CVDisplayLink on Mac 2011-10-13 21:59:25 +00:00
request-animation-frame-iframe.html Tools: 2017-05-04 21:46:39 +00:00
request-animation-frame-iframe2-expected.txt requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client) 2012-09-27 22:25:36 +00:00
request-animation-frame-iframe2.html Tools: 2017-05-04 21:46:39 +00:00
request-animation-frame-in-two-pages-expected.txt REGRESSION (WEBPROCESS_WINDOWSERVER_BLOCKING): requestAnimationFrame Stops Completing 2018-11-14 18:43:21 +00:00
request-animation-frame-in-two-pages.html REGRESSION (WEBPROCESS_WINDOWSERVER_BLOCKING): requestAnimationFrame Stops Completing 2018-11-14 18:43:21 +00:00
request-animation-frame-missing-arguments-expected.txt [RequestAnimationFrame] Remove vendor prefix 2012-10-12 19:48:38 +00:00
request-animation-frame-missing-arguments.html Change fast/a* and fast/b* files to use pre and post js files in LayoutTests/resources. 2013-09-07 21:47:04 +00:00
request-animation-frame-prefix-expected.txt Changes to shared testing JS files should not cause test failures due to console message line numbers changing 2020-04-10 21:10:11 +00:00
request-animation-frame-prefix.html Merge split script tests 2017-05-24 22:53:00 +00:00
request-animation-frame-propagate-user-gesture-expected.txt Propagate user gestures through `requestAnimationFrame` just like `setTimeout` 2021-03-29 22:55:49 +00:00
request-animation-frame-propagate-user-gesture.html Propagate user gestures through `requestAnimationFrame` just like `setTimeout` 2021-03-29 22:55:49 +00:00
request-animation-frame-remove-client-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
request-animation-frame-remove-client.html Source/WebCore: Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded 2013-10-11 09:44:39 +00:00
request-animation-frame-remove-iframe-in-callback-expected.txt Crash beneath ScriptedAnimationController::serviceScriptedAnimations after a requestAnimationFrame callback removes the requesting iframe 2017-12-22 21:41:02 +00:00
request-animation-frame-remove-iframe-in-callback.html Crash beneath ScriptedAnimationController::serviceScriptedAnimations after a requestAnimationFrame callback removes the requesting iframe 2017-12-22 21:41:02 +00:00
request-animation-frame-throttle-inside-overflow-scroll-expected.txt Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-inside-overflow-scroll.html Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-subframe-display-none-expected.txt Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-subframe-display-none.html Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-subframe-expected.txt Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-subframe-zero-size-expected.txt Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-subframe-zero-size.html Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttle-subframe.html Source/WebCore: 2020-05-13 23:28:34 +00:00
request-animation-frame-throttling-detached-iframe-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
request-animation-frame-throttling-detached-iframe.html Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler 2020-05-04 21:24:49 +00:00
request-animation-frame-throttling-lowPowerMode-expected.txt REGRESSION (r272784): [macOS Release] fast/animation/request-animation-frame-throttling-lowPowerMode.html is a flaky failure 2021-02-13 00:32:09 +00:00
request-animation-frame-throttling-lowPowerMode.html REGRESSION (r272784): [macOS Release] fast/animation/request-animation-frame-throttling-lowPowerMode.html is a flaky failure 2021-02-13 00:32:09 +00:00
request-animation-frame-throttling-outside-viewport-expected.txt Source/WebCore: 2020-05-13 23:28:34 +00:00
request-animation-frame-throttling-outside-viewport.html Source/WebCore: 2020-05-13 23:28:34 +00:00
request-animation-frame-time-unit-expected.txt [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds 2013-04-09 14:31:35 +00:00
request-animation-frame-time-unit.html Merge split script tests 2017-05-24 22:53:00 +00:00
request-animation-frame-timestamps-advance-expected.txt
…
request-animation-frame-timestamps-advance.html Merge split script tests 2017-05-24 22:53:00 +00:00
request-animation-frame-timestamps-expected.txt [ Mac ] fast/animation/request-animation-frame-timestamps.html is flaky failing. 2020-05-05 19:30:03 +00:00
request-animation-frame-timestamps.html [ Mac ] fast/animation/request-animation-frame-timestamps.html is flaky failing. 2020-05-05 19:30:03 +00:00
request-animation-frame-too-rapid-expected.txt Coordinated Graphics: Animation jerkiness when rAF is enabled 2012-10-28 01:32:58 +00:00
request-animation-frame-too-rapid.html Merge split script tests 2017-05-24 22:53:00 +00:00
request-animation-frame-unique-timestamp-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
request-animation-frame-unique-timestamp.html Consecutive requestAnimationFrame callbacks may be passed the same timestamp 2020-09-03 16:31:05 +00:00
request-animation-frame-unparented-iframe-crash-expected.txt Reproducible null deref under ScriptedAnimationController::createDisplayRefreshMonitor 2015-03-17 19:15:54 +00:00
request-animation-frame-unparented-iframe-crash.html Reproducible null deref under ScriptedAnimationController::createDisplayRefreshMonitor 2015-03-17 19:15:54 +00:00
request-animation-frame-within-callback-expected.txt
…
request-animation-frame-within-callback.html Merge split script tests 2017-05-24 22:53:00 +00:00
request-animation-frame.html REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing 2020-01-27 18:39:00 +00:00