haikuwebkit/Tools/WebKitTestRunner/cocoa
Wenson Hsieh 58daa961d4 [iOS] Remove support for the meaningful tap heuristic
https://bugs.webkit.org/show_bug.cgi?id=229298
rdar://82130066

Reviewed by Tim Horton.

Source/WebCore:

See WebKit ChangeLog for more details.

* page/ChromeClient.h:
(WebCore::ChromeClient::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

Source/WebKit:

Remove all support for the meaningful tap heuristic, which was used to allow users to toggle tab pill visibility
in earlier versions of the Safari redesign. As of the latest iOS 15 beta, this heuristic is no longer necessary,
so we don't need this SPI support anymore.

* UIProcess/API/APIUIClient.h:
(API::UIClient::didNotHandleTapAsClick):
(API::UIClient::didTapAtPoint): Deleted.
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
* UIProcess/API/ios/WKWebViewTestingIOS.mm:
(-[WKWebView _didTapAtPoint:withResult:]): Deleted.
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didTapAtPoint): Deleted.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didTapAtPoint): Deleted.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didTapAtPoint): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::isPlayingMediaDidChange):
* WebProcess/WebPage/WebPage.h:

Drive-by fix: initialize `m_appHighlightsVisible` using the correct type.

(WebKit::WebPage::platformNeedsLayoutForEditorState const):
(WebKit::WebPage::prepareToRunModalJavaScriptDialog):
(WebKit::WebPage::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted.
(WebKit::WebPage::platformIsPlayingMediaDidChange): Deleted.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::attemptSyntheticClick):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTapFailed):
(WebKit::WebPage::clearSelectionAfterTapIfNeeded):
(WebKit::isProbablyMeaningfulClick): Deleted.
(WebKit::WebPage::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted.
(WebKit::WebPage::platformIsPlayingMediaDidChange): Deleted.

Tools:

Remove test runner support for testing the meaningful tap heuristic.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::installDidHandleTapCallback): Deleted.
(WTR::TestRunner::callDidHandleTapCallback): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didHandleTap): Deleted.
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didHandleTap): Deleted.
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView _didTapAtPoint:withResult:]): Deleted.

LayoutTests:

Remove all layout tests that exercised the meaningful tap heuristic.

* fast/events/ios/did-not-handle-meaningful-click-expected.txt: Removed.
* fast/events/ios/did-not-handle-meaningful-click.html: Removed.
* fast/events/ios/meaningful-click-when-focusing-body-expected.txt: Removed.
* fast/events/ios/meaningful-click-when-focusing-body.html: Removed.
* fast/events/ios/meaningful-click-when-playing-media-expected.txt: Removed.
* fast/events/ios/meaningful-click-when-playing-media.html: Removed.
* fast/events/ios/meaningful-click-when-tapping-draggable-content-expected.txt: Removed.
* fast/events/ios/meaningful-click-when-tapping-draggable-content.html: Removed.
* fast/events/ios/non-meaningful-click-when-tapping-document-expected.txt: Removed.
* fast/events/ios/non-meaningful-click-when-tapping-document.html: Removed.


Canonical link: https://commits.webkit.org/240704@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-08-19 23:17:35 +00:00
..
CrashReporterInfo.h
CrashReporterInfo.mm Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms 2020-09-29 21:38:57 +00:00
StringFunctionsCocoa.h AX: Improve string conversion in AccessibilityController::injectAccessibilityPreference 2021-05-26 00:15:23 +00:00
TestControllerCocoa.mm Allow layout tests to specify app initiated loads or not 2021-07-13 16:40:12 +00:00
TestRunnerWKWebView.h Clean up App Privacy Report code 2021-07-08 20:54:04 +00:00
TestRunnerWKWebView.mm [iOS] Remove support for the meaningful tap heuristic 2021-08-19 23:17:35 +00:00
TestWebsiteDataStoreDelegate.h
TestWebsiteDataStoreDelegate.mm
UIScriptControllerCocoa.h [macOS] change for the language/subtitle tracks button to use an `NSMenu` instead of web content 2021-03-16 21:57:18 +00:00
UIScriptControllerCocoa.mm [macOS] change for the language/subtitle tracks button to use an `NSMenu` instead of web content 2021-03-16 21:57:18 +00:00