haikuwebkit/Source/WebKitLegacy/mac/WebCoreSupport
Simon Fraser 7453a87420 Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates
https://bugs.webkit.org/show_bug.cgi?id=229243

Reviewed by Wenson Hsieh.

The result of Element::clientRect() is in the coordinate space of the root view,
not in the space of the Element's Frame, so does not match the other functions on Element
with "client" in the name.

Rename to Element::boundingBoxInRootViewCoordinates() for clarity.

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::boundingBoxInRootViewCoordinates const):
(WebCore::Element::clientRect const): Deleted.
* dom/Element.h:
* html/MediaElementSession.cpp:
(WebCore::isElementMainContentForPurposesOfAutoplay):
(WebCore::isElementRectMostlyInMainFrame):
* page/Page.cpp:
(WebCore::Page::editableElementsInRect const):

Source/WebKit:

* WebProcess/WebCoreSupport/WebValidationMessageClient.cpp:
(WebKit::WebValidationMessageClient::showValidationMessage):
(WebKit::WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::contextForElement const):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::isObscuredElement):
(WebKit::WebPage::textInputContextsInRect):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebValidationMessageClient.mm:
(WebValidationMessageClient::showValidationMessage):
(WebValidationMessageClient::updateValidationBubbleStateIfNeeded):

Canonical link: https://commits.webkit.org/240690@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-08-19 18:24:00 +00:00
..
CorrectionPanel.h
CorrectionPanel.mm
PopupMenuMac.h
PopupMenuMac.mm
SearchPopupMenuMac.h
SearchPopupMenuMac.mm
WebAlternativeTextClient.h
WebAlternativeTextClient.mm
WebApplicationCache.h
WebApplicationCache.mm Update ApplicationCacheStorage::originsWithCache() to return a HashSet<SecurityOriginData> instead of a Vector<Ref<SecurityOrigin>> 2021-03-06 01:23:53 +00:00
WebApplicationCacheInternal.h
WebApplicationCacheQuotaManager.h
WebApplicationCacheQuotaManager.mm Update ApplicationCacheStorage::originsWithCache() to return a HashSet<SecurityOriginData> instead of a Vector<Ref<SecurityOrigin>> 2021-03-06 01:23:53 +00:00
WebCachedFramePlatformData.h
WebChromeClient.h Pipe App Highlight scrolling through UI Process in preparation for Note Overlay avoidance. 2021-07-16 17:17:17 +00:00
WebChromeClient.mm Rename scrollRectIntoView to scrollContainingScrollViewsToRevealRect for clarity. 2021-07-15 21:04:58 +00:00
WebContextMenuClient.h [macOS] [WebKitLegacy] Non-actionable "Look Up" action appears when right clicking images 2021-06-22 01:22:20 +00:00
WebContextMenuClient.mm Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.) 2021-05-25 01:26:18 +00:00
WebCreateFragmentInternal.h
WebDeviceOrientationClient.h
WebDeviceOrientationClient.mm
WebDragClient.h
WebDragClient.mm Deduplicate logging channel algorithms 2021-08-07 18:50:12 +00:00
WebEditorClient.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebEditorClient.mm Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebFrameLoaderClient.h Use Vector<uint8_t> instead of Vector<char> to store bytes in SharedBuffer 2021-06-05 01:16:43 +00:00
WebFrameLoaderClient.mm Re-enable legacy WebView plug-ins (but not NPAPI) 2021-06-10 18:53:36 +00:00
WebFrameNetworkingContext.h
WebFrameNetworkingContext.mm
WebGeolocationClient.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebGeolocationClient.mm Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebInspectorClient.h
WebInspectorClient.mm Update Base64 encoding/decoding to match more modern WebKit conventions 2021-05-19 18:43:29 +00:00
WebJavaScriptTextInputPanel.h
WebJavaScriptTextInputPanel.m
WebKitFullScreenListener.h
WebKitFullScreenListener.mm
WebMediaKeySystemClient.h Unreviewed build fix. Reapply r272500. 2021-02-09 21:01:48 +00:00
WebMediaKeySystemClient.mm Permission request API for MediaKeySystem access support 2021-02-09 12:46:22 +00:00
WebNotificationClient.h Notification.requestPermission() should return a Promise 2021-05-13 05:02:45 +00:00
WebNotificationClient.mm Notification.requestPermission() should return a Promise 2021-05-13 05:02:45 +00:00
WebOpenPanelResultListener.h
WebOpenPanelResultListener.mm
WebPaymentCoordinatorClient.h [Payment Request] upstream new features 2021-06-08 22:15:18 +00:00
WebPaymentCoordinatorClient.mm [Payment Request] upstream new features 2021-06-08 22:15:18 +00:00
WebPlatformStrategies.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebPlatformStrategies.mm Add Cross-Origin-Embedder-Policy support for Blob URLs 2021-08-14 02:28:19 +00:00
WebPluginInfoProvider.h Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebPluginInfoProvider.mm Remove WTF::Optional synonym for std::optional, using that class template directly instead 2021-05-30 16:11:40 +00:00
WebProgressTrackerClient.h
WebProgressTrackerClient.mm Reduce use of CFRetain() / CFRelease() / CFAutoRelease() in WebKit 2021-03-05 15:44:47 +00:00
WebSecurityOrigin.mm Next step toward using std::optional directly instead of through WTF::Optional typedef 2021-05-28 01:26:23 +00:00
WebSecurityOriginInternal.h
WebSecurityOriginPrivate.h
WebSelectionServiceController.h
WebSelectionServiceController.mm
WebSwitchingGPUClient.cpp
WebSwitchingGPUClient.h
WebValidationMessageClient.h
WebValidationMessageClient.mm Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates 2021-08-19 18:24:00 +00:00
WebVisitedLinkStore.h
WebVisitedLinkStore.mm