efef7c01b3
https://bugs.webkit.org/show_bug.cgi?id=227534 Reviewed by Chris Dumez. This makes <dialog> emit a cancel event then close when the escape key is pressed. Updated relevant WPT: - <dialog> cancel event WPTs: used send_keys instead of test_driver.Actions() (which are unsupported by WebKit test runner) - oncancel now is recognized Failing WPT: - dialog-cancel-with-input.html: needs <dialog> focusing steps (webkit.org/b/227537) to be implemented for <input> to get focus - dialog-cancel-with-select.html: needs <dialog> focusing steps (webkit.org/b/227537) to be implemented for <select> to get focus - dialog-keydown-preventDefault.html: current implementation does not prevent canceling from happening when keydown event has preventDefault() LayoutTests/imported/w3c: * web-platform-tests/html/browsers/the-window-object/security-window/window-security.https-expected.txt: * web-platform-tests/html/browsers/the-window-object/window-properties.https-expected.txt: * web-platform-tests/html/dom/idlharness.https-expected.txt: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-events-expected.txt: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-events.html: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-preventDefault-expected.txt: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-preventDefault.html: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-with-input-expected.txt: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-with-input.html: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-with-select.html: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-keydown-preventDefault-expected.txt: * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-keydown-preventDefault.html: * web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events-expected.txt: * web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt: * web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body-expected.txt: * web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Source/WebCore: * dom/GlobalEventHandlers.idl: * html/HTMLAttributeNames.in: * html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::cancel): * html/HTMLDialogElement.h: * html/HTMLElement.cpp: (WebCore::HTMLElement::createEventHandlerNameMap): * page/EventHandler.cpp: (WebCore::EventHandler::internalKeyEvent): LayoutTests: * platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-events-expected.txt: Added. * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-preventDefault-expected.txt: Added. * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-with-input-expected.txt: Added. * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-keydown-preventDefault-expected.txt: Added. * platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Canonical link: https://commits.webkit.org/240299@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280703 268f45cc-cd09-0410-ab3c-d52691b4dbfc |
||
---|---|---|
.. | ||
content-security-policy | ||
css/css-fonts/math-script-level-and-math-style | ||
custom-elements | ||
dom/nodes | ||
fetch/api/cors | ||
html | ||
mathml | ||
media-source | ||
pointerevents | ||
service-workers/service-worker | ||
shadow-dom | ||
web-share | ||
websockets |