e0a2ffa35b
https://bugs.webkit.org/show_bug.cgi?id=220111 Reviewed by Wenson Hsieh. Source/WebCore: Code variously used "canScrollHorizontally" and "hasEnabledHorizontalScrollbar". Standardize on "allowsHorizontalScrolling". This returns true both when there is overflow to scroll, and when style allows it (i.e. not overflow-x: hidden). This changes the name and dumping for ScrollableAreaParams so lots of test results change. * page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry): * page/scrolling/ScrollingCoordinator.cpp: (WebCore::operator<<): * page/scrolling/ScrollingCoordinatorTypes.h: (WebCore::ScrollableAreaParameters::operator== const): * page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const): * page/scrolling/ScrollingTreeScrollingNode.h: * page/scrolling/ScrollingTreeScrollingNodeDelegate.h: (WebCore::ScrollingTreeScrollingNodeDelegate::allowsHorizontalScrolling const): (WebCore::ScrollingTreeScrollingNodeDelegate::allowsVerticalScrolling const): (WebCore::ScrollingTreeScrollingNodeDelegate::hasEnabledHorizontalScrollbar const): Deleted. (WebCore::ScrollingTreeScrollingNodeDelegate::hasEnabledVerticalScrollbar const): Deleted. * page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h: * page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const): (WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const): (WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalScrolling const): (WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalScrolling const): (WebCore::ScrollingTreeScrollingNodeDelegateMac::canScrollHorizontally const): Deleted. (WebCore::ScrollingTreeScrollingNodeDelegateMac::canScrollVertically const): Deleted. * platform/ScrollableArea.cpp: (WebCore::ScrollableArea::allowsHorizontalScrolling const): (WebCore::ScrollableArea::allowsVerticalScrolling const): * platform/ScrollableArea.h: * platform/cocoa/ScrollController.h: * platform/cocoa/ScrollController.mm: (WebCore::ScrollController::snapRubberBandTimerFired): * platform/mac/ScrollAnimatorMac.h: * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::allowsHorizontalScrolling const): (WebCore::ScrollAnimatorMac::allowsVerticalScrolling const): (WebCore::ScrollAnimatorMac::canScrollHorizontally const): Deleted. (WebCore::ScrollAnimatorMac::canScrollVertically const): Deleted. * platform/mock/ScrollAnimatorMock.h: Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<ScrollableAreaParameters>::encode): (IPC::ArgumentCoder<ScrollableAreaParameters>::decode): LayoutTests: * fast/scrolling/ios/change-scrollability-on-content-resize-expected.txt: * fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt: * fast/scrolling/ios/scrollbar-hiding-expected.txt: * fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt: * fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt: * fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt: * platform/ipad/fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt: * platform/ipad/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt: * platform/wpe/scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt: * scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt: * scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow-expected.txt: * scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow-expected.txt: * scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2-expected.txt: * scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-dynamic-expected.txt: * scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-expected.txt: * scrollingcoordinator/mac/fixed-backgrounds/fixed-background-on-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt: * scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt: * scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt: * scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt: * scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt: * scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt: * scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt: * scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: * scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt: * scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt: * scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: * scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt: * scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt: * scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt: * scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt: * scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: * scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt: * scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt: * scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt: * scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt: * scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt: * tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt: * tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt: * tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt: * tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt: * tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt: * tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: * tiled-drawing/scrolling/fixed/four-bars-expected.txt: * tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt: * tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt: * tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt: * tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt: * tiled-drawing/scrolling/fixed/nested-fixed-expected.txt: * tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt: * tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt: * tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt: * tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt: * tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt: * tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt: Canonical link: https://commits.webkit.org/232667@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271070 268f45cc-cd09-0410-ab3c-d52691b4dbfc |
||
|---|---|---|
| .. | ||
| ios | ||
| tiled-drawing | ||
| watchos | ||
| client-coordinates-relative-to-layout-viewport-expected.txt | ||
| client-coordinates-relative-to-layout-viewport.html | ||
| client-rects-relative-to-layout-viewport-expected.txt | ||
| client-rects-relative-to-layout-viewport-zoomed-expected.txt | ||
| client-rects-relative-to-layout-viewport-zoomed.html | ||
| client-rects-relative-to-layout-viewport.html | ||
| nonzoomed-rects-expected.txt | ||
| nonzoomed-rects.html | ||
| resize-event-fired-expected.txt | ||
| resize-event-fired-window-resized-expected.txt | ||
| resize-event-fired-window-resized.html | ||
| resize-event-fired.html | ||
| rtl-nonzoomed-rects-expected.txt | ||
| rtl-nonzoomed-rects.html | ||
| rtl-zoomed-rects-expected.txt | ||
| rtl-zoomed-rects.html | ||
| rubberbanding-viewport-rects-expected.txt | ||
| rubberbanding-viewport-rects-extended-background-expected.txt | ||
| rubberbanding-viewport-rects-extended-background.html | ||
| rubberbanding-viewport-rects-header-footer-expected.txt | ||
| rubberbanding-viewport-rects-header-footer.html | ||
| rubberbanding-viewport-rects.html | ||
| scroll-event-fired-during-scroll-alone-expected.txt | ||
| scroll-event-fired-during-scroll-alone.html | ||
| scroll-event-fired-expected.txt | ||
| scroll-event-fired.html | ||
| viewport-dimensions-exclude-custom-scrollbars-expected.txt | ||
| viewport-dimensions-exclude-custom-scrollbars.html | ||
| viewport-dimensions-exclude-scrollbars-expected.txt | ||
| viewport-dimensions-exclude-scrollbars.html | ||
| viewport-dimensions-expected.txt | ||
| viewport-dimensions-iframe-expected.txt | ||
| viewport-dimensions-iframe.html | ||
| viewport-dimensions-under-page-zoom-expected.txt | ||
| viewport-dimensions-under-page-zoom.html | ||
| viewport-dimensions.html | ||
| visual-viewport-resize-subframe-in-rendering-update-expected.txt | ||
| visual-viewport-resize-subframe-in-rendering-update.html | ||
| visual-viewport-same-object-expected.txt | ||
| visual-viewport-same-object.html | ||
| visual-viewport-scroll-after-resize-in-subframe-expected.txt | ||
| visual-viewport-scroll-after-resize-in-subframe.html | ||
| zoomed-fixed-expected.txt | ||
| zoomed-fixed-header-and-footer-expected.txt | ||
| zoomed-fixed-header-and-footer.html | ||
| zoomed-fixed-scroll-down-then-up-expected.txt | ||
| zoomed-fixed-scroll-down-then-up.html | ||
| zoomed-fixed.html | ||
| zoomed-rects-expected.txt | ||
| zoomed-rects.html | ||
| zoomed-scroll-into-view-fixed-expected.txt | ||
| zoomed-scroll-into-view-fixed.html | ||
| zoomed-scroll-to-anchor-in-position-fixed-expected.txt | ||
| zoomed-scroll-to-anchor-in-position-fixed.html | ||