Wenson Hsieh 58daa961d4 [iOS] Remove support for the meaningful tap heuristic ... https://bugs.webkit.org/show_bug.cgi?id=229298 rdar://82130066 Reviewed by Tim Horton. Source/WebCore: See WebKit ChangeLog for more details. * page/ChromeClient.h: (WebCore::ChromeClient::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent): Source/WebKit: Remove all support for the meaningful tap heuristic, which was used to allow users to toggle tab pill visibility in earlier versions of the Safari redesign. As of the latest iOS 15 beta, this heuristic is no longer necessary, so we don't need this SPI support anymore. * UIProcess/API/APIUIClient.h: (API::UIClient::didNotHandleTapAsClick): (API::UIClient::didTapAtPoint): Deleted. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h: * UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _didTapAtPoint:withResult:]): Deleted. * UIProcess/Cocoa/UIDelegate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::didTapAtPoint): Deleted. * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::didTapAtPoint): Deleted. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didTapAtPoint): Deleted. * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::isPlayingMediaDidChange): * WebProcess/WebPage/WebPage.h: Drive-by fix: initialize `m_appHighlightsVisible` using the correct type. (WebKit::WebPage::platformNeedsLayoutForEditorState const): (WebKit::WebPage::prepareToRunModalJavaScriptDialog): (WebKit::WebPage::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. (WebKit::WebPage::platformIsPlayingMediaDidChange): Deleted. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::completeSyntheticClick): (WebKit::WebPage::attemptSyntheticClick): (WebKit::WebPage::handleTwoFingerTapAtPoint): (WebKit::WebPage::commitPotentialTapFailed): (WebKit::WebPage::clearSelectionAfterTapIfNeeded): (WebKit::isProbablyMeaningfulClick): Deleted. (WebKit::WebPage::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. (WebKit::WebPage::platformIsPlayingMediaDidChange): Deleted. Tools: Remove test runner support for testing the meaningful tap heuristic. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::installDidHandleTapCallback): Deleted. (WTR::TestRunner::callDidHandleTapCallback): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didHandleTap): Deleted. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didHandleTap): Deleted. * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _didTapAtPoint:withResult:]): Deleted. LayoutTests: Remove all layout tests that exercised the meaningful tap heuristic. * fast/events/ios/did-not-handle-meaningful-click-expected.txt: Removed. * fast/events/ios/did-not-handle-meaningful-click.html: Removed. * fast/events/ios/meaningful-click-when-focusing-body-expected.txt: Removed. * fast/events/ios/meaningful-click-when-focusing-body.html: Removed. * fast/events/ios/meaningful-click-when-playing-media-expected.txt: Removed. * fast/events/ios/meaningful-click-when-playing-media.html: Removed. * fast/events/ios/meaningful-click-when-tapping-draggable-content-expected.txt: Removed. * fast/events/ios/meaningful-click-when-tapping-draggable-content.html: Removed. * fast/events/ios/non-meaningful-click-when-tapping-document-expected.txt: Removed. * fast/events/ios/non-meaningful-click-when-tapping-document.html: Removed. Canonical link: https://commits.webkit.org/240704@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281279 268f45cc-cd09-0410-ab3c-d52691b4dbfc		2021-08-19 23:17:35 +00:00
..
ipad	Remove experimental: and internal: prefixes from test header commands	2020-11-04 15:56:26 +00:00
key-events-comprehensive	…
resources	…
rotation	[Testing] Rename test header commands to match names in WebPreferences*.yaml	2020-10-13 17:16:15 +00:00
activating-button-should-not-scroll-page-expected.txt	…
activating-button-should-not-scroll-page.html	…
activating-checkbox-should-not-scroll-page-expected.txt	…
activating-checkbox-should-not-scroll-page.html	…
activating-radio-button-should-not-scroll-page-expected.txt	…
activating-radio-button-should-not-scroll-page.html	…
activating-reset-button-should-not-scroll-page-expected.txt	…
activating-reset-button-should-not-scroll-page.html	…
activating-submit-button-should-not-scroll-page-expected.txt	…
activating-submit-button-should-not-scroll-page.html	…
autocorrect-after-image-expected.txt	…
autocorrect-after-image.html	…
autocorrect-with-apostrophe-expected.txt	…
autocorrect-with-apostrophe.html	…
autocorrect-with-range-selection-expected.txt	…
autocorrect-with-range-selection.html	…
before-input-events-prevent-candidate-insertion-expected.txt	…
before-input-events-prevent-candidate-insertion.html	…
click-event-and-display-contents-expected.txt	…
click-event-and-display-contents.html	…
click-event-timestamp-expected.txt	…
click-event-timestamp.html	…
click-event-two-finger-single-tap-meta-key-expected.txt	…
click-event-two-finger-single-tap-meta-key.html	…
click-event-while-editing-node-expected.txt	…
click-event-while-editing-node.html	…
click-in-autofocused-input-when-tapping-near-caret-expected.txt	…
click-in-autofocused-input-when-tapping-near-caret.html	…
click-selectionchange-once-expected.txt	…
click-selectionchange-once.html	…
clicking-document-should-not-trigger-focus-expected.txt	…
clicking-document-should-not-trigger-focus.html	…
command+shift+v-should-not-insert-v-expected.txt	…
command+shift+v-should-not-insert-v.html	…
contenteditable-autocapitalize-expected.txt	…
contenteditable-autocapitalize.html	…
do-not-show-keyboard-when-focusing-after-blur-expected.txt	…
do-not-show-keyboard-when-focusing-after-blur.html	[Testing] Rename test header commands to match names in WebPreferences*.yaml	2020-10-13 17:16:15 +00:00
dom-update-on-keydown-quirk-expected.txt	…
dom-update-on-keydown-quirk.html	…
double-tap-zoom-expected.txt	…
double-tap-zoom.html	…
dragstart-on-image-by-long-pressing-expected.txt	fast/events/ios/dragstart-on-image-by-long-pressing.html sometimes fails with a text diff	2021-04-27 18:10:58 +00:00
dragstart-on-image-by-long-pressing.html	fast/events/ios/dragstart-on-image-by-long-pressing.html sometimes fails with a text diff	2021-04-27 18:10:58 +00:00
event-stream-single-tap-expected.txt	…
event-stream-single-tap.html	…
fast-click-double-tap-sends-click-expected.txt	…
fast-click-double-tap-sends-click-when-initial-scale-expected.txt	…
fast-click-double-tap-sends-click-when-initial-scale.html	…
fast-click-double-tap-sends-click.html	…
fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out-expected.txt	Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many)	2020-09-27 02:15:19 +00:00
fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out.html	Double tap to zoom out doesn't work after upgrading to iOS 13	2020-06-12 18:24:02 +00:00
fast-click-double-tap-zooms-on-image-expected.txt	…
fast-click-double-tap-zooms-on-image.html	…
fast-click-double-tap-zooms-on-text-expected.txt	…
fast-click-double-tap-zooms-on-text.html	…
fire-input-and-keypress-on-return-key-expected.txt	…
fire-input-and-keypress-on-return-key.html	…
focus-tab-next-field-expected.txt	…
focus-tab-next-field.html	…
focus-tab-previous-field-expected.txt	…
focus-tab-previous-field.html	…
focused-input-should-assist-on-touch-expected.txt	…
focused-input-should-assist-on-touch.html	…
forward-delete-in-editable-expected.txt	…
forward-delete-in-editable.html	…
input-events-fired-when-typing-in-contenteditable-expected.txt	Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many)	2020-09-27 02:15:19 +00:00
input-events-fired-when-typing-in-contenteditable.html	…
input-events-insert-replacement-text-expected.txt	…
input-events-insert-replacement-text.html	…
input-value-after-oninput-expected.txt	…
input-value-after-oninput.html	…
key-command-delete-next-word-expected.txt	…
key-command-delete-next-word.html	…
key-command-delete-to-end-of-paragraph-expected.txt	…
key-command-delete-to-end-of-paragraph.html	…
key-command-italic-dispatches-keydown-expected.txt	…
key-command-italic-dispatches-keydown.html	…
key-command-italic-expected.txt	…
key-command-italic.html	…
key-command-select-all-prevent-default.html	…
key-command-transpose-expected.txt	…
key-command-transpose.html	…
keyboard-event-key-attribute-expected.txt	…
keyboard-event-key-attribute.html	…
keyboard-scrolling-distance-expected.txt	…
keyboard-scrolling-distance.html	…
keyboard-should-not-trigger-resize-expected.txt	…
keyboard-should-not-trigger-resize.html	…
keydown-keyup-arrow-keys-in-non-editable-element-expected.txt	…
keydown-keyup-arrow-keys-in-non-editable-element.html	…
keydown-keyup-in-non-editable-content-expected.txt	…
keydown-keyup-in-non-editable-content.html	…
keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard-expected.txt	…
keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard.html	…
keydown-keyup-special-keys-in-non-editable-element-expected.txt	…
keydown-keyup-special-keys-in-non-editable-element.html	…
keypress-grave-accent-expected.txt	…
keypress-grave-accent.html	…
keypress-keys-in-non-editable-element-expected.txt	…
keypress-keys-in-non-editable-element.html	…
keyup-expected.txt	…
keyup.html	…
multiple-key-press-and-release-ordering-expected.txt	…
multiple-key-press-and-release-ordering.html	…
no-fast-click-double-tap-causes-zoom-expected.txt	…
no-fast-click-double-tap-causes-zoom.html	…
no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt	…
no-touch-events-when-stopping-momentum-scroll-in-mainframe.html	…
no-touch-events-when-stopping-momentum-scroll-in-overflow-expected.txt	…
no-touch-events-when-stopping-momentum-scroll-in-overflow.html	Remove experimental: and internal: prefixes from test header commands	2020-11-04 15:56:26 +00:00
pdf-modifer-key-down-crash-expected.txt	…
pdf-modifer-key-down-crash.html	[Testing] Rename test header commands to match names in WebPreferences*.yaml	2020-10-13 17:16:15 +00:00
select-all-with-existing-selection-expected.txt	…
select-all-with-existing-selection.html	…
should-be-able-to-dismiss-form-accessory-after-tapping-outside-iframe-with-focused-field-expected.txt	…
should-be-able-to-dismiss-form-accessory-after-tapping-outside-iframe-with-focused-field.html	…
show-modal-alert-during-focus-expected.txt	[iOS] UI process hangs when showing a modal JavaScript dialog while focusing an input field	2021-05-06 16:54:12 +00:00
show-modal-alert-during-focus.html	[iOS] UI process hangs when showing a modal JavaScript dialog while focusing an input field	2021-05-06 16:54:12 +00:00
single-tap-generates-click-expected.txt	…
single-tap-generates-click.html	…
submit-form-target-blank-using-return-key-expected.txt	…
submit-form-target-blank-using-return-key.html	Remove remaining alternative preference setting mechanisms from LayoutTests	2020-11-01 20:09:38 +00:00
tab-cycle-expected.txt	…
tab-cycle.html	…
tab-into-text-field-inside-iframe-expected.txt	…
tab-into-text-field-inside-iframe.html	…
thin-gradient.jpg	…
touch-events-during-scroll-deceleration-in-overflow-expected.txt	…
touch-events-during-scroll-deceleration-in-overflow.html	Remove experimental: and internal: prefixes from test header commands	2020-11-04 15:56:26 +00:00
type-digits-holding-control-key-expected.txt	…
type-digits-holding-control-key.html	…
unscalable-viewport-clicks-on-doubletap-expected.txt	…
unscalable-viewport-clicks-on-doubletap.html	…
viewport-device-width-allows-double-tap-zoom-out-expected.txt	…
viewport-device-width-allows-double-tap-zoom-out.html	…
viewport-device-width-at-initial-scale-fast-clicks-expected.txt	…
viewport-device-width-at-initial-scale-fast-clicks.html	…
viewport-no-width-value-allows-double-tap-expected.txt	…
viewport-no-width-value-allows-double-tap.html	…
viewport-shrink-to-fit-allows-double-tap-expected.txt	…
viewport-shrink-to-fit-allows-double-tap.html	…
viewport-zooms-from-element-to-initial-scale-expected.txt	…
viewport-zooms-from-element-to-initial-scale.html	…