haikuwebkit/LayoutTests/fast/dom/Range
Antti Koivisto b7afbed06d [LFC][Integration] RenderText::absoluteQuadsForRange should use iterator
https://bugs.webkit.org/show_bug.cgi?id=218444

Reviewed by Zalan Bujtas.

Source/WebCore:

Add the required iterator support and convert absoluteQuadsForRange to use it.
This eliminates ensureLineBoxes from two places.

* layout/integration/LayoutIntegrationRunIterator.h:
(WebCore::LayoutIntegration::PathTextRun::isSelectable const):
(WebCore::LayoutIntegration::PathTextRun::selectionRect const):
* layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:
(WebCore::LayoutIntegration::RunIteratorLegacyPath::isSelectable const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::selectionRect const):
* layout/integration/LayoutIntegrationRunIteratorModernPath.h:
(WebCore::LayoutIntegration::RunIteratorModernPath::offsetForPosition const):
(WebCore::LayoutIntegration::RunIteratorModernPath::isSelectable const):
(WebCore::LayoutIntegration::RunIteratorModernPath::selectionRect const):
(WebCore::LayoutIntegration::RunIteratorModernPath::clampedOffset const):
(WebCore::LayoutIntegration::RunIteratorModernPath::createTextRun const):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange const):
(WebCore::localQuadForTextRun):
(WebCore::RenderText::absoluteQuadsForRange const):
* rendering/RenderTextLineBoxes.cpp:
(WebCore::localQuadForTextBox): Deleted.
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange const): Deleted.
(WebCore::RenderTextLineBoxes::absoluteRectsForRange const): Deleted.
* rendering/RenderTextLineBoxes.h:

LayoutTests:

* fast/dom/Range/getBoundingClientRect-expected.txt:
* fast/dom/Range/getBoundingClientRect.html:

On legacy path <br> y position is miscomputed affecting getBoundingClientRect().
Update the test to match the new behavior. Results now match Firefox and Chrome.


Canonical link: https://commits.webkit.org/231123@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-11-02 21:43:04 +00:00
..
mac
resources
13000-expected.txt
13000.html
31684-expected.txt
31684.html
acid3-surround-contents-expected.txt
acid3-surround-contents.html
bug-19527-expected.txt
bug-19527.html
clone-contents-document-type-expected.txt
clone-contents-document-type.html
compareBoundaryPoints-1-expected.txt
compareBoundaryPoints-1.html
compareBoundaryPoints-2-expected.txt Reviewed by Maciej Stachowiak. 2008-09-15 04:52:44 +00:00
compareBoundaryPoints-2.html
compareBoundaryPoints-compareHow-exception-expected.txt
compareBoundaryPoints-compareHow-exception.html
create-contextual-fragment-script-not-ran-expected.txt
create-contextual-fragment-script-not-ran.html
create-contextual-fragment-script-unmark-already-started-expected.txt
create-contextual-fragment-script-unmark-already-started.html
create-contextual-fragment.html
delete-contents-document-type-expected.txt
delete-contents-document-type.html
deleted-range-endpoints-expected.txt
deleted-range-endpoints.html
detach-range-during-deletecontents-expected.txt
detach-range-during-deletecontents.html
expand-word-with-apostrophe-expected.txt
expand-word-with-apostrophe.html
extract-contents-document-type-expected.txt
extract-contents-document-type.html
getBoundingClientRect-expected.txt [LFC][Integration] RenderText::absoluteQuadsForRange should use iterator 2020-11-02 21:43:04 +00:00
getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt
getBoundingClientRect-getClientRects-relative-to-viewport.html
getBoundingClientRect-getClientRects-return-type-expected.txt
getBoundingClientRect-getClientRects-return-type.html
getBoundingClientRect-on-collapsed-selection-range-expected.txt
getBoundingClientRect-on-collapsed-selection-range.html
getBoundingClientRect.html [LFC][Integration] RenderText::absoluteQuadsForRange should use iterator 2020-11-02 21:43:04 +00:00
getClientRects-expected.txt Fix up layout tests results following r254160 2020-01-08 00:08:42 +00:00
getClientRects-vertical-expected.txt
getClientRects-vertical.html
getClientRects.html Fix up layout tests results following r254160 2020-01-08 00:08:42 +00:00
insertNode-empty-fragment-crash-expected.txt
insertNode-empty-fragment-crash.html
mutation-expected.txt
mutation.html
range-clone-contents-expected.txt
range-clone-contents.html
range-clone-empty-expected.txt
range-clone-empty.html
range-compareNode-expected.txt
range-compareNode.html
range-comparePoint-detached-nodes-expected.txt
range-comparePoint-detached-nodes.html
range-comparePoint-expected.txt
range-comparePoint.html
range-constructor-expected.txt
range-constructor.html
range-created-during-remove-children-expected.txt
range-created-during-remove-children.html
range-created-in-mutation-event-crash-expected.txt
range-created-in-mutation-event-crash.xhtml
range-delete-contents-event-fire-crash-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
range-delete-contents-event-fire-crash.html
range-delete-contents-mutation-event-crash-expected.txt
range-delete-contents-mutation-event-crash.html
range-detach-noop-expected.txt
range-detach-noop.html
range-exceptions-expected.txt
range-exceptions.html
range-expand-expected.txt
range-expand.html
range-extract-contents-event-fire-crash-expected.txt
range-extract-contents-event-fire-crash.html
range-extract-contents-event-fire-crash2-expected.txt
range-extract-contents-event-fire-crash2.html
range-extract-contents-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
range-extract-contents.html
range-extractContents-expected.txt
range-extractContents.html
range-insertNode-assertion-expected.txt
range-insertNode-assertion.html
range-insertNode-same-container-expected.txt
range-insertNode-same-container.html
range-insertNode-separate-endContainer-expected.txt
range-insertNode-separate-endContainer.html
range-insertNode-splittext-expected.txt
range-insertNode-splittext.html
range-intersectsNode-expected.txt
range-intersectsNode.html
range-isPointInRange-expected.txt
range-isPointInRange.html
range-modifycontents-expected.txt
range-modifycontents.html
range-processing-instructions-expected.txt
range-processing-instructions.html
range-selection-across-documents-crash-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
range-selection-across-documents-crash.html
range-selection-empty-body-expected.txt
range-selection-empty-body.html
ranges-across-trees-expected.txt REGRESSION(r266295): Range allows start and end containers to belong to different trees 2020-10-21 16:39:37 +00:00
ranges-across-trees.html REGRESSION(r266295): Range allows start and end containers to belong to different trees 2020-10-21 16:39:37 +00:00
remove-all-children-crash-expected.txt
remove-all-children-crash.html
remove-twice-crash-expected.txt
remove-twice-crash.html
scale-page-bounding-client-rect-expected.txt
scale-page-bounding-client-rect.html Move node geometry functions from Range to RenderObject 2020-08-22 16:16:03 +00:00
scale-page-client-rects-expected.txt
scale-page-client-rects.html Move node geometry functions from Range to RenderObject 2020-08-22 16:16:03 +00:00
select-node-different-document-expected.txt
select-node-different-document.html
set-wrong-document-err-expected.txt
set-wrong-document-err.html
simple-line-layout-getclientrects-expected.html
simple-line-layout-getclientrects.html
split-text-in-range-expected.txt
split-text-in-range.html
surround-contents-font-face-crash-expected.txt Crash in WebCore::SVGElement::removedFromDocument 2012-02-14 23:54:40 +00:00
surround-contents-font-face-crash.svg
surroundContents-1-expected.txt
surroundContents-1.html
surroundContents-check-boundary-points-expected.txt
surroundContents-check-boundary-points.html
update-range-in-split-text-expected.txt
update-range-in-split-text.html