haikuwebkit/LayoutTests/fast/block
Alan Bujtas c631ccedff [RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer()
https://bugs.webkit.org/show_bug.cgi?id=227260
<rdar://77329323>

Reviewed by Antti Koivisto.

Source/WebCore:

This is a very similar to webkit.org/b/224996, where moving subtrees around fails to invalidate floating object sets in sibling blocks.
(see the Changelog entry for more details on how sibling invalidation works).
In this case the anonymous parent block is destroyed as it is no longer needed (and we move all its descendants out first). However this
block has an intruding float and this float is also registered in the sibling blocks.

Test: fast/block/float-assert-when-anon-parent-is-destroyed.html

* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::moveChildren):
(WebCore::RenderTreeBuilder::removeFloatingObjects):
* rendering/updating/RenderTreeBuilder.h:
* rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::removeLeftoverAnonymousBlock):

LayoutTests:

* fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt: Added.
* fast/block/float-assert-when-anon-parent-is-destroyed.html: Added.


Canonical link: https://commits.webkit.org/239051@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-06-22 20:26:10 +00:00
..
basic
float Nullptr crash in RenderStyle::shapeOutside() 2021-03-18 14:44:01 +00:00
inside-inlines Remove newBlockInsideInlineModel and anonymous inline block 2017-08-31 23:27:02 +00:00
line-layout Simple line layout: Nested block with pseudo first-line parent should bail out of simple line layout. 2015-12-31 19:27:58 +00:00
lineboxcontain Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box. 2013-05-01 20:37:04 +00:00
margin-collapse [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height. 2019-01-26 15:01:34 +00:00
positioning Remove unneeded whitespace between content and <br> 2020-10-25 19:52:34 +00:00
resources
abspos-child-container-changes-from-relative-to-static-expected.html Changing position:relative to position:static results in mis-positioned div 2012-11-25 18:35:10 +00:00
abspos-child-container-changes-from-relative-to-static.html
align-overflow-child-expected.txt <table> inside <div align="right"> with large content inside = no scrollbar 2016-09-06 17:20:58 +00:00
align-overflow-child.html <table> inside <div align="right"> with large content inside = no scrollbar 2016-09-06 17:20:58 +00:00
assert-when-layout-root-is-not-cleared-expected.txt Should never be reached failure in WebCore::RenderElement::clearLayoutRootIfNeeded 2015-12-27 22:56:57 +00:00
assert-when-layout-root-is-not-cleared.html Should never be reached failure in WebCore::RenderElement::clearLayoutRootIfNeeded 2015-12-27 22:56:57 +00:00
block-add-child-crash-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
block-add-child-crash.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
block-move-frequent-paint-expected.txt [Experiment] Implement code to detect high frequency painting 2017-11-08 16:11:55 +00:00
block-move-frequent-paint.html [Experiment] Implement code to detect high frequency painting 2017-11-08 16:11:55 +00:00
block-not-removed-from-parent-lineboxes-crash-expected.txt
block-not-removed-from-parent-lineboxes-crash.html
block-parent-with-zero-width-child-expected.txt
block-parent-with-zero-width-child.html Change fast/a* and fast/b* files to use pre and post js files in LayoutTests/resources. 2013-09-07 21:47:04 +00:00
block-remove-child-delete-line-box-crash-expected.txt
block-remove-child-delete-line-box-crash.html Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests 2012-06-19 06:35:17 +00:00
block-size-integer-overflow-expected.txt
block-size-integer-overflow.html Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests 2012-06-19 06:35:17 +00:00
block-with-inline-replaced-child-expected.html RenderBlock incorrectly calculates pref width when a replaced object follows a RenderInline with width 2012-10-01 18:16:14 +00:00
block-with-inline-replaced-child-following-text-expected.txt Regression r130057: Improper preferred width calculation when an inline replaced object, wrapped in an inline flow, follows some text. 2012-11-02 13:55:23 +00:00
block-with-inline-replaced-child-following-text.html Change fast/a* and fast/b* files to use pre and post js files in LayoutTests/resources. 2013-09-07 21:47:04 +00:00
block-with-inline-replaced-child.html RenderBlock incorrectly calculates pref width when a replaced object follows a RenderInline with width 2012-10-01 18:16:14 +00:00
block-with-inline-replaced-children-in-inline-flows-expected.html
block-with-inline-replaced-children-in-inline-flows.html Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced 2012-10-15 21:29:31 +00:00
body-inline-block-crash-expected.txt ASSERTION FAILED: !object || object->isBox(), Bad cast in RenderBox::computeLogicalHeight 2013-02-13 23:44:59 +00:00
body-inline-block-crash.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
border-fit-with-right-alignment-expected.html iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result 2014-09-09 23:31:41 +00:00
border-fit-with-right-alignment.html Source/WebCore: border-fit-adjust should happen at layout time rather than paint time 2013-03-07 18:41:16 +00:00
br-with-clearance-after-collapsing-space-expected.html In some float situations, the original layout is wrong and only corrects itself on repaint 2012-10-21 10:27:50 +00:00
br-with-clearance-after-collapsing-space.html In some float situations, the original layout is wrong and only corrects itself on repaint 2012-10-21 10:27:50 +00:00
child-not-removed-from-parent-lineboxes-crash-expected.txt 2011-06-23 Abhishek Arya <inferno@chromium.org> 2011-06-29 23:58:25 +00:00
child-not-removed-from-parent-lineboxes-crash.html Implement the HTML <main> element. 2013-01-21 17:10:34 +00:00
collapse-anon-block-with-float-siblings-only-expected.html Floating box is misplaced after content change. 2015-10-26 23:36:01 +00:00
collapse-anon-block-with-float-siblings-only.html Floating box is misplaced after content change. 2015-10-26 23:36:01 +00:00
colspan-under-button-crash-expected.txt Crash due to column span under button element 2012-11-07 04:55:23 +00:00
colspan-under-button-crash.html Crash due to column span under button element 2012-11-07 04:55:23 +00:00
containing-block-changes-expected.html Absolute positioned element is not placed properly when parent becomes the containing block. 2016-05-12 02:09:59 +00:00
containing-block-changes.html Absolute positioned element is not placed properly when parent becomes the containing block. 2016-05-12 02:09:59 +00:00
containing-block-for-out-of-flow-becomes-static-expected.html RenderTreeNeedsLayoutChecker asserts with imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-005.html 2020-03-13 03:47:55 +00:00
containing-block-for-out-of-flow-becomes-static.html RenderTreeNeedsLayoutChecker asserts with imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-005.html 2020-03-13 03:47:55 +00:00
continuation-crash-expected.txt Continuations casting issue. 2014-04-03 19:22:48 +00:00
continuation-crash.html Continuations casting issue. 2014-04-03 19:22:48 +00:00
crash-when-anonymous-blocks-are-merged-with-simple-line-layout-expected.txt Merged anonymous blocks should invalidate simple line layout path. 2015-05-19 17:49:40 +00:00
crash-when-anonymous-blocks-are-merged-with-simple-line-layout.html Merged anonymous blocks should invalidate simple line layout path. 2015-05-19 17:49:40 +00:00
crash-when-anonymous-float-box-is-removed-expected.txt Cleanup references to float and out-of-flow renderers before destroying them. 2021-03-11 15:32:36 +00:00
crash-when-anonymous-float-box-is-removed.html Cleanup references to float and out-of-flow renderers before destroying them. 2021-03-11 15:32:36 +00:00
crash-when-subtree-is-still-attached-expected.txt Folding anonymous blocks should not result in deleting content. 2018-04-05 21:14:31 +00:00
crash-when-subtree-is-still-attached.html [RenderTreeBuilder] REGRESSION(r228238) Detach renderer before destroying its subtree. 2018-02-18 18:44:34 +00:00
crash-while-folding-anonymous-blocks-expected.txt Folding anonymous blocks should not result in deleting content. 2018-04-05 21:14:31 +00:00
crash-while-folding-anonymous-blocks.html Folding anonymous blocks should not result in deleting content. 2018-04-05 21:14:31 +00:00
dynamic-padding-border-expected.txt Padding and border changes doesn't trigger relayout of children 2013-02-16 03:06:19 +00:00
dynamic-padding-border.html Padding and border changes doesn't trigger relayout of children 2013-02-16 03:06:19 +00:00
fail-to-remove-float-from-initial-containing-block-expected.txt Floating object are not removed from the initial containing block 2021-04-29 22:43:08 +00:00
fail-to-remove-float-from-initial-containing-block.html Floating object are not removed from the initial containing block 2021-04-29 22:43:08 +00:00
fixed-position-reparent-when-transition-is-removed-expected.txt Decouple the percent height and positioned descendants maps. 2016-06-16 03:30:22 +00:00
fixed-position-reparent-when-transition-is-removed.html Decouple the percent height and positioned descendants maps. 2016-06-16 03:30:22 +00:00
float-assert-when-anon-parent-is-destroyed-expected.txt [RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer() 2021-06-22 20:26:10 +00:00
float-assert-when-anon-parent-is-destroyed.html [RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer() 2021-06-22 20:26:10 +00:00
geometry-map-assertion-with-rounding-negative-half-expected.txt ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) 2016-02-03 07:01:28 +00:00
geometry-map-assertion-with-rounding-negative-half.html ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) 2016-02-03 07:01:28 +00:00
geometry-map-assertion-with-tall-content-expected.txt Assertion in RenderGeometryMap::mapToContainer with LayoutUnit overflow. 2015-01-07 01:22:09 +00:00
geometry-map-assertion-with-tall-content.html Assertion in RenderGeometryMap::mapToContainer with LayoutUnit overflow. 2015-01-07 01:22:09 +00:00
height-percentage-descendants-with-absolute-pos-containingblock-expected.txt Block layout invalidation logic triggers excessive layout on height percentage descendants 2019-11-18 21:30:07 +00:00
height-percentage-descendants-with-absolute-pos-containingblock.html Block layout invalidation logic triggers excessive layout on height percentage descendants 2019-11-18 21:30:07 +00:00
inline-children-root-linebox-crash-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
inline-children-root-linebox-crash.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
layer-not-removed-from-parent-crash-expected.txt Crash due to layer not removed from parent for anonymous block. 2012-08-03 05:53:38 +00:00
layer-not-removed-from-parent-crash.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
legacy-text-align-position-quirk-expected.html Add a quirk to not respect center text-align when positioning 2013-11-18 23:08:30 +00:00
legacy-text-align-position-quirk.html Add a quirk to not respect center text-align when positioning 2013-11-18 23:08:30 +00:00
margins-perpendicular-containing-block-expected.txt Make RenderBox::computeInlineDirectionMargins const 2012-08-30 17:32:57 +00:00
margins-perpendicular-containing-block.html check-layout.js should always dumpAsText 2012-10-10 23:42:35 +00:00
merge-anonymous-block-remove-child-crash-expected.txt 2011-01-05 Abhishek Arya <inferno@chromium.org> 2011-01-05 18:58:06 +00:00
merge-anonymous-block-remove-child-crash.html Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests 2012-06-19 06:35:17 +00:00
merge-anonymous-block-remove-child-crash2-expected.txt
merge-anonymous-block-remove-child-crash2.html Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests 2012-06-19 06:35:17 +00:00
min-content-box-sizing-expected.html REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken 2016-04-22 19:42:24 +00:00
min-content-box-sizing.html REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken 2016-04-22 19:42:24 +00:00
min-max-height-percent-height-child-expected.txt When a block's height is determined by min-height/max-height, children with percentage heights are sized incorrectly 2013-01-02 23:54:21 +00:00
min-max-height-percent-height-child.html When a block's height is determined by min-height/max-height, children with percentage heights are sized incorrectly 2013-01-02 23:54:21 +00:00
negative-margin-start-positive-margin-end-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
negative-margin-start-positive-margin-end.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
negative-start-margin-align-center-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
negative-start-margin-align-center-percent-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
negative-start-margin-align-center-percent.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
negative-start-margin-align-center.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
nested-renderers-expected.html Some content causes deep recursion. 2016-05-01 05:42:25 +00:00
nested-renderers.html Some content causes deep recursion. 2016-05-01 05:42:25 +00:00
over-constrained-auto-margin-expected.txt In regular block layout, the width of a child's margin box should always be equal to that of its containing block 2017-09-21 16:28:35 +00:00
over-constrained-auto-margin.html In regular block layout, the width of a child's margin box should always be equal to that of its containing block 2017-09-21 16:28:35 +00:00
percent-height-descendant-not-removed-crash-expected.txt
percent-height-descendant-not-removed-crash.html Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests 2012-06-19 06:35:17 +00:00
percent-height-descendant-not-removed-crash2-expected.txt Crash on accessing a removed renderer from percent height descendant map. 2012-06-20 21:20:29 +00:00
percent-height-descendant-not-removed-crash2.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
percent-top-parent-respects-min-height-expected.txt percentage top value of position:relative element not calculated using parent's min-height unless height set 2013-02-16 13:06:03 +00:00
percent-top-parent-respects-min-height.html percentage top value of position:relative element not calculated using parent's min-height unless height set 2013-02-16 13:06:03 +00:00
percent-top-respects-max-height-expected.txt Available height should respect min and max height 2013-01-12 12:59:55 +00:00
percent-top-respects-max-height.html Available height should respect min and max height 2013-01-12 12:59:55 +00:00
percent-top-respects-min-height-expected.txt
percent-top-respects-min-height.html Available height should respect min and max height 2013-01-12 12:59:55 +00:00
positioned-block-auto-width-movement-expected.html Absolute position div without width specified does not reflow its text when it is moved (and computed width changes) 2013-03-20 07:16:08 +00:00
positioned-block-auto-width-movement.html Absolute position div without width specified does not reflow its text when it is moved (and computed width changes) 2013-03-20 07:16:08 +00:00
positive-margin-block-child-align-center-calc-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-block-child-align-center-calc.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-block-child-align-center-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-block-child-align-center-rtl-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-block-child-align-center-rtl.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-block-child-align-center.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-start-align-center-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-start-align-center.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-start-negative-margin-end-align-center-expected.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
positive-margin-start-negative-margin-end-align-center.html Fix HTML executable bits 2013-08-19 16:14:32 +00:00
remove-anonymous-wrappers-when-element-changes-to-float-or-positioned-expected.txt Need to Remove Anonymous Wrappers When All Children Become Inline 2013-05-22 18:59:38 +00:00
remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html Need to Remove Anonymous Wrappers When All Children Become Inline 2013-05-22 18:59:38 +00:00
selection-block-gap-crash-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
selection-block-gap-crash.html REGRESSION (r167210): Invalid cast in WebCore::RenderBlock::blockSelectionGaps 2014-11-19 00:37:35 +00:00
selection-cache-is-incorrect-when-non-direct-parent-has-float-expected.txt Selection cache produces invalid result when ancestor has float element. 2015-06-17 21:06:58 +00:00
selection-cache-is-incorrect-when-non-direct-parent-has-float.html Selection cache produces invalid result when ancestor has float element. 2015-06-17 21:06:58 +00:00
selection-inside-simple-line-layout-expected.txt ASSERTION FAILED: !simpleLineLayout() in WebCore::RenderText::collectSelectionRectsForLineBoxes 2015-12-11 07:31:28 +00:00
selection-inside-simple-line-layout.html ASSERTION FAILED: !simpleLineLayout() in WebCore::RenderText::collectSelectionRectsForLineBoxes 2015-12-11 07:31:28 +00:00
shrink-to-fit-width-container-with-floating-children-expected.txt Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children 2013-06-19 17:20:46 +00:00
shrink-to-fit-width-container-with-floating-children.html Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children 2013-06-19 17:20:46 +00:00
sticky-position-containing-block-crash-expected.txt Heap-use-after-free in WebCore::RenderBlock::insertIntoTrackedRendererMaps 2013-01-05 21:23:07 +00:00
sticky-position-containing-block-crash.html Unprefix -webkit-sticky 2019-04-16 19:48:37 +00:00
update-midpoints-for-trailing-boxes-crash-expected.txt Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) 2020-09-27 02:15:19 +00:00
update-midpoints-for-trailing-boxes-crash.html Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests 2012-06-19 06:35:17 +00:00