2021-08-19 Megan Gardner Remove old unused code and out of date comments. https://bugs.webkit.org/show_bug.cgi?id=229210 Reviewed by Anders Carlsson. * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2021-08-19 Alex Christensen Remove more non-inclusive language from Source https://bugs.webkit.org/show_bug.cgi?id=229230 Reviewed by Myles C. Maxfield. * WebKit.order: * WebView/WebViewPrivate.h: 2021-08-19 Simon Fraser Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates https://bugs.webkit.org/show_bug.cgi?id=229243 Reviewed by Wenson Hsieh. The result of Element::clientRect() is in the coordinate space of the root view, not in the space of the Element's Frame, so does not match the other functions on Element with "client" in the name. Rename to Element::boundingBoxInRootViewCoordinates() for clarity. * WebCoreSupport/WebValidationMessageClient.mm: (WebValidationMessageClient::showValidationMessage): (WebValidationMessageClient::updateValidationBubbleStateIfNeeded): 2021-08-19 Simon Fraser Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously https://bugs.webkit.org/show_bug.cgi?id=229256 Reviewed by Geoffrey Garen. Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent() to scheduleScrollEvent() since the event dispatch happens via the next rendering update. * WebView/WebFrame.mm: (-[WebFrame sendScrollEvent]): 2021-08-16 David Kilzer "make analyze" should run clang static analyzer in deep mode Reviewed by Alexey Proskuryakov. * migrate-headers.sh: - Treat "analyze" the same as "build" for "ACTION" environment variable. 2021-08-16 David Kilzer -[WebView initWithCoder:] should use -[NSCoder decodeValueOfObjCType:at:size:] Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView initWithCoder:]): - Switch to -[NSCoder decodeValueOfObjCType:at:size:]. 2021-08-13 Chris Dumez Add Cross-Origin-Embedder-Policy support for Blob URLs https://bugs.webkit.org/show_bug.cgi?id=229041 Reviewed by Alex Christensen. * WebCoreSupport/WebPlatformStrategies.mm: 2021-08-12 Chris Dumez Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased https://bugs.webkit.org/show_bug.cgi?id=229056 Reviewed by Geoffrey Garen. Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong in r273194. * Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker forwardInvocation:]): 2021-08-12 Youenn Fablet REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing https://bugs.webkit.org/show_bug.cgi?id=228926 Reviewed by Eric Carlson. isFeatureFlagEnabled is called when creating/initializing WebPreferences. It used to check for WebView, which triggers the execution of WebView initialize method while DumpRenderTree is in the middle of creating its testing setup, including its storage testing sessions. Instead, check for WebResource to remove this side effect and get back to past DumpRenderTree initialization. * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): 2021-08-11 Peng Liu Function _os_feature_enabled_impl() expects compile-time static strings as arguments https://bugs.webkit.org/show_bug.cgi?id=229017 Reviewed by Tim Horton. There are multiple issues in the current implementation of `isFeatureFlagEnabled()`. 1. `_os_feature_enabled_impl()` expects compile-time static strings as arguments. So we should not use `String` here. 2. As Simon Fraser pointed out, `String::characters8()` is not null terminated. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): 2021-08-10 Peng Liu REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing https://bugs.webkit.org/show_bug.cgi?id=228926 Reviewed by Jer Noble. Revert a part of r280726 while investigating the test failures. * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): 2021-08-10 Chris Dumez Add Cross-Origin-Opener-Policy support for Blob URLs https://bugs.webkit.org/show_bug.cgi?id=228924 Reviewed by Alex Christensen. * WebCoreSupport/WebPlatformStrategies.mm: 2021-08-10 Chris Dumez Document.baseURI is inaccurate for iframe srcdoc documents https://bugs.webkit.org/show_bug.cgi?id=228933 Reviewed by Alex Christensen. * DOM/DOMHTMLBaseElement.mm: (-[DOMHTMLBaseElement href]): 2021-08-09 Chris Dumez Blob URL changes after loading it https://bugs.webkit.org/show_bug.cgi?id=228923 Reviewed by Geoff Garen. * WebCoreSupport/WebPlatformStrategies.mm: 2021-08-09 Myles C. Maxfield Support WTF logging channels https://bugs.webkit.org/show_bug.cgi?id=228768 Reviewed by Fujii Hironori. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2021-08-07 Myles C. Maxfield Deduplicate logging channel algorithms https://bugs.webkit.org/show_bug.cgi?id=228809 Reviewed by Fujii Hironori. * Misc/WebKitLogInitialization.h: Copied from Source/WebKit/Platform/LogInitialization.h. * Misc/WebKitLogInitialization.mm: Copied from Source/WebKitLegacy/mac/Misc/WebKitLogging.m. (WebKit::logChannels): (ReportDiscardedDelegateException): * Misc/WebKitLogging.h: * Misc/WebKitLogging.m: (ReportDiscardedDelegateException): Deleted. * WebCoreSupport/WebDragClient.mm: * WebView/WebDelegateImplementationCaching.mm: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2021-08-07 Commit Queue Unreviewed, reverting r280756. https://bugs.webkit.org/show_bug.cgi?id=228897 Broke gtk build Reverted changeset: "Deduplicate logging channel algorithms" https://bugs.webkit.org/show_bug.cgi?id=228809 https://commits.webkit.org/r280756 2021-08-07 Myles C. Maxfield Deduplicate logging channel algorithms https://bugs.webkit.org/show_bug.cgi?id=228809 Reviewed by Fujii Hironori. * Misc/WebKitLogInitialization.h: Copied from Source/WebKit/Platform/LogInitialization.h. * Misc/WebKitLogInitialization.mm: Copied from Source/WebKitLegacy/mac/Misc/WebKitLogging.m. (WebKit::logChannels): (ReportDiscardedDelegateException): * Misc/WebKitLogging.h: * Misc/WebKitLogging.m: (ReportDiscardedDelegateException): Deleted. * WebCoreSupport/WebDragClient.mm: * WebView/WebDelegateImplementationCaching.mm: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2021-08-06 Peng Liu [macOS] Clean up Feature Flags related code https://bugs.webkit.org/show_bug.cgi?id=228803 Reviewed by Tim Horton. On macOS, Safari Technology Preview or a local build WebKit/Safari will always get the default preference values through the "Feature Flags" SPI. Unfortunately, this approach won't work if the OS does not provide correct default preference values. With this patch, we only get default preference values with the SPI for system WebKit on macOS. For all other cases, we use hardcoded values. So that WebKit will always get the correct default preference values. This patch also fixes a few mistakes in two preferences: "webm_webaudio" and "vp8_decoder". * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): (WebKit::defaultIncrementalPDFEnabled): (WebKit::defaultWebXREnabled): (WebKit::defaultWebMParserEnabled): (WebKit::defaultWebMWebAudioEnabled): (WebKit::defaultVP8DecoderEnabled): (WebKit::defaultVP9DecoderEnabled): 2021-08-05 Cameron McCormack Stop tracking form elements with FormController https://bugs.webkit.org/show_bug.cgi?id=228724 Reviewed by Darin Adler. formElementsCharacterCount is unused and can be removed. * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2021-07-29 Myles C. Maxfield Stop building WebGPU and the WHLSL compiler to decrease binary size https://bugs.webkit.org/show_bug.cgi?id=228179 Reviewed by Dean Jackson, Robin Morisset, and Devin Rousso. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences webGPUEnabled]): Deleted. (-[WebPreferences setWebGPUEnabled:]): Deleted. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultWebGPUEnabled): Deleted. * WebView/WebPreferencesPrivate.h: 2021-07-26 Wenson Hsieh [macOS Monterey] Pressing Fn+E should present the emoji picker when editing https://bugs.webkit.org/show_bug.cgi?id=228300 rdar://77558672 Reviewed by Tim Horton. Apply a similar fix, this time for WebKit1 on macOS. * WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]): Only append "insertText:" for a corresponding NSEvent with the Function key held down if it doesn't also map to a item in the main menu. 2021-07-16 Megan Gardner Pipe App Highlight scrolling through UI Process in preparation for Note Overlay avoidance. https://bugs.webkit.org/show_bug.cgi?id=227914 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollMainFrameToRevealRect const): 2021-07-15 Jean-Yves Avenard [Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy) https://bugs.webkit.org/show_bug.cgi?id=228005 rdar://80346720 Reviewed by Jer Noble. * WebView/WebPreferencesDefaultValues.h: Add relevant settings getter methods. * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultWebMParserEnabled): (WebKit::defaultVP8DecoderEnabled): (WebKit::defaultVP9DecoderEnabled): 2021-07-15 Chris Dumez Add initial support for BroadcastChannel behind a runtime flag https://bugs.webkit.org/show_bug.cgi?id=227924 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _preferencesChanged:]): 2021-07-15 Megan Gardner Rename scrollRectIntoView to scrollContainingScrollViewsToRevealRect for clarity. https://bugs.webkit.org/show_bug.cgi?id=227995 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollContainingScrollViewsToRevealRect const): (WebChromeClient::scrollRectIntoView const): Deleted. 2021-07-14 Rob Buis Rename hasOverflowClip() to prepare for the real overflow:clip https://bugs.webkit.org/show_bug.cgi?id=227899 Reviewed by Simon Fraser. Rename hasOverflowClip() to prepare for the real overflow:clip. * DOM/DOMHTML.mm: (-[DOMHTMLElement scrollXOffset]): (-[DOMHTMLElement scrollYOffset]): (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]): 2021-06-25 Commit Queue Unreviewed, reverting r279266. https://bugs.webkit.org/show_bug.cgi?id=227402 Causes crash loop Reverted changeset: "Remove references to order files" https://bugs.webkit.org/show_bug.cgi?id=227377 https://trac.webkit.org/changeset/279266 2021-06-24 Sihui Liu Remove references to order files https://bugs.webkit.org/show_bug.cgi?id=227377 rdar://76070556 Reviewed by Mark Lam. * Configurations/WebKitLegacy.xcconfig: 2021-06-22 Wenson Hsieh [Live Text] [macOS] Add an internal option to disable inline text selection in images https://bugs.webkit.org/show_bug.cgi?id=227265 rdar://79460142 Reviewed by Tim Horton. Rename ContextMenuItemTagLookUpImage to ContextMenuItemTagQuickLookImage. * WebView/WebHTMLView.mm: (toTag): 2021-06-21 Wenson Hsieh [macOS] [WebKitLegacy] Non-actionable "Look Up" action appears when right clicking images https://bugs.webkit.org/show_bug.cgi?id=227240 Reviewed by Devin Rousso. Override the new client hook and return false in legacy WebKit. * WebCoreSupport/WebContextMenuClient.h: 2021-06-17 Alex Christensen Remove empty header WebTypesInternal.h https://bugs.webkit.org/show_bug.cgi?id=227094 Reviewed by Fujii Hironori. * DefaultDelegates/WebDefaultUIDelegate.mm: * History/WebBackForwardList.mm: * History/WebHistory.mm: * History/WebHistoryItem.mm: * Misc/WebDownload.mm: * Misc/WebElementDictionary.mm: * Misc/WebNSDataExtras.h: * Misc/WebTypesInternal.h: Removed. * Plugins/WebBasePluginPackage.mm: * Plugins/WebNetscapePluginPackage.mm: * WebView/WebArchive.mm: * WebView/WebDelegateImplementationCaching.h: * WebView/WebHTMLRepresentation.mm: * WebView/WebHTMLView.mm: * WebView/WebPDFDocumentExtras.mm: * WebView/WebPDFRepresentation.mm: * WebView/WebTextCompletionController.mm: * WebView/WebTextIterator.mm: * WebView/WebViewData.h: * WebView/WebViewInternal.h: 2021-06-16 Chris Dumez Document's execCommand() / queryCommand*() should throw an exception on non-HTML/XHTML documents https://bugs.webkit.org/show_bug.cgi?id=227016 Reviewed by Darin Adler. Update ObjC bindings since the WebCore API now returns ExceptionOr<> types. * DOM/DOMDocument.mm: (-[DOMDocument execCommand:userInterface:value:]): (-[DOMDocument queryCommandEnabled:]): (-[DOMDocument queryCommandIndeterm:]): (-[DOMDocument queryCommandState:]): (-[DOMDocument queryCommandSupported:]): (-[DOMDocument queryCommandValue:]): 2021-06-11 Megan Gardner Rename AppHighlight group to QuickNote to correctly reflect feature. https://bugs.webkit.org/show_bug.cgi?id=226888 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: (toTag): * WebView/WebUIDelegatePrivate.h: 2021-06-10 Alex Christensen Re-enable legacy WebView plug-ins (but not NPAPI) https://bugs.webkit.org/show_bug.cgi?id=226890 Reviewed by Tim Horton. In r276720 I put the check in the wrong place. This should also fix rdar://77179042 again, which I broke, fixed, broke, and am now fixing again. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): 2021-06-08 Devin Rousso [Payment Request] upstream new features https://bugs.webkit.org/show_bug.cgi?id=226740 Reviewed by Andy Estes. - recurring line items (`HAVE_PASSKIT_RECURRING_SUMMARY_ITEM` and `ENABLE_APPLE_PAY_RECURRING_LINE_ITEM`) - deferred line items (`HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM` and `ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM`) - estimated shipping dates (`HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE` and `ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE`) - coupon code entry (`HAVE_PASSKIT_COUPON_CODE` and `ENABLE_APPLE_PAY_COUPON_CODE`) - shipped vs in-store pickup (`HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE` and `ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE`) * WebCoreSupport/WebPaymentCoordinatorClient.h: * WebCoreSupport/WebPaymentCoordinatorClient.mm: (WebPaymentCoordinatorClient::completeCouponCodeChange): Renamed from `WebPaymentCoordinatorClient::completePaymentMethodModeChange`. 2021-06-07 Wenson Hsieh Upstream WebKit support for Live Text https://bugs.webkit.org/show_bug.cgi?id=226706 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: Replace IMAGE_EXTRACTION with IMAGE_ANALYSIS. 2021-06-06 Wenson Hsieh Turn TextIteratorBehaviorFlag into an enum class and wrap it in OptionSet https://bugs.webkit.org/show_bug.cgi?id=226691 Reviewed by Darin Adler. See WebCore/ChangeLog for more information. * WebView/WebFrame.mm: (-[WebFrame _stringForRange:]): 2021-06-05 Wenson Hsieh [macOS] Move DataDetectors softlinking in DataDetectorsSPI.h out into a separate PAL header https://bugs.webkit.org/show_bug.cgi?id=226669 Reviewed by Sam Weinig. Adopt the new PAL softlinking header in a few places. See WebCore/ChangeLog for more details. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _clearImmediateActionState]): (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): 2021-06-04 Chris Dumez Use Vector instead of Vector to store bytes in SharedBuffer https://bugs.webkit.org/show_bug.cgi?id=226623 Reviewed by Darin Adler. Use Vector instead of Vector to store bytes in SharedBuffer. Also have SharedBuffer::data() return a `const uint8_t*` instead of `const char*`. This is our preferred type to store bytes. * Plugins/Hosted/HostedNetscapePluginStream.h: * Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveData): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginView:receivedData:]): * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveData): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): 2021-06-01 Darin Adler Remove https://bugs.webkit.org/show_bug.cgi?id=226437 Reviewed by Chris Dumez. * DOM/DOMRangeInternal.h: Added import of . * WebView/WebGeolocationPosition.mm: Removed import of . * WebView/WebGeolocationPositionInternal.h: Added import of . 2021-06-01 Antti Koivisto Rename InlineBox to LegacyInlineBox https://bugs.webkit.org/show_bug.cgi?id=226501 Reviewed by Alan Bujtas. * DOM/DOMUIKitExtensions.mm: 2021-05-30 Darin Adler Remove WTF::Optional synonym for std::optional, using that class template directly instead https://bugs.webkit.org/show_bug.cgi?id=226433 Reviewed by Chris Dumez. * : Let the do-webcore-rename script rename Optional<> to std::optional<>. 2021-05-27 Darin Adler Next step toward using std::optional directly instead of through WTF::Optional typedef https://bugs.webkit.org/show_bug.cgi?id=226280 Reviewed by Chris Dumez. * : Accept the renaming done by do-webcore-rename. 2021-05-25 Tim Horton Virtualize GraphicsContext https://bugs.webkit.org/show_bug.cgi?id=226170 Reviewed by Simon Fraser. * Misc/WebCoreStatistics.mm: (-[WebFrame printToCGContext:pageWidth:pageHeight:]): * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:]): * WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView drawRect:]): * WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): 2021-05-24 Sam Weinig Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.) https://bugs.webkit.org/show_bug.cgi?id=226143 Reviewed by Darin Adler. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Update for new DestinationColorSpace class. 2021-05-24 Darin Adler Remove StringBuilder::appendLiteral https://bugs.webkit.org/show_bug.cgi?id=226137 Reviewed by Chris Dumez. * WebView/WebHTMLRepresentation.mm: (regExpForLabels): Use append instead of appendLiteral. Also imrpove local variable names a bit. 2021-05-24 Commit Queue Unreviewed, reverting r277940. https://bugs.webkit.org/show_bug.cgi?id=226182 Caused Safari crash under IPC::typeFromCFTypeRef Reverted changeset: "Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.)" https://bugs.webkit.org/show_bug.cgi?id=226143 https://trac.webkit.org/changeset/277940 2021-05-24 Chris Dumez Drop CheckedLock / CheckedCondition aliases https://bugs.webkit.org/show_bug.cgi?id=226176 Reviewed by Kate Cheney. Drop CheckedLock / CheckedCondition aliases now that they are the default. * DOM/DOMInternal.mm: 2021-05-23 Sam Weinig Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.) https://bugs.webkit.org/show_bug.cgi?id=226143 Reviewed by Darin Adler. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Update for new DestinationColorSpace class. 2021-05-22 Chris Dumez Replace LockHolder with Locker in local variables https://bugs.webkit.org/show_bug.cgi?id=226133 Reviewed by Darin Adler. Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker. * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): 2021-05-22 Commit Queue Unreviewed, reverting r277913. https://bugs.webkit.org/show_bug.cgi?id=226140 Caused multiple layout-test crash on mac debug queues Reverted changeset: "Replace LockHolder with Locker in local variables" https://bugs.webkit.org/show_bug.cgi?id=226133 https://trac.webkit.org/changeset/277913 2021-05-21 Chris Dumez Replace LockHolder with Locker in local variables https://bugs.webkit.org/show_bug.cgi?id=226133 Reviewed by Darin Adler. Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker. * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): 2021-05-21 Wenson Hsieh [macOS] Adopt QLItem in WKImageExtractionPreviewController https://bugs.webkit.org/show_bug.cgi?id=226114 rdar://76657718 Reviewed by Tim Horton. Adopt the new QuickLookUI softlinking header in PAL. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webViewClosed]): 2021-05-21 Chris Dumez Replace more static Locks with CheckedLocks in WebKit / WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=226093 Reviewed by Darin Adler. Replace more static Locks with CheckedLocks so that we can benefit from Clang Thread Safety Analysis. * DOM/DOMInternal.mm: (getDOMWrapper): (addDOMWrapper): (removeDOMWrapper): 2021-05-20 Alexey Shvayka [WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes https://bugs.webkit.org/show_bug.cgi?id=223758 Reviewed by Sam Weinig. Use inherits instead of toJSDOMWindow() if the value is never a JSProxy. * WebView/WebView.mm: (+[WebView _reportException:inContext:]): 2021-05-19 Sam Weinig Update Base64 encoding/decoding to match more modern WebKit conventions https://bugs.webkit.org/show_bug.cgi?id=225920 Reviewed by Chris Dumez. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::wrapCryptoKey const): (WebChromeClient::unwrapCryptoKey const): Update to use new Optional returning defaultWebCryptoMasterKey(). * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::save): Update to use new Optional returning base64Decode(). 2021-05-17 Peng Liu [GPUP] WebContent process should not pull audio session category from the GPU Process https://bugs.webkit.org/show_bug.cgi?id=225826 Reviewed by Darin Adler. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setAudioSessionCategoryOverride:]): 2021-05-15 Ryosuke Niwa Delete WebSQL code from WebKit2 https://bugs.webkit.org/show_bug.cgi?id=225739 Reviewed by Sihui Liu. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2021-05-13 Megan Gardner Add textIndicator bounce for AppHighlights on scroll. https://bugs.webkit.org/show_bug.cgi?id=225727 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setTextIndicator const): * WebView/WebHTMLView.mm: (-[WebHTMLView quickLookWithEvent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webView:didHandleScrollWheel:]): (-[WebImmediateActionController _cancelImmediateAction]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController menuItemDidClose:]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _setTextIndicator:]): (-[WebView _setTextIndicator:withLifetime:]): (-[WebView _clearTextIndicatorWithAnimation:]): (-[WebView _showDictionaryLookupPopup:]): (-[WebView _dictionaryLookupPopoverWillClose:]): * WebView/WebViewInternal.h: 2021-05-12 Chris Dumez Notification.requestPermission() should return a Promise https://bugs.webkit.org/show_bug.cgi?id=225712 Reviewed by Darin Adler. Update code now that WebCore passes a CompletionHandler instead of a NotificationPermissionCallback. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::requestPermission): (-[WebNotificationPolicyListener initWithCompletionHandler:]): (-[WebNotificationPolicyListener allow]): (-[WebNotificationPolicyListener deny]): 2021-05-12 Chris Dumez Queue notification permission requests for the same origin on WebKit side https://bugs.webkit.org/show_bug.cgi?id=225701 Reviewed by Geoffrey Garen. Remove some dead code. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: 2021-05-10 Wenson Hsieh Make WebCore::HitTestRequest::RequestType an enum class https://bugs.webkit.org/show_bug.cgi?id=225597 Reviewed by Sam Weinig. See WebCore/ChangeLog for more details. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary const): * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController performHitTestAtPoint:]): 2021-05-08 Darin Adler [Cocoa] Remove the one use of String::toInt from WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=225568 Reviewed by Sam Weinig. * DOM/DOMHTMLInputElement.mm: (-[DOMHTMLInputElement setSize:]): Use -[NSString intValue] instead of WTF::String::toInt. Both functions ignore leading spaces, and both ignore trailing junk, so there is no significant change in behavior. 2021-05-07 Wenson Hsieh [macOS] Set the -isSourceEditable property when presenting webpage translation popup https://bugs.webkit.org/show_bug.cgi?id=225515 Reviewed by Tim Horton. See WebCore/ChangeLog for more details. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::handleTranslation): * WebView/WebView.mm: (-[WebView _handleContextMenuTranslation:]): (-[WebView _handleContextMenuTranslation:selectionBounds:menuLocation:]): Deleted. * WebView/WebViewInternal.h: 2021-05-04 Alex Christensen Remove unused references to PageGroup from WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=225359 Reviewed by Sihui Liu. * History/WebHistory.mm: * History/WebHistoryInternal.h: * Storage/WebStorageManager.mm: * WebView/WebView.mm: 2021-05-03 Devin Rousso [macCatalyst] "Enter Full Screen" button in media controls disappears https://bugs.webkit.org/show_bug.cgi?id=225210 Reviewed by Eric Carlson. In order for the "Enter Full Screen" media controls button to stay visible the `