nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
240,929 Commits
4 Branches
0 Tags
7.2 GiB
haiku
review-overcommit
review-scrollbar
haiku_newservicekit
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'haiku'
${ noResults }
Commit Graph

1447 Commits (haiku)

Author SHA1 Message Date
Darin Adler a05cc484c6 * languages.md: Fixed "Movaje" typo. 
Canonical link: https://commits.webkit.org/228387@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 3 years ago
Darin Adler 1b73f81808 Document versions of C++ and Python 
https://bugs.webkit.org/show_bug.cgi?id=215191

Reviewed by Jonathan Bedard.

* languages.md: Added.

Canonical link: https://commits.webkit.org/228377@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 3 years ago
Jonathan Davis 5a52fcdb55 Remove unused selector performance test 
https://bugs.webkit.org/show_bug.cgi?id=215414

Reviewed by Darin Adler.

* perf/slickspeed/config.ini: Removed.
* perf/slickspeed/footer.html: Removed.
* perf/slickspeed/frameworks/DomQuery.js: Removed.
* perf/slickspeed/frameworks/dummy.js: Removed.
* perf/slickspeed/frameworks/jquery-1.2.3.js: Removed.
* perf/slickspeed/frameworks/prototype.js: Removed.
* perf/slickspeed/header.html: Removed.
* perf/slickspeed/index.php: Removed.
* perf/slickspeed/instructions.txt: Removed.
* perf/slickspeed/logo.png: Removed.
* perf/slickspeed/selectors.list: Removed.
* perf/slickspeed/style.css: Removed.
* perf/slickspeed/system/index.php: Removed.
* perf/slickspeed/system/slickspeed.js: Removed.
* perf/slickspeed/system/template.php: Removed.
* perf/slickspeed/template.html: Removed.


Canonical link: https://commits.webkit.org/228198@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 3 years ago
Jonathan Davis 90b1b53386 Fixed widget method argument compatibility with WordPress 
https://bugs.webkit.org/show_bug.cgi?id=215103

Reviewed by Devin Rousso.

* wp-content/themes/webkit/widgets/icon.php:
* wp-content/themes/webkit/widgets/page.php:
* wp-content/themes/webkit/widgets/post.php:
* wp-content/themes/webkit/widgets/twitter.php:


Canonical link: https://commits.webkit.org/228012@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 3 years ago
Jonathan Davis 71a83957e9 Removed XML declaration from SVGs and updated copyrights 
https://bugs.webkit.org/show_bug.cgi?id=215102

Reviewed by Devin Rousso.

* wp-content/themes/webkit/images/chevron-dark.svg:
* wp-content/themes/webkit/images/chevron.svg:
* wp-content/themes/webkit/images/circular.svg:
* wp-content/themes/webkit/images/compass.svg:
* wp-content/themes/webkit/images/download-white.svg:
* wp-content/themes/webkit/images/download.svg:
* wp-content/themes/webkit/images/filter.svg:
* wp-content/themes/webkit/images/icons.svg:
* wp-content/themes/webkit/images/inspector.svg:
* wp-content/themes/webkit/images/invert-lightness.svg:
* wp-content/themes/webkit/images/menu-down.svg:
* wp-content/themes/webkit/images/search.svg:
* wp-content/themes/webkit/images/spinner.svg:
* wp-content/themes/webkit/images/squirrelfish-lives.svg:
* wp-content/themes/webkit/images/template.svg:
* wp-content/themes/webkit/images/twitter.svg:
* wp-content/themes/webkit/images/webkit.svg:


Canonical link: https://commits.webkit.org/228011@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 3 years ago
Jonathan Davis 90d7771a68 Enhance feature status page origin for flexible test environments 
https://bugs.webkit.org/show_bug.cgi?id=215178

Reviewed by Devin Rousso.

* wp-content/themes/webkit/css-status.php:
* wp-content/themes/webkit/status.php:


Canonical link: https://commits.webkit.org/227981@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 3 years ago
Ling Ho 4bef209665 Show patch IDs in the drop down menu under the Patch Diff Screen 
https://bugs.webkit.org/show_bug.cgi?id=212558

Patch by Ling Ho <lingho@apple.com> on 2020-06-01
Reviewed by Alexey Proskuryakov.

* template/en/default/attachment/diff-header.html.tmpl:

Canonical link: https://commits.webkit.org/225448@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 928a612dcf Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/clobberize-dependence-graph.graffle:
* blog-files/speculation-in-jsc/clobberize-dependence-graph.svg:



Canonical link: https://commits.webkit.org/223802@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 25bb4faaca Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/clobberize-dependence-graph.graffle:
* blog-files/speculation-in-jsc/clobberize-dependence-graph.svg:



Canonical link: https://commits.webkit.org/223710@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 0a5884fc8b Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/clobberize-dependence-graph.graffle: Added.
* blog-files/speculation-in-jsc/clobberize-dependence-graph.svg: Added.



Canonical link: https://commits.webkit.org/223708@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo d79251ab68 Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/abstract-heaps.graffle:
* blog-files/speculation-in-jsc/abstract-heaps.svg:



Canonical link: https://commits.webkit.org/223706@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 7303904646 Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/abstract-heaps.graffle:
* blog-files/speculation-in-jsc/abstract-heaps.svg:



Canonical link: https://commits.webkit.org/223705@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo b5e7945976 Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/abstract-heaps.graffle: Added.
* blog-files/speculation-in-jsc/abstract-heaps.svg: Added.



Canonical link: https://commits.webkit.org/223704@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 8d3b886827 Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/osr-exit-implicit-control-flow.graffle:
* blog-files/speculation-in-jsc/osr-exit-implicit-control-flow.svg:



Canonical link: https://commits.webkit.org/223585@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 338357d29f Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/osr-exit-implicit-control-flow.graffle: Added.
* blog-files/speculation-in-jsc/osr-exit-implicit-control-flow.svg: Added.



Canonical link: https://commits.webkit.org/223581@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 24b55b706d Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/full-add-cfg.graffle:
* blog-files/speculation-in-jsc/full-add-cfg.svg:



Canonical link: https://commits.webkit.org/223403@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 204a043fa9 Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/full-add-cfg.graffle:
* blog-files/speculation-in-jsc/full-add-cfg.svg:



Canonical link: https://commits.webkit.org/223401@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 1b4376908e Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/full-add-cfg.graffle: Added.
* blog-files/speculation-in-jsc/full-add-cfg.svg: Added.



Canonical link: https://commits.webkit.org/223399@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo bb5f3b575f Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/dfg-pipeline-dark.graffle: Added.
* blog-files/speculation-in-jsc/dfg-pipeline-dark.svg: Added.
* blog-files/speculation-in-jsc/ftl-pipeline-dark.graffle
* blog-files/speculation-in-jsc/ftl-pipeline-dark.svg:



Canonical link: https://commits.webkit.org/223397@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo 8536b2c6b0 Unreviewed, check in some more files for a blog post. 
* blog-files/speculation-in-jsc/ftl-pipeline-dark.graffle: Added.
* blog-files/speculation-in-jsc/ftl-pipeline-dark.svg: Added.



Canonical link: https://commits.webkit.org/223388@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Filip Pizlo ea9d138c7c Unreviewed, check in some files for a blog post. 
* blog-files/speculation-in-jsc: Added.
* blog-files/speculation-in-jsc/ai-check-elimination-examples.graffle: Added.
* blog-files/speculation-in-jsc/ai-check-elimination-examples.svg: Added.
* blog-files/speculation-in-jsc/bigger-data-flow-graph.graffle: Added.
* blog-files/speculation-in-jsc/bigger-data-flow-graph.svg: Added.
* blog-files/speculation-in-jsc/bytecode-to-dfg-ir-lowering-with-osr-phases.graffle: Added.
* blog-files/speculation-in-jsc/bytecode-to-dfg-ir-lowering-with-osr-phases.svg: Added.
* blog-files/speculation-in-jsc/bytecode-to-ssa-conversion-with-osr.graffle: Added.
* blog-files/speculation-in-jsc/bytecode-to-ssa-conversion-with-osr.svg: Added.
* blog-files/speculation-in-jsc/dfg-and-ftl-architecture.graffle: Added.
* blog-files/speculation-in-jsc/dfg-and-ftl-architecture.svg: Added.
* blog-files/speculation-in-jsc/dfg-arithadd-explainer.graffle: Added.
* blog-files/speculation-in-jsc/dfg-arithadd-explainer.svg: Added.
* blog-files/speculation-in-jsc/dfg-pipeline.graffle: Added.
* blog-files/speculation-in-jsc/dfg-pipeline.svg: Added.
* blog-files/speculation-in-jsc/dfg-threaded-cps-example.graffle: Added.
* blog-files/speculation-in-jsc/dfg-threaded-cps-example.svg: Added.
* blog-files/speculation-in-jsc/double-monomorphic-inline-cache-speculation.graffle: Added.
* blog-files/speculation-in-jsc/double-monomorphic-inline-cache-speculation.svg: Added.
* blog-files/speculation-in-jsc/example-data-flow-graph.graffle: Added.
* blog-files/speculation-in-jsc/example-data-flow-graph.svg: Added.
* blog-files/speculation-in-jsc/five-parts-of-speculation.graffle: Added.
* blog-files/speculation-in-jsc/five-parts-of-speculation.svg: Added.
* blog-files/speculation-in-jsc/ftl-dfg-ir-to-bytecode-osr-exit.graffle: Added.
* blog-files/speculation-in-jsc/ftl-dfg-ir-to-bytecode-osr-exit.svg: Added.
* blog-files/speculation-in-jsc/ftl-pipeline.graffle: Added.
* blog-files/speculation-in-jsc/ftl-pipeline.svg: Added.
* blog-files/speculation-in-jsc/ftl-stackmaps.graffle: Added.
* blog-files/speculation-in-jsc/ftl-stackmaps.svg: Added.
* blog-files/speculation-in-jsc/ideal-jsc-optimization-workflow.graffle: Added.
* blog-files/speculation-in-jsc/ideal-jsc-optimization-workflow.svg: Added.
* blog-files/speculation-in-jsc/inline-caches-per-tier-dynamic.graffle: Added.
* blog-files/speculation-in-jsc/inline-caches-per-tier-dynamic.svg: Added.
* blog-files/speculation-in-jsc/int32-add-diamond-speculation.graffle: Added.
* blog-files/speculation-in-jsc/int32-add-diamond-speculation.svg: Added.
* blog-files/speculation-in-jsc/int32-add-osr-speculation.graffle: Added.
* blog-files/speculation-in-jsc/int32-add-osr-speculation.svg: Added.
* blog-files/speculation-in-jsc/jsc-tier-architecture.graffle: Added.
* blog-files/speculation-in-jsc/jsc-tier-architecture.svg: Added.
* blog-files/speculation-in-jsc/jsc-tiers.graffle: Added.
* blog-files/speculation-in-jsc/jsc-tiers.svg: Added.
* blog-files/speculation-in-jsc/object-model.graffle: Added.
* blog-files/speculation-in-jsc/object-model.svg: Added.
* blog-files/speculation-in-jsc/optimization-workflow-c-vs-js.graffle: Added.
* blog-files/speculation-in-jsc/optimization-workflow-c-vs-js.svg: Added.
* blog-files/speculation-in-jsc/optimization-workflow-js.graffle: Added.
* blog-files/speculation-in-jsc/optimization-workflow-js.svg: Added.
* blog-files/speculation-in-jsc/osr-exit-bytecode-example.graffle: Added.
* blog-files/speculation-in-jsc/osr-exit-bytecode-example.svg: Added.
* blog-files/speculation-in-jsc/osr-stack-register-shuffle.graffle: Added.
* blog-files/speculation-in-jsc/osr-stack-register-shuffle.svg: Added.
* blog-files/speculation-in-jsc/polyvariant-inline-cache-speculation.graffle: Added.
* blog-files/speculation-in-jsc/polyvariant-inline-cache-speculation.svg: Added.
* blog-files/speculation-in-jsc/prediction-propagation-and-value-profiling.graffle: Added.
* blog-files/speculation-in-jsc/prediction-propagation-and-value-profiling.svg: Added.
* blog-files/speculation-in-jsc/prediction-propagation-rules-add.graffle: Added.
* blog-files/speculation-in-jsc/prediction-propagation-rules-add.svg: Added.
* blog-files/speculation-in-jsc/prediction-propagation-rules-getbyval.graffle: Added.
* blog-files/speculation-in-jsc/prediction-propagation-rules-getbyval.svg: Added.
* blog-files/speculation-in-jsc/sample-property-lookup.graffle: Added.
* blog-files/speculation-in-jsc/sample-property-lookup.svg: Added.
* blog-files/speculation-in-jsc/single-monomorphic-inline-cache-speculation.graffle: Added.
* blog-files/speculation-in-jsc/single-monomorphic-inline-cache-speculation.svg: Added.
* blog-files/speculation-in-jsc/speculated-types.graffle: Added.
* blog-files/speculation-in-jsc/speculated-types.svg: Added.
* blog-files/speculation-in-jsc/xy-objects-as-maps.graffle: Added.
* blog-files/speculation-in-jsc/xy-objects-as-maps.svg: Added.
* blog-files/speculation-in-jsc/xy-objects-with-structures.graffle: Added.
* blog-files/speculation-in-jsc/xy-objects-with-structures.svg: Added.



Canonical link: https://commits.webkit.org/223266@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 480a264270 Removed the update nag from the old WebKit Nightly start page 
https://bugs.webkit.org/show_bug.cgi?id=179214

Reviewed by Darin Adler.

* wp-content/themes/webkit/nightly-start.php:


Canonical link: https://commits.webkit.org/222801@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Simon Fraser 8bd933c532 http://webkit.org/css-status/ hangs 
https://bugs.webkit.org/show_bug.cgi?id=209746

Reviewed by Antoine Quint.

A change to CSSProperties.json (probably text-orientation unprefixing) revealed an infinite loop
in mergeProperties() which kept appending values to prefixedPropertyObj.values.

Fix by cloning the array before enumerating it.

* wp-content/themes/webkit/css-status.php:


Canonical link: https://commits.webkit.org/222668@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Aakash Jain 579e78981f Remove status-bubble iframe from old EWS 
https://bugs.webkit.org/show_bug.cgi?id=209215

Reviewed by Jonathan Bedard.

* code-review.js:
* js/status-bubble.js:
(handleStatusBubbleLoadNewEWS): Deleted.
* template/en/default/attachment/edit.html.tmpl: Removed old EWS iframe.
* template/en/default/attachment/list.html.tmpl: Ditto.
* template/en/default/attachment/reviewform.html.tmpl: Ditto.


Canonical link: https://commits.webkit.org/222149@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Zhifei Fang 7b347d7d2e Test-freshness page table heaer misplaced 
Some platform name is too long
https://bugs.webkit.org/show_bug.cgi?id=208617

Reviewed by Ryosuke Niwa.

* public/v3/pages/test-freshness-page.js:
(TestFreshnessPage.cssTemplate):


Canonical link: https://commits.webkit.org/221527@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 41b47c13a5 Prevented text selection on logo and header navigation 
https://bugs.webkit.org/show_bug.cgi?id=208157

Reviewed by Devin Rousso.

* wp-content/themes/webkit/style.css:
(.site-logo):
(header nav):


Canonical link: https://commits.webkit.org/221215@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis c41cf9a498 Add support for table of contents to Web Inspector pages 
https://bugs.webkit.org/show_bug.cgi?id=206845

Reviewed by Devin Rousso.

* wp-content/plugins/table-of-contents.php:


Canonical link: https://commits.webkit.org/219851@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 760970e745 Fix submenu behavior for narrow viewports 
https://bugs.webkit.org/show_bug.cgi?id=206835

Reviewed by Devin Rousso.

* wp-content/themes/webkit/header.php:
* wp-content/themes/webkit/style.css:
(@media only screen and (max-width: 920px) header .menu > .menu-item:hover > .sub-menu,):
(@media only screen and (max-width: 920px) header .menu > .menu-item > .menu-toggle:checked ~ .sub-menu): Deleted.


Canonical link: https://commits.webkit.org/219847@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 6422784674 Fix editing permissions for the Web Inspector Editor role 
https://bugs.webkit.org/show_bug.cgi?id=206761

Reviewed by Devin Rousso.

* wp-content/plugins/web-inspector-pages.php:


Canonical link: https://commits.webkit.org/219758@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 48bd87953b Fix extra space between title and article body 
https://bugs.webkit.org/show_bug.cgi?id=206689

Reviewed by Devin Rousso.

* wp-content/themes/webkit/style.css:
(article .meta):
(article .bodycopy,):


Canonical link: https://commits.webkit.org/219708@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 6b788f4022 Ensure full URLs for relative path images for social meta data 
https://bugs.webkit.org/show_bug.cgi?id=206382

Reviewed by Devin Rousso.

* wp-content/plugins/social-meta.php:


Canonical link: https://commits.webkit.org/219477@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 744fdea076 Add support for categories and custom post types to the social meta plugin 
https://bugs.webkit.org/show_bug.cgi?id=206327

Reviewed by Devin Rousso.

* wp-content/plugins/social-meta.php:
* wp-content/plugins/web-inspector-pages.php:
* wp-content/themes/webkit/archive-web_inspector_page.php:


Canonical link: https://commits.webkit.org/219456@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 0fd9e0e03d Add Web Inspector Reference notice to Web Inspector blog posts 
https://bugs.webkit.org/show_bug.cgi?id=206308

Reviewed by Devin Rousso.

* wp-content/themes/webkit/functions.php:


Canonical link: https://commits.webkit.org/219401@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Devin Rousso 4e86dfceb5 Web Inspector Reference: the meta info at the end of the article should always be on its own line 
https://bugs.webkit.org/show_bug.cgi?id=206277

Reviewed by Timothy Hatcher.

* wp-content/themes/webkit/style.css:
(article .bodycopy, article .meta):


Canonical link: https://commits.webkit.org/219388@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Devin Rousso 3b93932c1d Web Inspector Reference: put the original author and last modified author on separate lines 
https://bugs.webkit.org/show_bug.cgi?id=206274

Reviewed by Timothy Hatcher.

* wp-content/themes/webkit/single-web_inspector_page.php:
* wp-content/themes/webkit/style.css:
(article .meta .written): Added.
(article .meta .written, article .meta .updated): Added.
(article .meta .updated): Deleted.


Canonical link: https://commits.webkit.org/219387@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis affcecac70 Ensure UAs update the stylesheet 
https://bugs.webkit.org/show_bug.cgi?id=206292

Reviewed by Devin Rousso.

* wp-content/themes/webkit/header.php:


Canonical link: https://commits.webkit.org/219384@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 90a6e4c0a6 Display authors of a Web Inspector reference article 
https://bugs.webkit.org/show_bug.cgi?id=206176

Reviewed by Devin Rousso.

* wp-content/themes/webkit/single-web_inspector_page.php:


Canonical link: https://commits.webkit.org/219353@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 4994f11dc5 Add Markdown support for Web Inspector Reference articles 
https://bugs.webkit.org/show_bug.cgi?id=206256

Reviewed by Devin Rousso.

* wp-content/plugins/web-inspector-pages.php:


Canonical link: https://commits.webkit.org/219351@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis f882302b6a Fix blog post article title justification 
https://bugs.webkit.org/show_bug.cgi?id=206245

Reviewed by Devin Rousso.

* wp-content/themes/webkit/style.css:
(main h1):


Canonical link: https://commits.webkit.org/219341@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 0f54d8463c Add support for Web Inspector pages and topic taxonomy 
https://bugs.webkit.org/show_bug.cgi?id=206034

Reviewed by Devin Rousso.

* wp-content/plugins/web-inspector-pages.php: Added.
* wp-content/themes/webkit/archive-web_inspector_page.php: Added.
* wp-content/themes/webkit/single-web_inspector_page.php: Added.


Canonical link: https://commits.webkit.org/219303@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 42f5329984 Add styles to support Web Inspector reference articles 
https://bugs.webkit.org/show_bug.cgi?id=206032

Reviewed by Devin Rousso.

* wp-content/themes/webkit/style.css:
(main h1,):
(main h1):
(article .meta .updated):
(article .bodycopy,):
(.image):
(p .image,):
(.image.block):
(.image img):
(.widescreen .image):
(.image.slice-top > picture > img):
(.image.slice-right > picture > img):
(.image.slice-bottom > picture > img):
(.image.slice-left > picture > img):
(.flex):
(.flex.center):
(figure.widescreen):
(article picture):
(article picture > img):
(.single-web_inspector_page .landing-link):
(.single-web_inspector_page .landing-link:hover):
(@media(prefers-color-scheme:dark) article .invert-brightness,):
(@media(prefers-color-scheme:dark) .table-of-contents label:after):
(article h1,): Deleted.
(article .bodycopy): Deleted.


Canonical link: https://commits.webkit.org/219154@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis e3ad053988 Fix redundant anchor tags when generating table of contents 
https://bugs.webkit.org/show_bug.cgi?id=206016

Reviewed by Devin Rousso.

* wp-content/plugins/table-of-contents.php:


Canonical link: https://commits.webkit.org/219146@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Zhifei Fang e3096f8a46 Add power metric to perf dashboard 
https://bugs.webkit.org/show_bug.cgi?id=205227

Reviewed by Ryosuke Niwa.

* public/v3/models/metric.js:
(Metric):


Canonical link: https://commits.webkit.org/218458@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 6d578dff43 Custom analysis task page should allow schedule any triggerable accepted tests. 
https://bugs.webkit.org/show_bug.cgi?id=204925

Reviewed by Ryosuke Niwa.

Fix a bug that subtest will not show on custom analysis task page if both itself and parent test are
accepted by triggerable.
Order test list in alphabetical order.

* public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests):

Canonical link: https://commits.webkit.org/218169@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Myles C. Maxfield 52a8612b35 [WebGPU] Update Babylon WebGPU demos to work on ToT 
https://bugs.webkit.org/show_bug.cgi?id=204182

Reviewed by Dean Jackson.

3 things were wrong:

- There seemed to be a bug in the loader script. I fixed the bug and added a local copy
  here so we don't have to keep hotlinking to the Babylon one.
- I had updated the helmet shaders in
  f7768ed430
  but I didn't update the sphere shaders.
- r252423 turned off the sphere rendering after 2 seconds. This patch removes that.

* demos/webgpu/babylon/babylonjs.loaders.min.js: Added.
(return):
(return.n.d):
(return.get n.r):
(return.n.t):
(return.):
(return.n.n):
(return.n.o):
* demos/webgpu/babylon/oneHelmetWebGPU.html:
* demos/webgpu/babylon/oneSphereWebGPU.html:
* demos/webgpu/babylon/oneSphereWebGPUWSLShaders.js:
(sampler.reflectionSamplerSampler.register):
(float3.normal.attribute): Deleted.
* demos/webgpu/babylon/vertexShaderGLSL1.glsl: Removed. Unnecessary.


Canonical link: https://commits.webkit.org/217485@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dean Jackson 77ce9e5ada Fix some WebGPU demos 
https://bugs.webkit.org/show_bug.cgi?id=204167
Source/WebCore:

<rdar://problem/57160316>

Reviewed by Myles C. Maxfield.

Add a note referencing a bug I detected while fixing this demo.
And a drive-by typo.

* Modules/webgpu/WebGPUBuffer.cpp:
(WebCore::WebGPUBuffer::rejectOrRegisterPromiseCallback):
* platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:
(WebCore::GPUCommandBuffer::copyBufferToTexture):

Websites/webkit.org:

Reviewed by Myles C. Maxfield.

Use COPY_ rather than TRANSFER_.

* demos/webgpu/babylon/babylonWebGpu.max.js:
* demos/webgpu/babylon/oneSphereWebGPU.html:
* demos/webgpu/hello-cube.html:
* demos/webgpu/scripts/compute-boids-compile.js:
* demos/webgpu/scripts/compute-boids-utils.js:
(async.createTextureFromImage):
* demos/webgpu/textured-cube.html:

Canonical link: https://commits.webkit.org/217466@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Ryosuke Niwa f620a3849d Add punctuation rules for C++ lambdas 
https://bugs.webkit.org/show_bug.cgi?id=204021

Reviewed by Zalan Bujtas.

Added rules for not putting spaces between [] and () and omitting () whenever possible for C++ lambdas.

* code-style.md:


Canonical link: https://commits.webkit.org/217440@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
James Savage 76f3a108f9 Support CSS Dark Mode for PrettyDiff.rb. 
https://bugs.webkit.org/show_bug.cgi?id=203874.

Patch by James Savage <james.savage@apple.com> on 2019-11-06
Reviewed by Tim Horton.

* PrettyPatch/PrettyPatch.rb: Modify CSS to support dark mode. I used
CSS variables in places where colors were shared, but otherwise provided
alternate style rules individually. Some colors looked fine in both
appearances, and those I left with only their light definition.

Canonical link: https://commits.webkit.org/217273@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 6da537599e Fix a bug that cannot unhide a platform. 
https://bugs.webkit.org/show_bug.cgi?id=203521

Reviewed by Ryosuke Niwa.

Before this change, the there is no value in POST when 'hidden' checkbox is unchecked.
Then the update will fail because platform_hidden cannot be NULL.

* public/admin/platforms.php: Adapted 'update_boolean_field'.
* public/admin/triggerables.php: Adapted 'update_boolean_field'.
* public/include/admin-header.php: Added 'update_boolean_field' helper function to set explict
boolean value for update.

Canonical link: https://commits.webkit.org/216901@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Chris Lord 332ab144f9 Put OffscreenCanvas behind a build flag 
https://bugs.webkit.org/show_bug.cgi?id=203146

Patch by Chris Lord <clord@igalia.com> on 2019-10-26
Reviewed by Ryosuke Niwa.

.:

Put OffscreenCanvas behind a build flag and enable building with
experimental features on GTK and WPE.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:

LayoutTests/imported/w3c:

OffscreenCanvas is disabled by default, adjust expectations accordingly.

* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
* web-platform-tests/html/dom/idlharness.https-expected.txt:
* web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt:

PerformanceTests:

* StitchMarker/wtf/FeatureDefines.h:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. No behavior changes.

* Configurations/FeatureDefines.xcconfig:
* bindings/js/JSEventTargetCustom.cpp:
* bindings/js/JSOffscreenCanvasRenderingContext2DCustom.cpp:
* dom/EventTargetFactory.in:
* html/ImageBitmap.idl:
* html/OffscreenCanvas.cpp:
* html/OffscreenCanvas.h:
* html/OffscreenCanvas.idl:
* html/canvas/CanvasRenderingContext.cpp:
* html/canvas/ImageBitmapRenderingContext.idl:
* html/canvas/OffscreenCanvasRenderingContext2D.cpp:
* html/canvas/OffscreenCanvasRenderingContext2D.h:
* html/canvas/OffscreenCanvasRenderingContext2D.idl:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::canvas):
* html/canvas/WebGLRenderingContextBase.h:
* html/canvas/WebGLRenderingContextBase.idl:
* inspector/agents/InspectorCanvasAgent.cpp:
* page/PageConsoleClient.cpp:
(WebCore::canvasRenderingContext):
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setImageBitmapEnabled):
(WebCore::RuntimeEnabledFeatures::imageBitmapEnabled const):
(WebCore::RuntimeEnabledFeatures::setOffscreenCanvasEnabled):
(WebCore::RuntimeEnabledFeatures::offscreenCanvasEnabled const):
* page/WindowOrWorkerGlobalScope.idl:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Split the ImageBitmapOffscreenCanvas setting into two separate
settings so OffscreenCanvas can be disabled at build time.

* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::WebInspectorUI):

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

Put OffscreenCanvas behind a build flag and enable the runtime setting
when running tests on platforms where it's built (GTK and WPE).

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setOffscreenCanvasEnabled):
* WebKitTestRunner/InjectedBundle/TestRunner.h:

Websites/webkit.org:

Update to reflect split ImageBitmapOffscreenCanvas settings.

* experimental-features.html:

LayoutTests:

OffscreenCanvas is disabled by default except on GTK/WPE. Adjust test
expectations accordingly.

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt.
* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt.
* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt.
* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt.
* platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt.
* platform/gtk/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
* platform/wpe/TestExpectations:
* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt.
* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt.
* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt: Renamed from LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt.
* platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt.
* platform/wpe/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt.

Canonical link: https://commits.webkit.org/216857@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 32af431d81 Add SSL support for peformance dashboard database connection. 
https://bugs.webkit.org/show_bug.cgi?id=203426

Reviewed by Ryosuke Niwa.

Performance dashboard should allow connecting Postgres database with SSL.

* public/include/db.php: Add SSL configuration to connection string if specified.
* tools/js/database.js: Add SSL configuration to connection string if specified.
(Database.prototype._prepareSSLConfig):
(Database.prototype.connect):
* unit-tests/checkconfig.js: Added unit tests for optional ssl fields.

Canonical link: https://commits.webkit.org/216834@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 977e2c2e6e Refactor "builds" table "build_number" row to "build_tag" to fit more generic use cases. 
https://bugs.webkit.org/show_bug.cgi?id=203270

Reviewed by Ryosuke Niwa.

Rename "build_number" to "build_tag" to fit more generic use cases.
Add support to be backward compatible to accept reports contain either
"buildNumber" or "buildTag".

* browser-tests/index.html:
* init-database.sql:
* migrate-database.sql: Updated migration sql for this change.
* public/admin/test-configurations.php:
* public/api/measurement-set.php:
* public/api/runs.php:
* public/api/upload-root.php: Added support for both "buildNumber" and "buildTag".
* public/include/report-processor.php: Added support for both "buildNumber" and "buildTag".
* public/v3/models/builder.js:
(Builder.prototype.urlForBuild):
(Builder):
(Build):
(Build.prototype.buildTag):
(Build.prototype.label):
(Build.prototype.url):
(Build.prototype.buildNumber): Deleted.
* public/v3/models/measurement-adaptor.js:
(MeasurementAdaptor):
(MeasurementAdaptor.prototype.applyTo.return.build):
* public/v3/pages/chart-pane-status-view.js:
* public/v3/pages/test-freshness-page.js:
(TestFreshnessPage.prototype._renderTooltip):
* server-tests/admin-platforms-tests.js:
(reportsForDifferentPlatforms):
* server-tests/admin-reprocess-report-tests.js:
* server-tests/api-commits-tests.js:
* server-tests/api-manifest-tests.js:
* server-tests/api-measurement-set-tests.js:
* server-tests/api-report-tests.js: Added unit tests for testing "buildNumber" and "buildTag".
(emptyReport):
(reportWitMismatchingCommitTime):
(reportWithOneSecondCommitTimeDifference):
(emptySlaveReport):
(makeReport):
(reportWithSameSubtestName):
* server-tests/api-upload-root-tests.js: Added unit tests for testing "buildNumber" and "buildTag".
* server-tests/privileged-api-add-build-requests-tests.js:
* server-tests/privileged-api-create-analysis-task-tests.js:
* server-tests/privileged-api-create-test-group-tests.js:
(createAnalysisTask):
* server-tests/privileged-api-upate-run-status.js:
* server-tests/privileged-api-update-test-group-tests.js:
(async.createAnalysisTask):
* server-tests/resources/mock-data.js:
(MockData.addMockConfiguration):
(MockData.sampleBuildData):
(MockData.finishedBuildData):
* server-tests/tools-sync-buildbot-integration-tests.js:
* tools/js/buildbot-syncer.js:
(BuildbotBuildEntry.prototype.initialize):
(BuildbotBuildEntry.prototype.buildTag):
(BuildbotBuildEntry.prototype.url):
(BuildbotSyncer.prototype.urlForBuildTag):
(BuildbotBuildEntry.prototype.buildNumber): Deleted.
(BuildbotSyncer.prototype.urlForBuildNumber): Deleted.
* unit-tests/analysis-task-tests.js:
(measurementCluster):
* unit-tests/buildbot-syncer-tests.js:
* unit-tests/measurement-adaptor-tests.js:
* unit-tests/measurement-set-analyzer-tests.js:
* unit-tests/measurement-set-tests.js:
* unit-tests/resources/mock-v3-models.js:

Canonical link: https://commits.webkit.org/216795@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Ling Ho ee5a411be1 Update WebKit Build Archives page on webkit.org 
https://bugs.webkit.org/show_bug.cgi?id=202871

Patch by Ling Ho <lingcherd_ho@apple.com> on 2019-10-14
Reviewed by Alexey Proskuryakov.

Added Catalina and remove Sierra.

* wp-content/themes/webkit/build-archives.php:

Canonical link: https://commits.webkit.org/216398@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu be57e94171 Improve test freshness page interaction experience. 
https://bugs.webkit.org/show_bug.cgi?id=202684

Reviewed by Ryosuke Niwa.

Change test freshness page show tooltip on click instead of popuping on mouse hover.
And clicking anywhere in 'page-with-heading' section except the tooltip can dismiss tooltip.
Add keyboard support to move focus around including 'Tab' key support.
Add support to use 'Enter' key to show or dismiss tooltip.
Add support to use 'Escape' key to dismiss tooltip.

* public/shared/common-component-base.js: Added support for link to specify 'tabindex'.
(CommonComponentBase.prototype.createLink):
(CommonComponentBase.createLink):
(CommonComponentBase):
* public/v3/components/base.js: Added support for customizing whether or not prevent default and stop propagation
while creating event handler.
(ComponentBase.prototype.createEventHandler):
(ComponentBase.createEventHandler):
(ComponentBase):
* public/v3/components/freshness-indicator.js:
(FreshnessIndicator): Removed 'url' property and removed customization for mouse event.
(FreshnessIndicator.prototype.update):
(FreshnessIndicator.prototype.didConstructShadowTree): Deleted.
* public/v3/pages/test-freshness-page.js:
(TestFreshnessPage): Changed to show tooltip on click and added key board event.
(TestFreshnessPage.prototype.didConstructShadowTree): Added key event support.
(TestFreshnessPage.prototype._findClosestIndicatorAnchorForCoordinate):
(TestFreshnessPage.prototype.render):
(TestFreshnessPage.prototype._renderTooltip):
(TestFreshnessPage.prototype._constructTableCell): Added tabIndex for each cell that contains freshness indicator.
(TestFreshnessPage.prototype._configureAnchorForIndicator):
(TestFreshnessPage.prototype._clearIndicatorState): Changed the color of links in tooltip to a more readable color.
Added styles when anchor for status cell and links on tooltip are focused.
(TestFreshnessPage.cssTemplate):

Canonical link: https://commits.webkit.org/216318@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Zhifei Fang 7841b6e3c4 [perf dashboard] Test fressness popover sometimes point to wrong place 
https://bugs.webkit.org/show_bug.cgi?id=202606

Reviewed by Ryosuke Niwa.

* public/v3/pages/test-freshness-page.js: Use a invisable tooltip anchor to cacluate tooltip position. It also helps to get rid of caculation for determine the tooltip table position.
(TestFreshnessPage.prototype._renderTooltip):
(TestFreshnessPage.cssTemplate):


Canonical link: https://commits.webkit.org/216089@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Zhifei Fang 2fc3d725fd [perf dashboard] Make test fressness head and indicator perfect centered 
https://bugs.webkit.org/show_bug.cgi?id=202602

Reviewed by Ryosuke Niwa.

* public/v3/components/freshness-indicator.js: make indicator margin auto, it will then horizontally centered in the container
(FreshnessIndicator.cssTemplate):
(FreshnessIndicator):
* public/v3/pages/test-freshness-page.js: make the table head transform based on the center left
(TestFreshnessPage.cssTemplate):


Canonical link: https://commits.webkit.org/216082@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu e12f1e4434 Fix a bug that warning icon causes infinite rendering when it has warning message. 
https://bugs.webkit.org/show_bug.cgi?id=202502

Reviewed by Ryosuke Niwa.

Fix the problem that a warning icon with a warning message will result in infinite rendering.

* public/v3/components/button-base.js:
(ButtonBase):
(ButtonBase.prototype.setButtonTitle): Fixed a typo in function name and moved the title update to
render function.
(ButtonBase.prototype.render): Added the logic to render title.
* public/v3/components/test-group-revision-table.js: Set warning message by invoking setButtonTitle.
* public/v3/components/warning-icon.js: Removed the warning messge related code and leave the responsibility
to ButtonBase.
(WarningIcon):
(WarningIcon.prototype.render):

Canonical link: https://commits.webkit.org/216007@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 6d111173e8 Provide build request status description information on dashboard. 
https://bugs.webkit.org/show_bug.cgi?id=199810

Reviewed by Ryosuke Niwa.

Add build request status description to show detailed information for a build and show it in dashboard.
Update SQL for existing instance:
    ALTER TABLE build_requests ADD COLUMN IF NOT EXISTS request_status_description varchar(1024) DEFAULT NULL;

* ReadMe.md: Updated instructions for initializing a database to include running 'migrate-database.sql'.
* init-database.sql: Added request_status_description column.
* migrate-database.sql: A file stores migration SQL for existing instance.
* public/api/build-requests.php: Added support for updating request_status_description.
* public/include/build-requests-fetcher.php: Exposed `statusDescription` to API.
* public/v3/components/test-group-revision-table.js: Added UI for showing build request status detail.
(TestGroupRevisionTable.prototype._renderTable):
(TestGroupRevisionTable.prototype._buildDescriptionCell):
(TestGroupRevisionTable.cssTemplate):
* public/v3/components/warning-icon.js: Extended warning icon to be able to customize information on hover.
(WarningIcon):
(WarningIcon.prototype.render):
* public/v3/components/button-base.js: Added a instance method to set button title.
(ButtonBase.prototype.setButtonTitle):
* public/v3/models/build-request.js: Added 'statusDescription' field.
(BuildRequest):
(BuildRequest.prototype.updateSingleton):
(BuildRequest.prototype.statusDescription):
* server-tests/api-build-requests-tests.js: Fixed unit tests.
* server-tests/resources/mock-data.js:
(MockData.set mockTestSyncConfigWithSingleBuilder): Added 'status_description' in buildbot mock data.
(MockData.sampleBuildData):
* server-tests/resources/test-server.js:
(TestServer.prototype.initDatabase): Added code to execute 'migrate-database.sql' on initialization.
* server-tests/tools-sync-buildbot-integration-tests.js: Added unit tests.
* tools/js/buildbot-syncer.js: Added 'statusDescription' field to 'BuildbotBuildEntry'.
(BuildbotBuildEntry.prototype.initialize):
(BuildbotBuildEntry.prototype.statusDescription):
* tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers):
* unit-tests/buildbot-syncer-tests.js: Added test code for BuildbotBuildEntry.statusDescription.

Canonical link: https://commits.webkit.org/215881@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Justin Fan 0a352ff658 [WebGPU] Update messaging to reflect STP 92 requirement for demos 
https://bugs.webkit.org/show_bug.cgi?id=201931

Reviewed by Jon Lee.

Demos don't work anymore on versions of Safari older than STP 92,
so update WebGPU feature detection to reflect that.

* demos/webgpu/babylon/babylonWebGpu.max.js:
* demos/webgpu/babylon/oneHelmetWebGPU.html:
* demos/webgpu/babylon/oneSphereWebGPU.html:
* demos/webgpu/compute-blur.html:
* demos/webgpu/compute-boids-compile.html:
* demos/webgpu/compute-boids.html:
* demos/webgpu/hello-cube.html:
* demos/webgpu/hello-triangle.html:
* demos/webgpu/scripts/compute-blur.js:
(async.init):
* demos/webgpu/scripts/compute-boids-compile.js:
* demos/webgpu/scripts/hello-triangle.js:
(async.helloTriangle):
* demos/webgpu/textured-cube.html:


Canonical link: https://commits.webkit.org/215616@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Myles C. Maxfield 1614398339 [WebGPU] Update demos to work on STP 92 
https://bugs.webkit.org/show_bug.cgi?id=201872

Reviewed by Dean Jackson.

Websites/browserbench.org:

GPUShaderStageBit => GPUShaderStage

* MotionMark1.1/tests/3d/resources/webgpu.js:
(Stage.call.initialize):

Websites/webkit.org:

Updating for new WSL buffer layouts.
Updating for new WSL compiler struct validation rules.
GPUShaderStageBit => GPUShaderStage
GPUColorWriteBits => GPUColorWrite
GPUBufferUsage.TRANSFER_DST => GPUBufferUsage.COPY_DST
GPUBufferUsage.TRANSFER_SRC => GPUBufferUsage.COPY_SRC

* demos/webgpu/babylon/babylonWebGpu.max.js:
* demos/webgpu/babylon/oneHelmetWebGPUWSLShaders.js:
(sampler.bumpSamplerSampler.register):
(sampler.reflectionSamplerSampler.register):
(float2.uv.attribute): Deleted.
(float3.normal.attribute): Deleted.
* demos/webgpu/compute-boids.html:
* demos/webgpu/hello-cube.html:
* demos/webgpu/scripts/compute-blur.js:
(setUpCompute):
(createShaderCode):
* demos/webgpu/scripts/compute-boids-compile.js:
* demos/webgpu/scripts/hello-triangle.js:
(async.helloTriangle):
* demos/webgpu/textured-cube.html:


Canonical link: https://commits.webkit.org/215557@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Justin Fan 540a7d0192 [WebGPU] Upload Babylon.js, WSL compile, and MotionMark links to demo page 
https://bugs.webkit.org/show_bug.cgi?id=201621

Reviewed by Dean Jackson.

Add new demos to the WebGPU demo collection.
Ensure error alerts/divs display properly if WebGPU is not enabled.

* demos/webgpu/babylon/oneHelmetWebGPU.html:
* demos/webgpu/babylon/oneSphereWebGPU.html:
* demos/webgpu/compute-blur.html:
* demos/webgpu/compute-boids-compile.html:
* demos/webgpu/compute-boids.html:
* demos/webgpu/hello-cube.html:
* demos/webgpu/hello-triangle.html:
* demos/webgpu/index.html:
* demos/webgpu/resources/babylon-helmet.png: Added.
* demos/webgpu/resources/babylon-sphere.png: Added.
* demos/webgpu/resources/motionmark.jpeg: Added.
* demos/webgpu/resources/webkit-logo.png: Added.
* demos/webgpu/scripts/compute-boids-compile.js:
* demos/webgpu/textured-cube.html:


Canonical link: https://commits.webkit.org/215271@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jon Lee 4b40613710 Add Babylon demos 
https://bugs.webkit.org/show_bug.cgi?id=201611

Rubber-stamped by Justin Fan.

* demos/webgpu/babylon/LICENSE: Added.
* demos/webgpu/babylon/babylonWebGpu.max.js: Added.
* demos/webgpu/babylon/logo.svg: Added.
* demos/webgpu/babylon/oneHelmetWebGPU.html: Added.
* demos/webgpu/babylon/oneHelmetWebGPUGLSLShaders.js: Added.
* demos/webgpu/babylon/oneHelmetWebGPUWSLShaders.js: Added.
* demos/webgpu/babylon/oneSphereWebGPU.html: Added.
* demos/webgpu/babylon/oneSphereWebGPUGLSLShaders.js: Added.
* demos/webgpu/babylon/oneSphereWebGPUWSLShaders.js: Added.
* demos/webgpu/babylon/vertexShaderGLSL1.glsl: Added.

Canonical link: https://commits.webkit.org/215255@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jon Lee b350ea5015 Add boids time test 
https://bugs.webkit.org/show_bug.cgi?id=201612

Rubber-stamped by Justin Fan.

* demos/webgpu/compute-boids-compile.html: Added.
* demos/webgpu/scripts/compute-boids-compile.js: Added.
* demos/webgpu/scripts/compute-boids-utils.js: Added.

Canonical link: https://commits.webkit.org/215254@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jon Lee e421bd1512 Upload triangles tests for 3D suite in MotionMark 
https://bugs.webkit.org/show_bug.cgi?id=201606

Reviewed by Simon Fraser.

PerformanceTests:

* MotionMark/resources/debug-runner/motionmark.css:
* MotionMark/resources/debug-runner/tests.js:
* MotionMark/tests/3d/resources/webgl.js:
* MotionMark/tests/3d/resources/webgpu.js: Added.
* MotionMark/tests/3d/triangles-webgl.html: Renamed from Websites/browserbench.org/MotionMark1.1/tests/3d/webgl.html.
* MotionMark/tests/3d/triangles-webgpu.html: Copied from PerformanceTests/MotionMark/tests/3d/webgl.html.

Websites/browserbench.org:

* MotionMark1.1/resources/debug-runner/tests.js:
* MotionMark1.1/tests/3d/resources/webgl.js:
* MotionMark1.1/tests/3d/resources/webgpu.js: Added.
* MotionMark1.1/tests/3d/triangles-webgl.html: Copied from PerformanceTests/MotionMark/tests/3d/webgl.html.
* MotionMark1.1/tests/3d/triangles-webgpu.html: Renamed from PerformanceTests/MotionMark/tests/3d/webgl.html.


Canonical link: https://commits.webkit.org/215249@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Aakash Jain df9a7a61dc EWS bubbles should indicate builder vs tester 
https://bugs.webkit.org/show_bug.cgi?id=201253

Reviewed by Jonathan Bedard.

Tools:

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Add icons to the bubbles appropriately.
(StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
(StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
(StatusBubble.get):
* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.fetch_config): Method to fetch the config from Buildbot server.
(Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
* BuildSlaveSupport/ews-app/ews/fetcher.py:
(FetchLoop.run): Update the icons for queues mapping.
* BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
* BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
* BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
(test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.

Websites/bugs.webkit.org:

* code-review.js: Do not display the icons in status-bubbles on this page.
* template/en/default/attachment/edit.html.tmpl: Ditto.
* template/en/default/attachment/reviewform.html.tmpl: Ditto.


Canonical link: https://commits.webkit.org/215097@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Justin Fan 18a88dd482 [WebGPU] Add compute-boids to WebGPU demo page 
https://bugs.webkit.org/show_bug.cgi?id=201416

Reviewed by Dean Jackson.

Add the compute-boids demo for use with STP 91.

* demos/webgpu/compute-boids.html: Added.
* demos/webgpu/index.html:
* demos/webgpu/resources/compute-boids.png: Added.


Canonical link: https://commits.webkit.org/215077@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Aakash Jain 9491bdd4c5 [EWS] Increase status-bubble iframe width on bugzilla comment review page 
https://bugs.webkit.org/show_bug.cgi?id=201304

Reviewed by Jonathan Bedard.

* template/en/default/attachment/reviewform.html.tmpl: Increased the width from 400 to 700 pixels.


Canonical link: https://commits.webkit.org/214970@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Justin Fan c985c6e0cf [WebGPU] Fix up demos on and add compute demo to webkit.org/demos 
https://bugs.webkit.org/show_bug.cgi?id=200454

Reviewed by Jon Lee.

Add the compute-blur demo.
Ensure that WebGPU demos will work on upcoming STP release.

* demos/webgpu/compute-blur.html: Added.
* demos/webgpu/css/style.css: Sync with internal demo repository stylesheet.
(body):
(canvas):
(body.error img):
(body.error input):
(#error p):
* demos/webgpu/hello-cube.html:
* demos/webgpu/hello-triangle.html:
* demos/webgpu/index.html:
* demos/webgpu/resources/compute-blur.png: Added.
* demos/webgpu/resources/hello-cube.png:
* demos/webgpu/resources/textured-cube.png: Added.
* demos/webgpu/scripts/compute-blur.js: Added.
(async.init):
(async.loadImage):
(setUpCompute):
(async.computeBlur):
(async.setUniforms):
(createShaderCode):
* demos/webgpu/scripts/hello-triangle.js:
(async.helloTriangle):
* demos/webgpu/textured-cube.html: Renmaed from Websites/webkit.org/demos/webgpu/hello-cube.html.


Canonical link: https://commits.webkit.org/214244@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu c17de2bb3d Dashboard should defaults to first dashboard page when summary page is not available. 
https://bugs.webkit.org/show_bug.cgi?id=200180

Reviewed by Ryosuke Niwa.

Fix a bug that charts page will become the default when there is no summary page but there
is at least one dashboard page.

* public/v3/main.js: Charts page and analysis category page should not be considered as summay pages.
(main):

Canonical link: https://commits.webkit.org/214127@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 63c23c2c41 Analysis task page should show build request author and creation time. 
https://bugs.webkit.org/show_bug.cgi?id=200274

Reviewed by Ryosuke Niwa.

Author and creation time of a build request should be visible in analysis task page.

* public/v3/pages/analysis-task-page.js: Added UI to show build request creation time and author.
(AnalysisTaskTestGroupPane.prototype._renderCurrentTestGroup):

Canonical link: https://commits.webkit.org/214092@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 9ad3dafa07 Should not render latest build information if there is no data points for a config. 
https://bugs.webkit.org/show_bug.cgi?id=200250

Reviewed by Ryosuke Niwa.

Fix a bug test freshness page that tooltip cannot be rendered when a cell does not have
a data point.

* public/v3/pages/test-freshness-page.js: Added a null check on commit set before rendering
latest build informaiton.
(TestFreshnessPage.prototype._renderTooltip):

Canonical link: https://commits.webkit.org/214055@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu e41b618186 Fix a bug that cannot update builder password on builders administrative page. 
https://bugs.webkit.org/show_bug.cgi?id=200154

Reviewed by Ryosuke Niwa.

'builders' administrative page should be able to update password for a builder.

* public/admin/builders.php: Should be able to update builder password.

Canonical link: https://commits.webkit.org/213982@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 9acf5e469c Use 12 digits to show a git commit. 
https://bugs.webkit.org/show_bug.cgi?id=200067

Reviewed by Ryosuke Niwa.

Use 12 digits to show a git commit to reasonably descrease commit prefix collision probability
for repository with large amount of commits.

* public/v3/models/commit-log.js: Increase digits from 8 to 12 for git SHA.
(CommitLog.prototype.label):
(CommitLog.prototype.diff):
* unit-tests/commit-log-tests.js: Updated unit tests.
* unit-tests/commit-set-tests.js: Updated unit tests.

Canonical link: https://commits.webkit.org/213907@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Aakash Jain 7f77399c3e [ews-app] EWS status-bubbles are sometimes multi-row with scroll-bar 
https://bugs.webkit.org/show_bug.cgi?id=199939

Reviewed by Jonathan Bedard.

* code-review.js: Disable scrolling.


Canonical link: https://commits.webkit.org/213812@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 89197f0056 Test freshness page should expose revision information for latest build on tooltip. 
https://bugs.webkit.org/show_bug.cgi?id=199483

Reviewed by Ryosuke Niwa.

Added latest build revision information on test freshness page tooltip.

* public/v3/pages/test-freshness-page.js: Add build revision information on tooltip.
(TestFreshnessPage.prototype.didConstructShadowTree):
(TestFreshnessPage.prototype._fetchTestResults):
(TestFreshnessPage.prototype.render):
(TestFreshnessPage.prototype._renderTooltip):
(TestFreshnessPage.cssTemplate):

Canonical link: https://commits.webkit.org/213431@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Jonathan Davis 95d1babd88 Added a domain check for validation URLs in Apple Pay demo. 
https://bugs.webkit.org/show_bug.cgi?id=199433

Patch by Jon Davis <jond@apple.com> on 2019-07-03
Reviewed by David Kilzer.

* demos/payment-request/merchant-validation.php:


Canonical link: https://commits.webkit.org/213388@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 4 years ago
Dewei Zhu 61eeb80b1e commit api should not return 'AmbiguousRevisionPrefix' if there is an exact revision match 
https://bugs.webkit.org/show_bug.cgi?id=199227

Reviewed by Ryosuke Niwa.

When prefix match is specified, api should check whether there is an exact match when multiple commits
match the prefix.

* public/include/commit-log-fetcher.php: Added the logic to check if there is an exact match when multiple matches are found.
* server-tests/api-commits-tests.js: Added an unit test.

Canonical link: https://commits.webkit.org/213193@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dean Johnson 5cfe1171fd [perf.webkit.org] Update summary page calculations to use mean instead of median 
https://bugs.webkit.org/show_bug.cgi?id=199050

Reviewed by Dewei Zhu.

* public/v3/pages/summary-page.js:
(SummaryPageConfigurationGroup): Updated 'median' references to 'mean'.
(SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Factored out logic for finding data
points in a timeSeries, within a specified timeRange.
(SummaryPageConfigurationGroup.set _meanForTimeRange): New. Returns the mean of a timeSeries across a
given timeRange.


Canonical link: https://commits.webkit.org/213128@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu 0667062f67 Fix a bug that 'test_metrics' and 'tests' tables are not joined correctly in CommitLogFetcher.fetch_latest_for_platform 
https://bugs.webkit.org/show_bug.cgi?id=199062

Reviewed by Ryosuke Niwa.

'test_metrics' and 'tests' should be joined based on 'metric_test' and 'test_id'.

* public/include/commit-log-fetcher.php: Fix the typo in the query.
* server-tests/api-commits-tests.js: Added a unit test for this change.

Canonical link: https://commits.webkit.org/213052@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu 41ef63c488 Customizable test group form should allow user to supply a revision prefix of a commit and revision starts with 'r'. 
https://bugs.webkit.org/show_bug.cgi?id=198940

Reviewed by Ryosuke Niwa.

Customizable test group form should adapt prefix matching when fetching for a commit.

* browser-tests/customizable-test-group-form-tests.js: Updated and added unit tests.
* public/v3/components/customizable-test-group-form.js: Removed loggings those a unintentionally committed.
* public/v3/models/commit-set.js: Adapted prefix matching API when fetching a commit.
(IntermediateCommitSet.prototype._fetchCommitLogAndOwnedCommits):
* unit-tests/commit-set-tests.js: Updated unit tests accordingly.

Canonical link: https://commits.webkit.org/212973@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu cd7f6e0966 Custom analysis task configurator should allow supplying commit prefix and revision starts 'r'. 
https://bugs.webkit.org/show_bug.cgi?id=198847

Reviewed by Ryosuke Niwa.

Custom analysis task configurator should not require full SHA to start an A/B test.
Custom analysis task configurator should accept svn revision starts with 'r'.

* browser-tests/custom-analysis-task-configurator-tests.js: Added a unit test for this change.
* public/api/commits.php: Extend this API to allow prefix matching when fethcing a single commit.
* public/include/commit-log-fetcher.php: Added a function to fetch a commit with prefix.
* public/v3/components/custom-analysis-task-configurator.js: Add UI support for accepting partial revision.
(CustomAnalysisTaskConfigurator.prototype._computeCommitSet):
(CustomAnalysisTaskConfigurator.prototype.async._resolveRevision):
(CustomAnalysisTaskConfigurator.prototype._buildTestabilityList):
* public/v3/models/commit-log.js:
(CommitLog.async.fetchForSingleRevision): Added third argument to specify prefix matching which defaults to false.
* server-tests/api-commits-tests.js: Added unit tests.
* unit-tests/commit-log-tests.js: Added a unit test.

Canonical link: https://commits.webkit.org/212914@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Ling Ho 26df66ba2f Add support of zxcvbn password strength checker to bugs.webkit.org website. 
https://bugs.webkit.org/show_bug.cgi?id=198391
rdar://problem/51278166

Patch by Ling Ho <lingcherd_ho@apple.com> on 2019-06-05
Reviewed by David Kilzer.

* Bugzilla/Config/Auth.pm:
(get_param_list):
* Bugzilla/Install/Requirements.pm:
(REQUIRED_MODULES):
* Bugzilla/User.pm:
(validate_password_check):
* template/en/default/admin/params/auth.html.tmpl:
* template/en/default/global/user-error.html.tmpl:

Canonical link: https://commits.webkit.org/212595@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jonathan Davis 15c3441c39 Fix icons positioned incorrectly when a featured image is used 
https://bugs.webkit.org/show_bug.cgi?id=198535

Reviewed by Devin Rousso.

* wp-content/themes/webkit/style.css:
(.tile .background-image.loaded svg):
(.tile .featured-image::before):


Canonical link: https://commits.webkit.org/212576@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jonathan Davis fbe4c1cabf Improve accessibility on webkit.org 
https://bugs.webkit.org/show_bug.cgi?id=198531

Reviewed by Devin Rousso.

* wp-content/themes/webkit/functions.php: Added menuitem ARIA role to links
* wp-content/themes/webkit/widgets/post.php: Added aria-label to SVG icons


Canonical link: https://commits.webkit.org/212569@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jonathan Davis f84e823393 Improve performance of the lazy image loader 
https://bugs.webkit.org/show_bug.cgi?id=198530

Reviewed by Devin Rousso.

* wp-content/themes/webkit/scripts/global.js:
(enableScrollableTables):
(lazyLoadImages):
(findParentMenu): Deleted.
(i.m.menus.m.targetMenu.targetMenuClass.indexOf): Deleted.
(inView): Deleted.
(): Deleted.
(loadImage.else.img.onload): Deleted.
(loadImage): Deleted.
(onMovement): Deleted.
(updateImages): Deleted.


Canonical link: https://commits.webkit.org/212553@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu 1acdf86d5a Perf dashboard erroneously rejects a build request to build owned components when there are no patches. 
https://bugs.webkit.org/show_bug.cgi?id=197928

Reviewed by Ryosuke Niwa.

Fix a bug that build type build request that only builds owned components failed to pass sanity check when there
is no repository accepts patch in triggerable repository group.
Add a sanity check to throw an error when build request type is build but there is no repository group template.

* tools/js/buildbot-syncer.js:
(BuildbotSyncer.prototype._propertiesForBuildRequest): Changed sanity check the always requires repository accepts patch when there is a build to make it also works for build request only builds owned components.
(BuildbotSyncer._parseRepositoryGroup): Added check for repository group templates not null  when build requiest type is build.
* unit-tests/buildbot-syncer-tests.js: Added unit tests for this change.
* unit-tests/resources/mock-v3-models.js: Added mock date for unit tests.

Canonical link: https://commits.webkit.org/212186@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu b495d62c5d Pruning old file logic should not stop after removing 10 files if there are more files to be removed. 
https://bugs.webkit.org/show_bug.cgi?id=197870

Reviewed by Ryosuke Niwa.

Pruning old file logic should keep removing removable files to make enough space for a new file upload.
It should only attempt to remve the files that have not been removed.

* public/include/uploaded-file-helpers.php: Modified 'prune_old_files' to allow to remove more than 10 files.
Fixed a bug that a removed file keep getting removed but never free up new space.
* server-tests/privileged-api-upload-file-tests.js:
(makeRandomAlnumStringForLength): Helper function to generate random content for a given length.
* server-tests/resources/test-server.js: Update total file size limit for this change.
(TestServer.prototype.testConfig):

Canonical link: https://commits.webkit.org/212153@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jer Noble 2be4b97208 Bugzilla should convert "r12345" to a trac.webkit.org link 
https://bugs.webkit.org/show_bug.cgi?id=197790

Reviewed by Alexey Proskuryakov.

* extensions/Trac/Config.pm: Added.
* extensions/Trac/Extension.pm: Added.
(bug_format_comment):
(_replace_revision):


Canonical link: https://commits.webkit.org/211986@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Justin Fan e49fd72225 [Web GPU] Add demos to webkit.org 
https://bugs.webkit.org/show_bug.cgi?id=196951

Reviewed by Dean Jackson.

Add simple triangle and spinning textured cube demos to the website.
Add Web GPU to experimental-features.html.

* demos/webgpu/css/style.css: Added.
(body):
(canvas):
(body.error canvas):
(h1):
(#container):
(select):
(div#log):
(body.error):
(body.error #contents):
(#error):
(@media (max-width: 480px)):
(body.error #error):
(#error h2):
(#error p):
* demos/webgpu/hello-cube.html: Added.
* demos/webgpu/hello-triangle.html: Added.
* demos/webgpu/index.html: Added.
* demos/webgpu/resources/circle.svg: Added.
* demos/webgpu/resources/hello-cube.png: Added.
* demos/webgpu/resources/hello-triangle.png: Added.
* demos/webgpu/resources/safari-alpha.png: Added.
* demos/webgpu/scripts/gl-matrix-min.js: Added.
(return.n):
(return.n.d):
(return.):
(return.get n.n):
(return.n.o):
* demos/webgpu/scripts/hello-triangle.js: Added.
(async.helloTriangle):
* experimental-features.html:


Canonical link: https://commits.webkit.org/211775@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jon Lee 0d3d34d616 [MotionMark] The text "kkkj" is causing Firefox console warning: `unreachable code after return statement` 
https://bugs.webkit.org/show_bug.cgi?id=196814

Reviewed by Wenson Hsieh.

* MotionMark/resources/extensions.js:
(subtract.subtract.sampleY):
Websites/browserbench.org:

* MotionMark1.1/resources/extensions.js:
(subtract.subtract.sampleY):


Canonical link: https://commits.webkit.org/211244@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Aakash Jain 0a96147a32 Add another status-bubble iframe to display results from new EWS 
https://bugs.webkit.org/show_bug.cgi?id=196308

Reviewed by Lucas Forschler.

* js/status-bubble.js:
(handleStatusBubbleMessage): Added URL for new EWS.
(handleStatusBubbleLoadNewEWS): Method to post message to new EWS.
* code-review.js: Added another iframe to display results from new EWS.
* template/en/default/attachment/edit.html.tmpl: Ditto.
* template/en/default/attachment/list.html.tmpl: Ditto.
* template/en/default/attachment/reviewform.html.tmpl: Ditto.


Canonical link: https://commits.webkit.org/210911@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jonathan Davis e6af65b038 Fix font family for WebKit.org 
https://bugs.webkit.org/show_bug.cgi?id=196311

Reviewed by Myles C. Maxfield.

* wp-content/themes/webkit/header.php: Added SF Mono loading
* wp-content/themes/webkit/style.css:
(html): Use Text font by default
(h1,): Use Display font for large headings
(.nextrouter-copy): Use Display font for routers


Canonical link: https://commits.webkit.org/210643@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Saam Barati 883d96ae5b JetStream 2 should not report time values as scores 
https://bugs.webkit.org/show_bug.cgi?id=196334

Reviewed by Yusuke Suzuki.

PerformanceTests:

* JetStream2/JetStreamDriver.js:
(toTimeValue):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

Websites/browserbench.org:

* JetStream2.0/JetStreamDriver.js:
(toTimeValue):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):


Canonical link: https://commits.webkit.org/210620@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Saam Barati fee095fce8 Unreviewed. Fix individual benchmark description urls to go to in-depth.html instead of about.html 
PerformanceTests:

* JetStream2/JetStreamDriver.js:
(Driver.prototype.prepareToRun.text.div.id.string_appeared_here.h3):

Websites/browserbench.org:

* JetStream2.0/JetStreamDriver.js:
(Driver.prototype.prepareToRun.text.div.id.string_appeared_here.h3):



Canonical link: https://commits.webkit.org/210593@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Jonathan Davis 958302e21c Update BrowserBench for JetStream2. 
https://bugs.webkit.org/show_bug.cgi?id=196273

Reviewed by Saam Barati.

* index.html:
* resources/JetStream2-Logo.png: Added.
* resources/JetStream2-Logo@2x.png: Added.
* resources/main.css:
(.benchmark:hover img): Improved hover effect for the JetStream2 logo.


Canonical link: https://commits.webkit.org/210581@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu 81d8c18892 Primary cluster of measurement set should always contain latest point. 
https://bugs.webkit.org/show_bug.cgi?id=196243

Reviewed by Ryosuke Niwa.

Fix a bug in measurement-set api that primary cluster may not contain latest data point as
'carry_over' row may not be updated.

* public/api/measurement-set.php: Should always keep 'carry_over' data points up to date.
* server-tests/api-measurement-set-tests.js: Added an unit test for this change.
Fixed a typo.

Canonical link: https://commits.webkit.org/210565@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Saam Barati 52dfe8eba3 Update browserbench.org/JetStream2.0 to the latest version. 
Rubber-stamped by Filip Pizlo.

* JetStream2.0: Replaced with ../../PerformanceTests/JetStream2.



Canonical link: https://commits.webkit.org/210513@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu 26840a6b45 'custom-configuration-test-group-form' should update test name when selected test or platform changes. 
https://bugs.webkit.org/show_bug.cgi?id=196114

Reviewed by Ryosuke Niwa.

r240104 fixes commit sets unnecessarily get updated even there is no change.
However, this made changing test or platform no longer triggers 'commitSetChange' action.
Test name should change not only when 'commitSet' gets change, but also platform or test changes.
Renaming the action name from 'commitSetChange' to a more accurate description 'testConfigChange'.
Dispatch 'testConfigChange' when platform or test changes.

* browser-tests/custom-analysis-task-configurator-tests.js: Changed action name to 'commitSetChange'.
* public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._didUpdateSelectedPlatforms): Should dispatch 'commitSetChange' action.
(CustomAnalysisTaskConfigurator.prototype._updateCommitSetMap): Changed action name to 'commitSetChange'.
* public/v3/components/custom-configuration-test-group-form.js: Added a unit test for this change.
(CustomConfigurationTestGroupForm.prototype.didConstructShadowTree):

Canonical link: https://commits.webkit.org/210421@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Dewei Zhu 1de6200b50 Fix a bug from r226303 that latest build time is not correctly calculated. 
https://bugs.webkit.org/show_bug.cgi?id=195912

Reviewed by Ryosuke Niwa.

Time series is ordered by revision time which does not grantee the build time is
monotonically increasing.

* public/v3/pages/test-freshness-page.js: Use the latest build time instead of the build time of
last point on the chart.

Canonical link: https://commits.webkit.org/210192@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago
Saam Barati 3ae65a7b14 Unreviewed. Rename JetStream directory to JetStream1.1 
* JetStream: Removed.
* JetStream1.1: Copied from Websites/browserbench.org/JetStream.



Canonical link: https://commits.webkit.org/210186@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 5 years ago