haikuwebkit/Source/WTF/wtf/StackPointer.cpp

48 lines
1.9 KiB
C++
Raw Permalink Normal View History

Changes towards allowing use of the ASAN detect_stack_use_after_return option. https://bugs.webkit.org/show_bug.cgi?id=190405 <rdar://problem/45131464> Reviewed by Michael Saboff. Source/JavaScriptCore: The ASAN detect_stack_use_after_return option checks for use of stack variables after they have been freed. It does this by allocating relevant stack variables in heap memory (instead of on the stack) if the code ever takes the address of those stack variables. Unfortunately, this is a common idiom that we use to compute the approximate stack pointer value. As a result, on such ASAN runs, the computed approximate stack pointer value will point into the heap instead of the stack. This breaks the VM's expectations and wreaks havoc. To fix this, we use the newly introduced WTF::currentStackPointer() instead of taking the address of stack variables. We also need to enhance ExceptionScopes to be able to work with ASAN detect_stack_use_after_return which will allocated the scope in the heap. We work around this by passing the current stack pointer of the instantiating calling frame into the scope constructor, and using that for the position check in ~ThrowScope() instead. The above is only a start towards enabling ASAN detect_stack_use_after_return on the VM. There are still other issues to be resolved before we can run with this ASAN option. * runtime/CatchScope.h: * runtime/ExceptionEventLocation.h: (JSC::ExceptionEventLocation::ExceptionEventLocation): * runtime/ExceptionScope.h: (JSC::ExceptionScope::stackPosition const): * runtime/JSLock.cpp: (JSC::JSLock::didAcquireLock): * runtime/ThrowScope.cpp: (JSC::ThrowScope::~ThrowScope): * runtime/ThrowScope.h: * runtime/VM.h: (JSC::VM::needExceptionCheck const): (JSC::VM::isSafeToRecurse const): * wasm/js/WebAssemblyFunction.cpp: (JSC::callWebAssemblyFunction): * yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::isSafeToRecurse const): Source/WTF: Introduce WTF::currentStackPointer() which computes its caller's stack pointer value. * WTF.xcodeproj/project.pbxproj: * wtf/CMakeLists.txt: * wtf/StackBounds.h: (WTF::StackBounds::checkConsistency const): * wtf/StackPointer.cpp: Added. (WTF::currentStackPointer): * wtf/StackPointer.h: Added. Canonical link: https://commits.webkit.org/205416@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-10-11 19:19:18 +00:00
/*
* Copyright (C) 2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "StackPointer.h"
namespace WTF {
#if USE(GENERIC_CURRENT_STACK_POINTER)
constexpr size_t sizeOfFrameHeader = 2 * sizeof(void*);
SUPPRESS_ASAN NEVER_INLINE
void* currentStackPointer()
{
#if COMPILER(GCC_COMPATIBLE)
return reinterpret_cast<uint8_t*>(__builtin_frame_address(0)) + sizeOfFrameHeader;
#else
// Make sure that sp is the only local variable declared in this function.
void* sp = reinterpret_cast<uint8_t*>(&sp) + sizeOfFrameHeader + sizeof(sp);
return sp;
#endif
}
#endif // USE(GENERIC_CURRENT_STACK_POINTER)
} // namespace WTF