nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/ManualTests/no-listbox-rendering.html

67 lines
2.0 KiB
HTML
Raw Permalink Normal View History

2010-04-15 Luiz Agostini <luiz.agostini@openbossa.org> Reviewed by Antti Koivisto. No default selection for <select multiple> menu lists. https://bugs.webkit.org/show_bug.cgi?id=37530 Manual test: manual-tests/no-listbox-rendering.html For menu lists, if the selection is not indicated by the html file, the first <option> will be selected after loading the page or reseting the form. On the other hand listboxes may have no element selected after loading the page or reseting the form. When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple> that did not have selected elements, now being menu lists, will have the first <option> selected. That is the behavior difference that this patch corrects. When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot be used to decide about initial selection of the elements. This patch replaces (usesMenuLists()) by (!multiple && size <= 1) where initial selection is considered. * dom/SelectElement.cpp: (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::reset): * manual-tests/no-listbox-rendering.html: Added. Canonical link: https://commits.webkit.org/48998@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-04-16 05:59:15 +00:00
<html>
<body>
<style>
td {padding: 20px}
</style>
<br><br>
This test just makes sense if webkit was build with NO_LISTBOX_RENDERING enabled.<br><br>
You should see in the following table three comboboxes and no listboxes.<br><br>
At the right cell you see a description of what should be the state of the elements just after loading this page.<br><br>
<form>
<table border="1">
<tr>
<td><select><option>1</option><option>2</option></select></td>
<td>combobox in previos cell should have option '1' selected.</td>
</tr>
<tr>
<td><select multiple><option>1</option><option>2</option></select></td>
<td>combobox in previos cell should have no selected option.</td>
</tr>
<tr>
<td><select size="5"><option>1</option><option>2</option>s</select></td>
<td>combobox in previos cell should have no selected option.</td>
</tr>
2010-06-19 Yael Aharon <yael.aharon@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Platform plugin's multi-select does not take OptGroup into account https://bugs.webkit.org/show_bug.cgi?id=40718 In multi-select elements, optgroup elements are counted in the index calculation, but in single-select they are not. Keep the same logic even when NO_LISTBOX_RENDERING is enabled. Added tests to the existing manual test, as testing this requires a special build, in which NO_LISTBOX_RENDERING is enabled. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxSelectItem): * manual-tests/no-listbox-rendering.html: * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem): 2010-06-19 Yael Aharon <yael.aharon@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Platform plugin's multi-select does not take OptGroup into account https://bugs.webkit.org/show_bug.cgi?id=40718 Make sure that SelectData is valid throughout the lifetime of the dialog. This is mostly important for the Orbt based plugin. Added virtual desctructors where they were missing. * Api/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): * WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show): * WebCoreSupport/QtPlatformPlugin.h: * examples/platformplugin/WebPlugin.cpp: * examples/platformplugin/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): Canonical link: https://commits.webkit.org/52497@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-06-19 14:19:32 +00:00
<tr>
<td>
<select multiple>
<optgroup label="1"></optgroup>
<option>11</option>
<option>12</option>
<option>13</option>
<option>14</option>
<optgroup label="2"></optgroup>
<option>21</option>
<option>22</option>
<option>23</option>
<option>24</option>
</select>
</td>
<td>combobox in previos cell should handle optgroup correctly.</td>
</tr>
<tr>
<td>
<select>
<optgroup label="1"></optgroup>
<option>11</option>
<option>12</option>
<option>13</option>
<option>14</option>
<optgroup label="2"></optgroup>
<option>21</option>
<option>22</option>
<option>23</option>
<option>24</option>
</select>
</td>
<td>combobox in previos cell should handle optgroup correctly.</td>
</tr>
2010-04-15 Luiz Agostini <luiz.agostini@openbossa.org> Reviewed by Antti Koivisto. No default selection for <select multiple> menu lists. https://bugs.webkit.org/show_bug.cgi?id=37530 Manual test: manual-tests/no-listbox-rendering.html For menu lists, if the selection is not indicated by the html file, the first <option> will be selected after loading the page or reseting the form. On the other hand listboxes may have no element selected after loading the page or reseting the form. When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple> that did not have selected elements, now being menu lists, will have the first <option> selected. That is the behavior difference that this patch corrects. When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot be used to decide about initial selection of the elements. This patch replaces (usesMenuLists()) by (!multiple && size <= 1) where initial selection is considered. * dom/SelectElement.cpp: (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::reset): * manual-tests/no-listbox-rendering.html: Added. Canonical link: https://commits.webkit.org/48998@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-04-16 05:59:15 +00:00
<tr>
<td><input type="reset"</td>
<td>after pressing this button all the combo boxes should go back to the state discribed above.</td>
</tr>
</table>
</form>
</body>
</html>