nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/ManualTests/media-elements/video-replaces-poster.html

16 lines
519 B
HTML
Raw Permalink Normal View History

2010-02-16 Simon Fraser <simon.fraser@apple.com> Reviewed by Eric Carlson. With hardware acceleration turned off, video frames never display if poster image is specified https://bugs.webkit.org/show_bug.cgi?id=34965 HTMLVideoElement's m_shouldDisplayPosterImage was never updated after the movie supplied its first video frame, so the poster would continue to show. Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called each time a new frame is available. updatePosterImage() is cheap. Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of ugly casts. Test: manual-tests/media-elements/video-replaces-poster.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage(). * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual method on the base class. * html/HTMLVideoElement.h: Override updatePosterImage(). Canonical link: https://commits.webkit.org/46135@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-02-16 22:04:37 +00:00
<!DOCTYPE html>
<html>
<head>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=34965">https://bugs.webkit.org/show_bug.cgi?id=34965</a><br>
Disable accelerated compositing and reload this test. You should see the test video
start playing.</p>
<video width="480" height="270" type="video/mp4"
2011-04-12 Eric Carlson <eric.carlson@apple.com> Reviewed by Simon Fraser. Apple movie trailers play only audio https://bugs.webkit.org/show_bug.cgi?id=58339 <rdar://problem/9237606> No new tests, covered by existing layout and manual tests. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions. (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster change the display mode to Video and force a style recalc so the video layer gets hooked up the the render tree. * html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we want to stop displaying the poster as soon as the first frame of video is available. * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when we want to display Video but the media engines doesn't have the first frame yet. * html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode is PosterWaitingForVideo. * manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes. * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element. * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable): * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable. (WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first frame of video has loaded, or audio will begin to play before we can show video. (WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is available, inform elment and begin playback if it was previousl requested. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging. (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause. Canonical link: https://commits.webkit.org/73427@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-13 00:01:11 +00:00
src="../../../../LayoutTests/media/content/test.mp4"
poster="../../../../LayoutTests/media/content/abe.png" autoplay>
2010-02-16 Simon Fraser <simon.fraser@apple.com> Reviewed by Eric Carlson. With hardware acceleration turned off, video frames never display if poster image is specified https://bugs.webkit.org/show_bug.cgi?id=34965 HTMLVideoElement's m_shouldDisplayPosterImage was never updated after the movie supplied its first video frame, so the poster would continue to show. Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called each time a new frame is available. updatePosterImage() is cheap. Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of ugly casts. Test: manual-tests/media-elements/video-replaces-poster.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage(). * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual method on the base class. * html/HTMLVideoElement.h: Override updatePosterImage(). Canonical link: https://commits.webkit.org/46135@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-02-16 22:04:37 +00:00
</video>
</body>
</html>