nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webrtc/video-setDirection-expected...

6 lines
105 B
Plaintext
Raw Permalink Normal View History

A track source should be unmuted whenever reenabled after setDirection changes https://bugs.webkit.org/show_bug.cgi?id=193554 <rdar://problem/47366196> Reviewed by Eric Carlson. Source/WebCore: Ensure that track gets unmuted after being fired as part of track event. Test is triggering some existing issues with MediaPlayerPrivateMediaStreamAVFObjC. Given the enqueuing of samples happens in a different frame than the thread used to update media stream and the active video track, some enqueued samples might not be from the right active video track or there might be no active video track. Test: webrtc/video-setDirection.html * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::fireTrackEvent): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForVideoData): LayoutTests: * webrtc/video-setDirection-expected.txt: Added. * webrtc/video-setDirection.html: Added. Canonical link: https://commits.webkit.org/208078@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-18 17:19:26 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Going from sendrecv to inactive and back to sendrecv
PASS The MediaStream should remain the same
A track source should be unmuted whenever reenabled after setDirection changes https://bugs.webkit.org/show_bug.cgi?id=193554 <rdar://problem/47366196> Reviewed by Eric Carlson. Source/WebCore: Ensure that track gets unmuted after being fired as part of track event. Test is triggering some existing issues with MediaPlayerPrivateMediaStreamAVFObjC. Given the enqueuing of samples happens in a different frame than the thread used to update media stream and the active video track, some enqueued samples might not be from the right active video track or there might be no active video track. Test: webrtc/video-setDirection.html * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::fireTrackEvent): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForVideoData): LayoutTests: * webrtc/video-setDirection-expected.txt: Added. * webrtc/video-setDirection.html: Added. Canonical link: https://commits.webkit.org/208078@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-18 17:19:26 +00:00