This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
webrtc
/
video-rotation-no-cvo-expec...
5 lines
73 B
Plaintext
Raw
Permalink
Normal View
History
Unescape
Escape
Apply rotation at source level if WebRTC sink ask so https://bugs.webkit.org/show_bug.cgi?id=205645 Reviewed by Eric Carlson. Source/WebCore: Add a virtual method to RealtimeMediaSource to pass the information that the sink prefers the frames to be rotated before sending them. Source/WebKit: Implement RealtimeMediaSource setShouldApplyRotation by sending IPC to capture process. In capture process, if rotation should be applied, use an ImageRotationSessionVT session to apply it before sending the video frame. This allows WebProcess to no longer need an ImageRotationSessionVT for WebRTC. * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: (WebKit::UserMediaCaptureManagerProxy::SourceProxy::setShouldApplyRotation): (WebKit::UserMediaCaptureManagerProxy::SourceProxy::rotatePixelBuffer): (WebKit::UserMediaCaptureManagerProxy::setShouldApplyRotation): * UIProcess/Cocoa/UserMediaCaptureManagerProxy.h: * UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in: * WebProcess/cocoa/UserMediaCaptureManager.cpp: (WebKit::UserMediaCaptureManager::Source::setShouldApplyRotation): LayoutTests: * webrtc/video-rotation-no-cvo-expected.txt: Added. * webrtc/video-rotation-no-cvo.html: Added. Canonical link: https://commits.webkit.org/222046@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-03-16 16:41:12 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Testing video exchange with rotation applied before transmission
Apply rotation at source level if WebRTC sink ask so https://bugs.webkit.org/show_bug.cgi?id=205645 Reviewed by Eric Carlson. Source/WebCore: Add a virtual method to RealtimeMediaSource to pass the information that the sink prefers the frames to be rotated before sending them. Source/WebKit: Implement RealtimeMediaSource setShouldApplyRotation by sending IPC to capture process. In capture process, if rotation should be applied, use an ImageRotationSessionVT session to apply it before sending the video frame. This allows WebProcess to no longer need an ImageRotationSessionVT for WebRTC. * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: (WebKit::UserMediaCaptureManagerProxy::SourceProxy::setShouldApplyRotation): (WebKit::UserMediaCaptureManagerProxy::SourceProxy::rotatePixelBuffer): (WebKit::UserMediaCaptureManagerProxy::setShouldApplyRotation): * UIProcess/Cocoa/UserMediaCaptureManagerProxy.h: * UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in: * WebProcess/cocoa/UserMediaCaptureManager.cpp: (WebKit::UserMediaCaptureManager::Source::setShouldApplyRotation): LayoutTests: * webrtc/video-rotation-no-cvo-expected.txt: Added. * webrtc/video-rotation-no-cvo.html: Added. Canonical link: https://commits.webkit.org/222046@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-03-16 16:41:12 +00:00