nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webrtc/utf8-sdp-expected.txt

5 lines
51 B
Plaintext
Raw Permalink Normal View History

Preventively expect UTF8 strings from libwebrtc SDP and error messages https://bugs.webkit.org/show_bug.cgi?id=184509 Reviewed by Eric Carlson. Source/WebCore: Make WebCore code expect any libwebrtc string to contain UTF-8. Currently SDPs do not contain any UTF-8 specific character but https://tools.ietf.org/html/rfc4566 allows it. Add Internals API to set track id so that we can inject UTF-8 inside some WebRTC tests. Test: webrtc/utf8-sdp.html * Modules/mediastream/MediaStreamTrack.h: (WebCore::MediaStreamTrack::setIdForTesting): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fromStdString): (WebCore::fromSessionDescription): (WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription): (WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription): (WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream): (WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): (WebCore::LibWebRTCMediaEndpoint::addDataChannel): (WebCore::LibWebRTCMediaEndpoint::OnIceCandidate): (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded): (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionFailed): (WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionFailed): (WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionFailed): (WebCore::trackId): Deleted. * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::fromStdString): (WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate): (WebCore::createReceiverForSource): * platform/mediastream/MediaStreamTrackPrivate.h: (WebCore::MediaStreamTrackPrivate::setIdForTesting): * testing/Internals.cpp: (WebCore::Internals::setMediaStreamTrackIdentifier): * testing/Internals.h: * testing/Internals.idl: LayoutTests: * webrtc/utf8-sdp-expected.txt: Added. * webrtc/utf8-sdp.html: Added. Canonical link: https://commits.webkit.org/200065@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-04-11 21:49:28 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Testing video exchange with UTF-8 track id
Preventively expect UTF8 strings from libwebrtc SDP and error messages https://bugs.webkit.org/show_bug.cgi?id=184509 Reviewed by Eric Carlson. Source/WebCore: Make WebCore code expect any libwebrtc string to contain UTF-8. Currently SDPs do not contain any UTF-8 specific character but https://tools.ietf.org/html/rfc4566 allows it. Add Internals API to set track id so that we can inject UTF-8 inside some WebRTC tests. Test: webrtc/utf8-sdp.html * Modules/mediastream/MediaStreamTrack.h: (WebCore::MediaStreamTrack::setIdForTesting): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fromStdString): (WebCore::fromSessionDescription): (WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription): (WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription): (WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream): (WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): (WebCore::LibWebRTCMediaEndpoint::addDataChannel): (WebCore::LibWebRTCMediaEndpoint::OnIceCandidate): (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded): (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionFailed): (WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionFailed): (WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionFailed): (WebCore::trackId): Deleted. * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::fromStdString): (WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate): (WebCore::createReceiverForSource): * platform/mediastream/MediaStreamTrackPrivate.h: (WebCore::MediaStreamTrackPrivate::setIdForTesting): * testing/Internals.cpp: (WebCore::Internals::setMediaStreamTrackIdentifier): * testing/Internals.h: * testing/Internals.idl: LayoutTests: * webrtc/utf8-sdp-expected.txt: Added. * webrtc/utf8-sdp.html: Added. Canonical link: https://commits.webkit.org/200065@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-04-11 21:49:28 +00:00