nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webrtc/rtcpeerconnection-error-mes...

31 lines
2.9 KiB
Plaintext
Raw Permalink Normal View History

RTCPeerConnection methods can take dictionaries as input https://bugs.webkit.org/show_bug.cgi?id=167590 Patch by Youenn Fablet <youenn@apple.com> on 2017-01-31 Reviewed by Alex Christensen. Source/WebCore: Test: webrtc/rtcpeerconnection-error-messages.html Made addIceCandidate/setRemoteDescription/setLocalDescription take either dictionaries or objects as parameter. Spec only mandates this for addIceCandidate, but sites may be using the old version for setRemoteDescription and setLocalDescription. Updated RTCPeerConnection methods error messages. * Modules/mediastream/RTCPeerConnection.js: (getLocalStreams): (getStreamById): (addStream): (createOffer): (createAnswer): (setLocalDescription): (setRemoteDescription): (addIceCandidate): (getStats): * Modules/mediastream/RTCPeerConnectionInternals.js: LayoutTests: Replacing fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html by webrtc/rtcpeerconnection-error-messages.html. It is a bit more thorough and does not hard code the error message. * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-addIceCandidate.html: * fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt: Removed. * fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html: Removed. * fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html: * webrtc/rtcpeerconnection-error-messages-expected.txt: Added. * webrtc/rtcpeerconnection-error-messages.html: Added. Canonical link: https://commits.webkit.org/184675@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-01-31 17:52:33 +00:00
TypeError: The RTCPeerConnection.localDescription getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.currentLocalDescription getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.pendingLocalDescription getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.remoteDescription getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.currentRemoteDescription getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.pendingRemoteDescription getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.signalingState getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.iceGatheringState getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.iceConnectionState getter can only be used on instances of RTCPeerConnection
Support RTCPeerConnectionState https://bugs.webkit.org/show_bug.cgi?id=169978 Patch by Youenn Fablet <youenn@apple.com> on 2017-03-22 Reviewed by Jon Lee. LayoutTests/imported/w3c: * web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt: Source/WebCore: Test: webrtc/connection-state.html Implementing https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum. Its state and event is based on changes made to ice gathering state and ice connection state. * CMakeLists.txt: Adding RTCPeerConnectionState idl. * DerivedSources.make: Ditto. * Modules/mediastream/RTCPeerConnection.cpp: Splitting close in doClose/doStop so that we can send closed event in case close is called, but not if stopped. (WebCore::RTCPeerConnection::doClose): (WebCore::RTCPeerConnection::close): (WebCore::RTCPeerConnection::stop): (WebCore::RTCPeerConnection::doStop): (WebCore::RTCPeerConnection::updateIceGatheringState): (WebCore::RTCPeerConnection::updateIceConnectionState): (WebCore::RTCPeerConnection::updateConnectionState): * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/RTCPeerConnection.idl: Fixing IDL and minor cosmetic changes * Modules/mediastream/RTCPeerConnection.js: (setLocalDescription): Cosmetic change. (setRemoteDescription): * Modules/mediastream/RTCPeerConnectionState.idl: Added. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::OnIceGatheringChange): Adding 'gathering' state * WebCore.xcodeproj/project.pbxproj: * dom/EventNames.h: * platform/mediastream/RTCPeerConnectionState.h: Added. LayoutTests: * webrtc/connection-state-expected.txt: Added. * webrtc/connection-state.html: Added. * webrtc/rtcpeerconnection-error-messages-expected.txt: Canonical link: https://commits.webkit.org/186920@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-03-23 02:44:57 +00:00
TypeError: The RTCPeerConnection.connectionState getter can only be used on instances of RTCPeerConnection
Add support for RTCPeerConnection.canTrickleIceCandidates https://bugs.webkit.org/show_bug.cgi?id=229287 Reviewed by Eric Carlson. LayoutTests/imported/w3c: * web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-constructor-expected.txt: * web-platform-tests/webrtc/idlharness.https.window-expected.txt: Source/WebCore: Add support for https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-cantrickleicecandidates. Return null in case connection is closed or setRemoteDescription was never called successfully. Add binding code to get the value from webrtc backend. Covered by rebased tests. * Modules/mediastream/PeerConnectionBackend.h: * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::canTrickleIceCandidates const): * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/RTCPeerConnection.idl: * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::canTrickleIceCandidates const): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::LibWebRTCPeerConnectionBackend::canTrickleIceCandidates const): * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: LayoutTests: * webrtc/rtcpeerconnection-error-messages-expected.txt: Canonical link: https://commits.webkit.org/240722@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-08-20 07:55:13 +00:00
TypeError: The RTCPeerConnection.canTrickleIceCandidates getter can only be used on instances of RTCPeerConnection
RTCPeerConnection methods can take dictionaries as input https://bugs.webkit.org/show_bug.cgi?id=167590 Patch by Youenn Fablet <youenn@apple.com> on 2017-01-31 Reviewed by Alex Christensen. Source/WebCore: Test: webrtc/rtcpeerconnection-error-messages.html Made addIceCandidate/setRemoteDescription/setLocalDescription take either dictionaries or objects as parameter. Spec only mandates this for addIceCandidate, but sites may be using the old version for setRemoteDescription and setLocalDescription. Updated RTCPeerConnection methods error messages. * Modules/mediastream/RTCPeerConnection.js: (getLocalStreams): (getStreamById): (addStream): (createOffer): (createAnswer): (setLocalDescription): (setRemoteDescription): (addIceCandidate): (getStats): * Modules/mediastream/RTCPeerConnectionInternals.js: LayoutTests: Replacing fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html by webrtc/rtcpeerconnection-error-messages.html. It is a bit more thorough and does not hard code the error message. * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-addIceCandidate.html: * fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt: Removed. * fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html: Removed. * fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html: * webrtc/rtcpeerconnection-error-messages-expected.txt: Added. * webrtc/rtcpeerconnection-error-messages.html: Added. Canonical link: https://commits.webkit.org/184675@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-01-31 17:52:33 +00:00
[object RTCPeerConnection] has no property named defaultIceServers
TypeError: Can only call RTCPeerConnection.getConfiguration on instances of RTCPeerConnection
TypeError: Can only call RTCPeerConnection.setConfiguration on instances of RTCPeerConnection
TypeError: Can only call RTCPeerConnection.close on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.onnegotiationneeded getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.onicecandidate getter can only be used on instances of RTCPeerConnection
Add support for RTCPeerConnection.onicecandidateerror event https://bugs.webkit.org/show_bug.cgi?id=169644 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/webrtc/idlharness.https.window-expected.txt: Source/WebCore: Expose RTCPeerConnection.onicecandidateerror and use it for wrong STUN/TURN server URLs. For that matter, add RTCPeerConnectionIceErrorEvent as per spec with a slight change to the init directory to keep the same terminology between event and init dictionary. Covered by updated webrtc/stun-server-filtering.html test. * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::iceServersFromConfiguration): (WebCore::iceServersFromConfiguration): Deleted. * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/RTCPeerConnection.idl: * Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp: Added. (WebCore::RTCPeerConnectionIceErrorEvent::create): (WebCore::RTCPeerConnectionIceErrorEvent::RTCPeerConnectionIceErrorEvent): (WebCore::RTCPeerConnectionIceErrorEvent::eventInterface const): * Modules/mediastream/RTCPeerConnectionIceErrorEvent.h: Added. * Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl: Added. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/WebCoreBuiltinNames.h: * dom/EventNames.h: * dom/EventNames.in: LayoutTests: * webrtc/rtcpeerconnection-error-messages-expected.txt: * webrtc/stun-server-filtering.html: Canonical link: https://commits.webkit.org/231814@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-11-20 11:05:32 +00:00
TypeError: The RTCPeerConnection.onicecandidateerror getter can only be used on instances of RTCPeerConnection
RTCPeerConnection methods can take dictionaries as input https://bugs.webkit.org/show_bug.cgi?id=167590 Patch by Youenn Fablet <youenn@apple.com> on 2017-01-31 Reviewed by Alex Christensen. Source/WebCore: Test: webrtc/rtcpeerconnection-error-messages.html Made addIceCandidate/setRemoteDescription/setLocalDescription take either dictionaries or objects as parameter. Spec only mandates this for addIceCandidate, but sites may be using the old version for setRemoteDescription and setLocalDescription. Updated RTCPeerConnection methods error messages. * Modules/mediastream/RTCPeerConnection.js: (getLocalStreams): (getStreamById): (addStream): (createOffer): (createAnswer): (setLocalDescription): (setRemoteDescription): (addIceCandidate): (getStats): * Modules/mediastream/RTCPeerConnectionInternals.js: LayoutTests: Replacing fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html by webrtc/rtcpeerconnection-error-messages.html. It is a bit more thorough and does not hard code the error message. * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-addIceCandidate.html: * fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt: Removed. * fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html: Removed. * fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html: * webrtc/rtcpeerconnection-error-messages-expected.txt: Added. * webrtc/rtcpeerconnection-error-messages.html: Added. Canonical link: https://commits.webkit.org/184675@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-01-31 17:52:33 +00:00
TypeError: The RTCPeerConnection.onsignalingstatechange getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.oniceconnectionstatechange getter can only be used on instances of RTCPeerConnection
TypeError: The RTCPeerConnection.onicegatheringstatechange getter can only be used on instances of RTCPeerConnection
Support RTCPeerConnectionState https://bugs.webkit.org/show_bug.cgi?id=169978 Patch by Youenn Fablet <youenn@apple.com> on 2017-03-22 Reviewed by Jon Lee. LayoutTests/imported/w3c: * web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt: Source/WebCore: Test: webrtc/connection-state.html Implementing https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum. Its state and event is based on changes made to ice gathering state and ice connection state. * CMakeLists.txt: Adding RTCPeerConnectionState idl. * DerivedSources.make: Ditto. * Modules/mediastream/RTCPeerConnection.cpp: Splitting close in doClose/doStop so that we can send closed event in case close is called, but not if stopped. (WebCore::RTCPeerConnection::doClose): (WebCore::RTCPeerConnection::close): (WebCore::RTCPeerConnection::stop): (WebCore::RTCPeerConnection::doStop): (WebCore::RTCPeerConnection::updateIceGatheringState): (WebCore::RTCPeerConnection::updateIceConnectionState): (WebCore::RTCPeerConnection::updateConnectionState): * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/RTCPeerConnection.idl: Fixing IDL and minor cosmetic changes * Modules/mediastream/RTCPeerConnection.js: (setLocalDescription): Cosmetic change. (setRemoteDescription): * Modules/mediastream/RTCPeerConnectionState.idl: Added. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::OnIceGatheringChange): Adding 'gathering' state * WebCore.xcodeproj/project.pbxproj: * dom/EventNames.h: * platform/mediastream/RTCPeerConnectionState.h: Added. LayoutTests: * webrtc/connection-state-expected.txt: Added. * webrtc/connection-state.html: Added. * webrtc/rtcpeerconnection-error-messages-expected.txt: Canonical link: https://commits.webkit.org/186920@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-03-23 02:44:57 +00:00
TypeError: The RTCPeerConnection.onconnectionstatechange getter can only be used on instances of RTCPeerConnection
RTCPeerConnection methods can take dictionaries as input https://bugs.webkit.org/show_bug.cgi?id=167590 Patch by Youenn Fablet <youenn@apple.com> on 2017-01-31 Reviewed by Alex Christensen. Source/WebCore: Test: webrtc/rtcpeerconnection-error-messages.html Made addIceCandidate/setRemoteDescription/setLocalDescription take either dictionaries or objects as parameter. Spec only mandates this for addIceCandidate, but sites may be using the old version for setRemoteDescription and setLocalDescription. Updated RTCPeerConnection methods error messages. * Modules/mediastream/RTCPeerConnection.js: (getLocalStreams): (getStreamById): (addStream): (createOffer): (createAnswer): (setLocalDescription): (setRemoteDescription): (addIceCandidate): (getStats): * Modules/mediastream/RTCPeerConnectionInternals.js: LayoutTests: Replacing fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html by webrtc/rtcpeerconnection-error-messages.html. It is a bit more thorough and does not hard code the error message. * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-addIceCandidate.html: * fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt: Removed. * fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html: Removed. * fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html: * webrtc/rtcpeerconnection-error-messages-expected.txt: Added. * webrtc/rtcpeerconnection-error-messages.html: Added. Canonical link: https://commits.webkit.org/184675@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-01-31 17:52:33 +00:00
Promise rejected with: TypeError: Can only call RTCPeerConnection.createOffer on instances of RTCPeerConnection
Promise rejected with: TypeError: Can only call RTCPeerConnection.createAnswer on instances of RTCPeerConnection
Promise rejected with: TypeError: Can only call RTCPeerConnection.setLocalDescription on instances of RTCPeerConnection
Promise rejected with: TypeError: Can only call RTCPeerConnection.setRemoteDescription on instances of RTCPeerConnection
Promise rejected with: TypeError: Can only call RTCPeerConnection.addIceCandidate on instances of RTCPeerConnection
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Exercising TypeError messages in RTCPeerConnection
RTCPeerConnection methods can take dictionaries as input https://bugs.webkit.org/show_bug.cgi?id=167590 Patch by Youenn Fablet <youenn@apple.com> on 2017-01-31 Reviewed by Alex Christensen. Source/WebCore: Test: webrtc/rtcpeerconnection-error-messages.html Made addIceCandidate/setRemoteDescription/setLocalDescription take either dictionaries or objects as parameter. Spec only mandates this for addIceCandidate, but sites may be using the old version for setRemoteDescription and setLocalDescription. Updated RTCPeerConnection methods error messages. * Modules/mediastream/RTCPeerConnection.js: (getLocalStreams): (getStreamById): (addStream): (createOffer): (createAnswer): (setLocalDescription): (setRemoteDescription): (addIceCandidate): (getStats): * Modules/mediastream/RTCPeerConnectionInternals.js: LayoutTests: Replacing fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html by webrtc/rtcpeerconnection-error-messages.html. It is a bit more thorough and does not hard code the error message. * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-addIceCandidate.html: * fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt: Removed. * fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html: Removed. * fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt: * fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html: * webrtc/rtcpeerconnection-error-messages-expected.txt: Added. * webrtc/rtcpeerconnection-error-messages.html: Added. Canonical link: https://commits.webkit.org/184675@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-01-31 17:52:33 +00:00