nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webrtc/remove-track-expected.txt

9 lines
141 B
Plaintext
Raw Permalink Normal View History

track.onmute isn't called for a remote MediaStreamTrack when its counter part track is removed from the peer connection https://bugs.webkit.org/show_bug.cgi?id=176281 <rdar://problem/44525674> Reviewed by Eric Carlson. Source/WebCore: Listen to libwebrtc remove track callbacks. Implement handling as per https://w3c.github.io/webrtc-pc/#process-remote-track-removal. This triggers a mute event on the track. Test: webrtc/remove-track.html * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack): (WebCore::LibWebRTCMediaEndpoint::OnRemoveTrack): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::LibWebRTCPeerConnectionBackend::shouldOfferAllowToReceive const): Drive by fix: Plan B code path does not mandate having an rtc backend for each sender. LayoutTests: * webrtc/remove-track-expected.txt: Added. * webrtc/remove-track.html: Added. Canonical link: https://commits.webkit.org/204646@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-09-17 22:22:15 +00:00
Introduce a C++ chain of operations in RTCPeerConnection https://bugs.webkit.org/show_bug.cgi?id=216006 Reviewed by Eric Carlson. LayoutTests/imported/w3c: * web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-timing.https-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation.https-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-parameterless.https-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback-expected.txt: * web-platform-tests/webrtc/RTCPeerConnection-track-stats.https-expected.txt: * web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt: * web-platform-tests/webrtc/idlharness.https.window-expected.txt: Source/WebCore: Remove RTCPeerConnection JS built-ins and introduce a C++ version. This allows to make replaceTrack part of the chain of operation. Also update setLocalDescription to take no parameters. Covered by rebased tests. * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Headers.cmake: * Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::createOfferSucceeded): (WebCore::PeerConnectionBackend::createAnswerSucceeded): (WebCore::PeerConnectionBackend::setLocalDescription): (WebCore::PeerConnectionBackend::setRemoteDescription): (WebCore::PeerConnectionBackend::transceiverFromSender): Deleted. * Modules/mediastream/PeerConnectionBackend.h: * Modules/mediastream/RTCIceCandidate.cpp: (WebCore::RTCIceCandidate::create): * Modules/mediastream/RTCIceCandidate.h: * Modules/mediastream/RTCIceCandidate.idl: * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::create): (WebCore::RTCPeerConnection::removeTrack): (WebCore::RTCPeerConnection::createOffer): (WebCore::RTCPeerConnection::createAnswer): (WebCore::RTCPeerConnection::setLocalDescription): (WebCore::RTCPeerConnection::setRemoteDescription): (WebCore::RTCPeerConnection::addIceCandidate): (WebCore::RTCPeerConnection::getStats): (WebCore::RTCPeerConnection::doClose): (WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent): (WebCore::RTCPeerConnection::chainOperation): (WebCore::RTCPeerConnection::initializeWith): Deleted. (WebCore::RTCPeerConnection::queuedCreateOffer): Deleted. (WebCore::RTCPeerConnection::queuedCreateAnswer): Deleted. (WebCore::RTCPeerConnection::queuedSetLocalDescription): Deleted. (WebCore::RTCPeerConnection::queuedSetRemoteDescription): Deleted. (WebCore::RTCPeerConnection::queuedAddIceCandidate): Deleted. * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/RTCPeerConnection.idl: * Modules/mediastream/RTCPeerConnection.js: Removed. * Modules/mediastream/RTCPeerConnectionInternals.js: Removed. * Modules/mediastream/RTCRtpSender.cpp: (WebCore::RTCRtpSender::create): (WebCore::RTCRtpSender::RTCRtpSender): (WebCore::RTCRtpSender::replaceTrack): (WebCore::RTCRtpSender::isCreatedBy const): (WebCore::RTCRtpSender::dtmf): (WebCore::RTCRtpSender::currentTransceiverDirection const): * Modules/mediastream/RTCRtpSender.h: * Modules/mediastream/RTCRtpSender.idl: * Modules/mediastream/RTCRtpSenderBackend.h: * Modules/mediastream/RTCSessionDescription.cpp: (WebCore::RTCSessionDescription::create): * Modules/mediastream/RTCSessionDescription.h: * Modules/mediastream/RTCSessionDescription.idl: * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription): (WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::LibWebRTCPeerConnectionBackend::doSetLocalDescription): (WebCore::LibWebRTCPeerConnectionBackend::doSetRemoteDescription): (WebCore::LibWebRTCPeerConnectionBackend::addTrack): (WebCore::LibWebRTCPeerConnectionBackend::addTransceiverFromTrackOrKind): (WebCore::LibWebRTCPeerConnectionBackend::newRemoteTransceiver): * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: * Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp: (WebCore::LibWebRTCRtpSenderBackend::replaceTrack): * Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: LayoutTests: * fast/mediastream/RTCIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: * fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt: * fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid-expected.txt: * webrtc/libwebrtc/release-while-creating-offer-expected.txt: * webrtc/remove-track-expected.txt: * webrtc/remove-track.html: Make sure we are in a stable state before going to removeTrack actual test. Also make sure to call setRemoteDescription for second test. Canonical link: https://commits.webkit.org/228873@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-02 16:19:52 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Setup audio video exchange
PASS Remove video track
PASS Remove audio track
PASS Add/remove audio tracks
PASS Add/remove video tracks
track.onmute isn't called for a remote MediaStreamTrack when its counter part track is removed from the peer connection https://bugs.webkit.org/show_bug.cgi?id=176281 <rdar://problem/44525674> Reviewed by Eric Carlson. Source/WebCore: Listen to libwebrtc remove track callbacks. Implement handling as per https://w3c.github.io/webrtc-pc/#process-remote-track-removal. This triggers a mute event on the track. Test: webrtc/remove-track.html * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack): (WebCore::LibWebRTCMediaEndpoint::OnRemoveTrack): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::LibWebRTCPeerConnectionBackend::shouldOfferAllowToReceive const): Drive by fix: Plan B code path does not mandate having an rtc backend for each sender. LayoutTests: * webrtc/remove-track-expected.txt: Added. * webrtc/remove-track.html: Added. Canonical link: https://commits.webkit.org/204646@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-09-17 22:22:15 +00:00