nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webrtc/pc-detached-document-expect...

5 lines
150 B
Plaintext
Raw Permalink Normal View History

Throw in case of PeerConnection created for detached documents https://bugs.webkit.org/show_bug.cgi?id=184921 <rdar://problem/39629216> Reviewed by Eric Carlson. Source/WebCore: Add a check to ensure that page is not null when creating a peer connection backend. In that case, the peer connection constructor will later on throw. The same for setConfiguration is done. Behavior is consistent with Chrome. Test: webrtc/pc-detached-document.html * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::createLibWebRTCPeerConnectionBackend): (WebCore::LibWebRTCPeerConnectionBackend::LibWebRTCPeerConnectionBackend): (WebCore::LibWebRTCPeerConnectionBackend::setConfiguration): (WebCore::libWebRTCProvider): Deleted. * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: LayoutTests: * webrtc/pc-detached-document-expected.txt: Added. * webrtc/pc-detached-document.html: Added. Canonical link: https://commits.webkit.org/200443@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-04-24 20:22:51 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Peer Connection objects should not be created in detached documents
PASS Peer Connection objects should not be created in detached documents 2
Throw in case of PeerConnection created for detached documents https://bugs.webkit.org/show_bug.cgi?id=184921 <rdar://problem/39629216> Reviewed by Eric Carlson. Source/WebCore: Add a check to ensure that page is not null when creating a peer connection backend. In that case, the peer connection constructor will later on throw. The same for setConfiguration is done. Behavior is consistent with Chrome. Test: webrtc/pc-detached-document.html * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::createLibWebRTCPeerConnectionBackend): (WebCore::LibWebRTCPeerConnectionBackend::LibWebRTCPeerConnectionBackend): (WebCore::LibWebRTCPeerConnectionBackend::setConfiguration): (WebCore::libWebRTCProvider): Deleted. * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: LayoutTests: * webrtc/pc-detached-document-expected.txt: Added. * webrtc/pc-detached-document.html: Added. Canonical link: https://commits.webkit.org/200443@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-04-24 20:22:51 +00:00