This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
webrtc
/
no-port-zero-in-upd-candida...
4 lines
40 B
Plaintext
Raw
Permalink
Normal View
History
Unescape
Escape
[WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates https://bugs.webkit.org/show_bug.cgi?id=167939 Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-07 Reviewed by Sam Weinig. Source/WebCore: Test: webrtc/no-port-zero-in-upd-candidates.html * testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnectionFactory::MockLibWebRTCPeerConnectionFactory): Adding a way to create one real PC in WTR environment. Source/WebKit2: AddressReady signalling was done by the WebProcess for UDP and ServerTCP as real async sockets in those case do not send it. But the WebProcess does not have information on the port, as it is assigned by the socket factory which is in the network process. Fixed that bug by signalling AddressReady in the network process for UDP, ServerTCP and ClientTCP. * NetworkProcess/webrtc/LibWebRTCSocketClient.cpp: (WebKit::LibWebRTCSocketClient::LibWebRTCSocketClient): (WebKit::LibWebRTCSocketClient::signalAddressReady): * NetworkProcess/webrtc/LibWebRTCSocketClient.h: * NetworkProcess/webrtc/NetworkRTCProvider.cpp: (WebKit::NetworkRTCProvider::createUDPSocket): (WebKit::NetworkRTCProvider::createServerTCPSocket): (WebKit::NetworkRTCProvider::createClientTCPSocket): * WebProcess/Network/webrtc/LibWebRTCSocket.cpp: (WebKit::LibWebRTCSocket::LibWebRTCSocket): (WebKit::LibWebRTCSocket::signalAddressReady): LayoutTests: * webrtc/no-port-zero-in-upd-candidates.html: Added. * webrtc/no-port-zero-in-upd-candidates-expected.txt: Added. * webrtc/video.html: * webrtc/video-expected.txt: Added. Canonical link: https://commits.webkit.org/184979@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-02-07 20:19:09 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Checking UDP ICE candidate ports
[WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates https://bugs.webkit.org/show_bug.cgi?id=167939 Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-07 Reviewed by Sam Weinig. Source/WebCore: Test: webrtc/no-port-zero-in-upd-candidates.html * testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnectionFactory::MockLibWebRTCPeerConnectionFactory): Adding a way to create one real PC in WTR environment. Source/WebKit2: AddressReady signalling was done by the WebProcess for UDP and ServerTCP as real async sockets in those case do not send it. But the WebProcess does not have information on the port, as it is assigned by the socket factory which is in the network process. Fixed that bug by signalling AddressReady in the network process for UDP, ServerTCP and ClientTCP. * NetworkProcess/webrtc/LibWebRTCSocketClient.cpp: (WebKit::LibWebRTCSocketClient::LibWebRTCSocketClient): (WebKit::LibWebRTCSocketClient::signalAddressReady): * NetworkProcess/webrtc/LibWebRTCSocketClient.h: * NetworkProcess/webrtc/NetworkRTCProvider.cpp: (WebKit::NetworkRTCProvider::createUDPSocket): (WebKit::NetworkRTCProvider::createServerTCPSocket): (WebKit::NetworkRTCProvider::createClientTCPSocket): * WebProcess/Network/webrtc/LibWebRTCSocket.cpp: (WebKit::LibWebRTCSocket::LibWebRTCSocket): (WebKit::LibWebRTCSocket::signalAddressReady): LayoutTests: * webrtc/no-port-zero-in-upd-candidates.html: Added. * webrtc/no-port-zero-in-upd-candidates-expected.txt: Added. * webrtc/video.html: * webrtc/video-expected.txt: Added. Canonical link: https://commits.webkit.org/184979@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-02-07 20:19:09 +00:00