nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webrtc/negotiatedneeded-event-addS...

6 lines
111 B
Plaintext
Raw Permalink Normal View History

[WebRTC] Add support for libwebrtc negotiation needed event https://bugs.webkit.org/show_bug.cgi?id=168267 Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-14 Reviewed by Eric Carlson. Source/WebCore: Test: webrtc/negotiatedneeded-event-addStream.html Moving generic code (markAsNeedingNegotiation) from MediaEndpointPeerConnection to PeerConnectionBackend. This code handles the control of sending or not the negotiationneeded event. Updating mock to use markAsNeedingNegotiation when streams are changed. Updating libwebrtc backend to call markAsNeedingNegotiation when required by libwebrtc implementation. * Modules/mediastream/MediaEndpointPeerConnection.cpp: (WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask): * Modules/mediastream/MediaEndpointPeerConnection.h: * Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::markAsNeedingNegotiation): * Modules/mediastream/PeerConnectionBackend.h: (WebCore::PeerConnectionBackend::isNegotiationNeeded): (WebCore::PeerConnectionBackend::clearNegotiationNeededState): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::OnRenegotiationNeeded): * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: * testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnection::AddStream): (WebCore::MockLibWebRTCPeerConnection::RemoveStream): LayoutTests: * fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: * platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt. * webrtc/negotiatedneeded-event-addStream-expected.txt: Added. * webrtc/negotiatedneeded-event-addStream.html: Added. Canonical link: https://commits.webkit.org/185370@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-02-15 01:23:39 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS on negotiation needed in case of adding a stream
PASS on negotiation needed not called if pc is closed
[WebRTC] Add support for libwebrtc negotiation needed event https://bugs.webkit.org/show_bug.cgi?id=168267 Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-14 Reviewed by Eric Carlson. Source/WebCore: Test: webrtc/negotiatedneeded-event-addStream.html Moving generic code (markAsNeedingNegotiation) from MediaEndpointPeerConnection to PeerConnectionBackend. This code handles the control of sending or not the negotiationneeded event. Updating mock to use markAsNeedingNegotiation when streams are changed. Updating libwebrtc backend to call markAsNeedingNegotiation when required by libwebrtc implementation. * Modules/mediastream/MediaEndpointPeerConnection.cpp: (WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask): * Modules/mediastream/MediaEndpointPeerConnection.h: * Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::markAsNeedingNegotiation): * Modules/mediastream/PeerConnectionBackend.h: (WebCore::PeerConnectionBackend::isNegotiationNeeded): (WebCore::PeerConnectionBackend::clearNegotiationNeededState): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::OnRenegotiationNeeded): * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: * testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnection::AddStream): (WebCore::MockLibWebRTCPeerConnection::RemoveStream): LayoutTests: * fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: * platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt. * webrtc/negotiatedneeded-event-addStream-expected.txt: Added. * webrtc/negotiatedneeded-event-addStream.html: Added. Canonical link: https://commits.webkit.org/185370@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-02-15 01:23:39 +00:00