nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webgl/webgl2-rendering-context-de...

2 lines
43 B
Plaintext
Raw Permalink Normal View History

[WebGL2] Turn the ENABLE_WEBGL2 flag on https://bugs.webkit.org/show_bug.cgi?id=156061 <rdar://problem/25463193> Patch by Antoine Quint <graouts@apple.com> on 2016-04-05 Reviewed by Alex Christensen. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: * runtime/CommonIdentifiers.h: Define the conditionalized classes WebGL2RenderingContext and WebGLVertexArrayObject. Source/WebCore: Conditionalize the definition of the WebGL2RenderingContext and WebGLVertexArrayObject globals based on the new WebGL2 runtime flag we introduced in https://webkit.org/b/156166. Turning the ENABLE_WEBGL2 flag on caused a host of build errors which we fix here. A non-obvious error was in code generated from the html/canvas/WebGL2RenderingContext.idl file which was solved by updating the getBufferSubData() method to the current signature as of the March 29 Editor's Draft of the WebGL 2 Specification (https://www.khronos.org/registry/webgl/specs/latest/2.0/). Missing JSC headers in WebGL2RenderingContext.cpp also caused some linking errors in Release builds. Tests: webgl/webgl-vertex-array-object-defined.html webgl/webgl2-rendering-context-defined.html webgl/webgl2-rendering-context-obtain.html * Configurations/FeatureDefines.xcconfig: * bindings/js/JSWebGL2RenderingContextCustom.cpp: (WebCore::JSWebGL2RenderingContext::getInternalformatParameter): (WebCore::JSWebGL2RenderingContext::getQueryParameter): (WebCore::JSWebGL2RenderingContext::getSamplerParameter): (WebCore::JSWebGL2RenderingContext::getSyncParameter): (WebCore::JSWebGL2RenderingContext::getIndexedParameter): (WebCore::JSWebGL2RenderingContext::getActiveUniformBlockParameter): (WebCore::JSWebGL2RenderingContext::getActiveUniformBlockName): * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::is3dType): * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getBufferSubData): Deleted. * html/canvas/WebGL2RenderingContext.idl: * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::create): * html/canvas/WebGLVertexArrayObject.idl: Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Source/WebKit2: * Configurations/FeatureDefines.xcconfig: LayoutTests: * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt: * platform/mac/js/dom/global-constructors-attributes-expected.txt: The WebGL2RenderingContext and WebGLVertexArrayObject classes are now defined so expectations for this test which lists the configuration of global constructors needed to be updated. * webgl/webgl-vertex-array-object-defined-expected.txt: Added. * webgl/webgl-vertex-array-object-defined.html: Added. Test checking that WebGLVertexArrayObject is defined. * webgl/webgl2-rendering-context-defined-expected.txt: Added. * webgl/webgl2-rendering-context-defined.html: Added. Test checking that WebGL2RenderingContext is defined. * webgl/webgl2-rendering-context-obtain-expected.txt: Added. * webgl/webgl2-rendering-context-obtain.html: Added. Test checking that asking for a "webgl2" context returns a WebGL2RenderingContext. Canonical link: https://commits.webkit.org/174337@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-04-05 16:54:07 +00:00
PASS if WebGL2RenderingContext is defined.