nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webaudio/audiobuffersource-not-gced-...

7 lines
159 B
Plaintext
Raw Permalink Normal View History

AudioScheduledSourceNodes leak if they have an attached onended EventTarget https://bugs.webkit.org/show_bug.cgi?id=204087 Source/WebCore: <rdar://problem/56772102> Reviewed by Jer Noble. Previously, if an AudioNode had any attributes that were event targets we would leak the node as long as the AudioContext was alive. This patch makes all the AudioNodes with EventTarget attributes subclasses of ActiveDOMObject. For, AudioScheduledSourceNodes we will mark the node as non-active when either the node becomes eligible for deletion from the graph or the onended event fires. For, ScriptProcessorNodes we mark the node as non-active when the node becomes eligible for deletion. Tests: webaudio/finished-audio-buffer-source-nodes-should-be-collectable.html webaudio/audiobuffersource-not-gced-until-ended.html * Modules/webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::startLater): (WebCore::AudioBufferSourceNode::start): Deleted. * Modules/webaudio/AudioBufferSourceNode.h: * Modules/webaudio/AudioBufferSourceNode.idl: * Modules/webaudio/AudioContext.h: * Modules/webaudio/AudioNode.cpp: (WebCore::AudioNode::deref): (WebCore::AudioNode::finishDeref): * Modules/webaudio/AudioNode.h: (WebCore::AudioNode::didBecomeMarkedForDeletion): * Modules/webaudio/AudioNode.idl: * Modules/webaudio/AudioScheduledSourceNode.cpp: (WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode): (WebCore::AudioScheduledSourceNode::startLater): (WebCore::AudioScheduledSourceNode::stopLater): (WebCore::AudioScheduledSourceNode::didBecomeMarkedForDeletion): (WebCore::AudioScheduledSourceNode::finish): (WebCore::AudioScheduledSourceNode::start): Deleted. (WebCore::AudioScheduledSourceNode::stop): Deleted. (WebCore::AudioScheduledSourceNode::addEventListener): Deleted. (WebCore::AudioScheduledSourceNode::removeEventListener): Deleted. (WebCore::AudioScheduledSourceNode::removeAllEventListeners): Deleted. * Modules/webaudio/AudioScheduledSourceNode.h: * Modules/webaudio/OscillatorNode.h: * Modules/webaudio/OscillatorNode.idl: * Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::ScriptProcessorNode): (WebCore::ScriptProcessorNode::~ScriptProcessorNode): (WebCore::ScriptProcessorNode::didBecomeMarkedForDeletion): (WebCore::ScriptProcessorNode::process): (WebCore::ScriptProcessorNode::addEventListener): Deleted. (WebCore::ScriptProcessorNode::removeEventListener): Deleted. (WebCore::ScriptProcessorNode::removeAllEventListeners): Deleted. * Modules/webaudio/ScriptProcessorNode.h: * Modules/webaudio/ScriptProcessorNode.idl: * Sources.txt: * bindings/js/JSAudioNodeCustom.cpp: Removed. LayoutTests: Reviewed by Jer Noble. * webaudio/audiobuffersource-not-gced-until-ended-expected.txt: Added. * webaudio/audiobuffersource-not-gced-until-ended.html: Added. * webaudio/finished-audio-buffer-source-nodes-should-be-collectable-expected.txt: Added. * webaudio/finished-audio-buffer-source-nodes-should-be-collectable.html: Added. Canonical link: https://commits.webkit.org/217434@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-11-13 02:07:30 +00:00
Tests that AudioBufferSourceNode calls its onended EventListener, even after a GC.
PASS source.onended called.
PASS successfullyParsed is true
TEST COMPLETE