nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webarchive/loading/video-in-webarchive.html

10 lines
240 B
HTML
Raw Permalink Normal View History

REGRESSION: Crash in MainResourceLoader::setDataBufferingPolicy when sharing an html5 video via email https://bugs.webkit.org/show_bug.cgi?id=110075 Reviewed by Alexey Proskuryakov. Source/WebCore: Test: webarchive/loading/video-in-webarchive.html * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): isStopping() isn't accurate to determine whether a SubstituteData load should continue, as this point in the code shouldn't be reachable from any point where isStopping() would return true. DocumentLoader might have completely stopped and believe that MainResourceLoader is complete, though. Don't continue in that case. (WebCore::MainResourceLoader::setDataBufferingPolicy): m_resource can be null in a reasonable case, handle it rather than asserting that it can't be null. LayoutTests: * webarchive/loading/resources/video-in-webarchive.webarchive: Added. * webarchive/loading/video-in-webarchive-expected.txt: Added. * webarchive/loading/video-in-webarchive.html: Added. Canonical link: https://commits.webkit.org/128776@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-21 19:19:00 +00:00
<script>
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
Further restricting webarchive loads https://bugs.webkit.org/show_bug.cgi?id=194567 <rdar://problem/47610130> Reviewed by Youenn Fablet. Source/WebCore: This patch futher restricts main frame webarchive loads to the followings: 1) loaded by clients; 2) loaded by drag; 3) reloaded from any of the previous two. It moves setAlwaysAllowLocalWebarchive, which is used for testing only, from Document to FrameLoader such that the option is remembered during redirections. Covered by API tests. * dom/Document.h: (WebCore::Document::setAlwaysAllowLocalWebarchive): Deleted. (WebCore::Document::alwaysAllowLocalWebarchive const): Deleted. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::disallowWebArchive const): * loader/DocumentLoader.h: (WebCore::DocumentLoader::setAllowsWebArchiveForMainFrame): (WebCore::DocumentLoader::allowsWebArchiveForMainFrame): * loader/FrameLoadRequest.h: (WebCore::FrameLoadRequest::setIsRequestFromClientOrUserInput): (WebCore::FrameLoadRequest::isRequestFromClientOrUserInput): * loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::reload): * loader/FrameLoader.h: (WebCore::FrameLoader::setAlwaysAllowLocalWebarchive): (WebCore::FrameLoader::alwaysAllowLocalWebarchive const): * page/DragController.cpp: (WebCore::DragController::performDragOperation): * testing/Internals.cpp: (WebCore::Internals::setAlwaysAllowLocalWebarchive const): * testing/Internals.h: * testing/Internals.idl: Source/WebKit: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadRequest): Set a flag to indicate a load is started from clients. Tools: Besides adding API tests, this patch also enhances DragAndDropSimulator to allow navigations on drop. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added. (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]): (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]): (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added. * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added. * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added. * TestWebKitAPI/cocoa/DragAndDropSimulator.h: * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: (-[DragAndDropSimulator initWithWebViewFrame:configuration:]): (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]): LayoutTests: * platform/mac/fast/loader/webarchive-encoding-respected.html: * webarchive/loading/cache-expired-subresource.html: * webarchive/loading/javascript-url-iframe-crash.html: * webarchive/loading/mainresource-null-mimetype-crash.html: * webarchive/loading/missing-data.html: * webarchive/loading/object.html: * webarchive/loading/test-loading-archive-subresource-null-mimetype.html: * webarchive/loading/test-loading-archive-subresource.html: * webarchive/loading/test-loading-archive.html: * webarchive/loading/test-loading-top-archive.html: * webarchive/loading/video-in-webarchive.html: Canonical link: https://commits.webkit.org/209026@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-02-13 23:07:13 +00:00
if (window.internals)
internals.setAlwaysAllowLocalWebarchive(true);
REGRESSION: Crash in MainResourceLoader::setDataBufferingPolicy when sharing an html5 video via email https://bugs.webkit.org/show_bug.cgi?id=110075 Reviewed by Alexey Proskuryakov. Source/WebCore: Test: webarchive/loading/video-in-webarchive.html * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): isStopping() isn't accurate to determine whether a SubstituteData load should continue, as this point in the code shouldn't be reachable from any point where isStopping() would return true. DocumentLoader might have completely stopped and believe that MainResourceLoader is complete, though. Don't continue in that case. (WebCore::MainResourceLoader::setDataBufferingPolicy): m_resource can be null in a reasonable case, handle it rather than asserting that it can't be null. LayoutTests: * webarchive/loading/resources/video-in-webarchive.webarchive: Added. * webarchive/loading/video-in-webarchive-expected.txt: Added. * webarchive/loading/video-in-webarchive.html: Added. Canonical link: https://commits.webkit.org/128776@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-21 19:19:00 +00:00
window.location="resources/video-in-webarchive.webarchive";
</script>