This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
webanimations
/
setting-css-animation-none-...
4 lines
90 B
Plaintext
Raw
Permalink
Normal View
History
Unescape
Escape
[Web Animations] Crash when setting "animation: none" after clearing an animation's effect https://bugs.webkit.org/show_bug.cgi?id=187952 Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/setting-css-animation-none-after-clearing-effect.html We need to ensure that the animation we're trying to remove has not had its effect cleared via the Web Animations API since its creation before trying to check its phase. * animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation): LayoutTests: Add a new test that checks that setting "animation: none" on an element that previously had a valid CSS animation and for which the effect was set to null does not crash. * webanimations/setting-css-animation-none-after-clearing-effect-expected.txt: Added. * webanimations/setting-css-animation-none-after-clearing-effect.html: Added. Canonical link: https://commits.webkit.org/203139@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-07-24 19:30:36 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Setting a CSS Animation to 'none' after setting its effect to null does not crash.
[Web Animations] Crash when setting "animation: none" after clearing an animation's effect https://bugs.webkit.org/show_bug.cgi?id=187952 Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/setting-css-animation-none-after-clearing-effect.html We need to ensure that the animation we're trying to remove has not had its effect cleared via the Web Animations API since its creation before trying to check its phase. * animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation): LayoutTests: Add a new test that checks that setting "animation: none" on an element that previously had a valid CSS animation and for which the effect was set to null does not crash. * webanimations/setting-css-animation-none-after-clearing-effect-expected.txt: Added. * webanimations/setting-css-animation-none-after-clearing-effect.html: Added. Canonical link: https://commits.webkit.org/203139@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-07-24 19:30:36 +00:00