This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
webanimations
/
empty-keyframes-crash-expec...
2 lines
1 B
Raw
Permalink
Normal View
History
Unescape
Escape
Ensure timingFunctionForKeyframeAtIndex() can be used from setAnimatedPropertiesInStyle(). https://bugs.webkit.org/show_bug.cgi?id=187637 <rdar://problem/42157915> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/empty-keyframes-crash.html Unlike what we assumed, it is possible to have a non-declarative animation without any parsed keyframes. This can happen as a result of calling `Element.animate({}, …)`. In this case, we want to return a null value in timingFunctionForKeyframeAtIndex() so we update the call site in setAnimatedPropertiesInStyle() which is the only place where we didn't check for a null value and didn't know for sure that there would be parsed keyframes to rely on in the case of a WebAnimation instance. * animation/KeyframeEffectReadOnly.cpp: (WebCore::KeyframeEffectReadOnly::setAnimatedPropertiesInStyle): (WebCore::KeyframeEffectReadOnly::timingFunctionForKeyframeAtIndex): LayoutTests: Add a new test that would crash prior to this change. * webanimations/empty-keyframes-crash-expected.txt: Added. * webanimations/empty-keyframes-crash.html: Added. Canonical link: https://commits.webkit.org/202948@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-07-18 01:05:29 +00:00