This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
webanimations
/
css-animation-effect-target...
2 lines
2 B
HTML
Raw
Permalink
Normal View
History
Unescape
Escape
[Web Animations] Crash under `KeyframeEffect::getKeyframes` for a `DeclarativeAnimation` https://bugs.webkit.org/show_bug.cgi?id=209682 <rdar://problem/60962458> Reviewed by Antoine Quint. Source/WebCore: Test: webanimations/css-animation-effect-target-change-and-get-keyframes-crash.html * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::getKeyframes): * inspector/agents/InspectorAnimationAgent.cpp: (WebCore::buildObjectForKeyframes): With the flexibility of the Web Animations API, it's possible for a `DeclarativeAnimation` to not have a `target`. As such, we should not expect it to exist, and should remove any `ASSERT` or unchecked dereferences. * animation/WebAnimation.cpp: (WebCore::WebAnimation::effectTimingDidChange): Drive-by: ensure that `InspectorInstrumentation` is called last. LayoutTests: * webanimations/css-animation-effect-target-change-and-get-keyframes-crash.html: Added. * webanimations/css-animation-effect-target-change-and-get-keyframes-crash-expected.html: Added. Canonical link: https://commits.webkit.org/222670@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-03-30 17:15:12 +00:00