nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webanimations/accessing-current-time-afte...

4 lines
52 B
Plaintext
Raw Permalink Normal View History

[Web Animations] Crash accessing CSSAnimation::bindingsCurrentTime when effect has been set to null https://bugs.webkit.org/show_bug.cgi?id=187950 <rdar://problem/42515747> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/accessing-current-time-after-clearing-css-animation-effect.html While a CSSAnimation has an effect created for it by the implementation, the developer may yet manipulate its effect via the Web Animations API and set it to null. As such, we must not assume it's always non-null. * animation/CSSAnimation.cpp: (WebCore::CSSAnimation::bindingsCurrentTime const): LayoutTests: Add a new test where we check that the current time of a CSSAnimation can be accessed after setting its effect to null. * webanimations/accessing-current-time-after-clearing-css-animation-effect-expected.txt: Added. * webanimations/accessing-current-time-after-clearing-css-animation-effect.html: Added. Canonical link: https://commits.webkit.org/203138@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-07-24 19:28:41 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Current time is 0 after removing its effect.
[Web Animations] Crash accessing CSSAnimation::bindingsCurrentTime when effect has been set to null https://bugs.webkit.org/show_bug.cgi?id=187950 <rdar://problem/42515747> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/accessing-current-time-after-clearing-css-animation-effect.html While a CSSAnimation has an effect created for it by the implementation, the developer may yet manipulate its effect via the Web Animations API and set it to null. As such, we must not assume it's always non-null. * animation/CSSAnimation.cpp: (WebCore::CSSAnimation::bindingsCurrentTime const): LayoutTests: Add a new test where we check that the current time of a CSSAnimation can be accessed after setting its effect to null. * webanimations/accessing-current-time-after-clearing-css-animation-effect-expected.txt: Added. * webanimations/accessing-current-time-after-clearing-css-animation-effect.html: Added. Canonical link: https://commits.webkit.org/203138@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-07-24 19:28:41 +00:00