This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
webanimations
/
accelerated-animation-suspe...
4 lines
74 B
Plaintext
Raw
Permalink
Normal View
History
Unescape
Escape
[Web Animations] Accelerated animations don't get suspended https://bugs.webkit.org/show_bug.cgi?id=189783 <rdar://problem/43033568> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/accelerated-animation-suspension.html We used to set the flag that marked the timeline as suspended prior to notifying animations that they need to be suspended. However, since the timeline was marked as suspended, querying the running state of the animations would indicate that the animations weren't running since a suspended timeline would identify its animations as not running. As such we would fail to pause the accelerated animations because they were already not marked as running. We now set the suspended flag on the timeline _after_ suspending its animations. We also fix a bug in the new internals.acceleratedAnimationsForElement() test function so that we read from the actual CA animations and not from a stale list of animations which would not indicate the correct animation speeds. * animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::suspendAnimations): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::acceleratedAnimationsForTesting): LayoutTests: Add a new test that checks whether an accelerated animation is correctly paused after suspending animations. * webanimations/accelerated-animation-suspension-expected.txt: Added. * webanimations/accelerated-animation-suspension.html: Added. * platform/win/TestExpectations: Canonical link: https://commits.webkit.org/204781@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-09-21 13:09:45 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Suspending animations should pause running accelerated animations.
[Web Animations] Accelerated animations don't get suspended https://bugs.webkit.org/show_bug.cgi?id=189783 <rdar://problem/43033568> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/accelerated-animation-suspension.html We used to set the flag that marked the timeline as suspended prior to notifying animations that they need to be suspended. However, since the timeline was marked as suspended, querying the running state of the animations would indicate that the animations weren't running since a suspended timeline would identify its animations as not running. As such we would fail to pause the accelerated animations because they were already not marked as running. We now set the suspended flag on the timeline _after_ suspending its animations. We also fix a bug in the new internals.acceleratedAnimationsForElement() test function so that we read from the actual CA animations and not from a stale list of animations which would not indicate the correct animation speeds. * animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::suspendAnimations): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::acceleratedAnimationsForTesting): LayoutTests: Add a new test that checks whether an accelerated animation is correctly paused after suspending animations. * webanimations/accelerated-animation-suspension-expected.txt: Added. * webanimations/accelerated-animation-suspension.html: Added. * platform/win/TestExpectations: Canonical link: https://commits.webkit.org/204781@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-09-21 13:09:45 +00:00