nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/webanimations/accelerated-animation-singl...

4 lines
87 B
Plaintext
Raw Permalink Normal View History

[Web Animations] Animation with a single keyframe is not accelerated https://bugs.webkit.org/show_bug.cgi?id=188730 <rdar://problem/43481113> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/accelerated-animation-single-keyframe.html Prior to attempting to run an accelerated effect, ensure that the KeyframeList passed to RenderLayerModelObject::startAnimation() does not have implicit keyframes since eventually GraphicsLayerCA::animationCanBeAccelerated() would be called and would reject a single-keyframe animation. To do this, we use the same code used in Style::Resolver::keyframeStylesForAnimation() which we refactor in the new KeyframeList::fillImplicitKeyframes() method. * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::copyPropertiesFromSource): (WebCore::KeyframeEffect::applyPendingAcceleratedActions): * rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::hasImplicitKeyframes const): (WebCore::KeyframeList::copyKeyframes): (WebCore::zeroPercentKeyframe): (WebCore::hundredPercentKeyframe): (WebCore::KeyframeList::fillImplicitKeyframes): * rendering/style/KeyframeList.h: * style/StyleResolver.cpp: (WebCore::Style::Resolver::keyframeStylesForAnimation): LayoutTests: Add a new test that runs a single-keyframe transform animation and checks that it runs accelerated. * webanimations/accelerated-animation-single-keyframe-expected.txt: Added. * webanimations/accelerated-animation-single-keyframe.html: Added. Canonical link: https://commits.webkit.org/224849@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-15 20:07:26 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS A transform animation with a single keyframe should be able to run accelerated.
[Web Animations] Animation with a single keyframe is not accelerated https://bugs.webkit.org/show_bug.cgi?id=188730 <rdar://problem/43481113> Reviewed by Dean Jackson. Source/WebCore: Test: webanimations/accelerated-animation-single-keyframe.html Prior to attempting to run an accelerated effect, ensure that the KeyframeList passed to RenderLayerModelObject::startAnimation() does not have implicit keyframes since eventually GraphicsLayerCA::animationCanBeAccelerated() would be called and would reject a single-keyframe animation. To do this, we use the same code used in Style::Resolver::keyframeStylesForAnimation() which we refactor in the new KeyframeList::fillImplicitKeyframes() method. * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::copyPropertiesFromSource): (WebCore::KeyframeEffect::applyPendingAcceleratedActions): * rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::hasImplicitKeyframes const): (WebCore::KeyframeList::copyKeyframes): (WebCore::zeroPercentKeyframe): (WebCore::hundredPercentKeyframe): (WebCore::KeyframeList::fillImplicitKeyframes): * rendering/style/KeyframeList.h: * style/StyleResolver.cpp: (WebCore::Style::Resolver::keyframeStylesForAnimation): LayoutTests: Add a new test that runs a single-keyframe transform animation and checks that it runs accelerated. * webanimations/accelerated-animation-single-keyframe-expected.txt: Added. * webanimations/accelerated-animation-single-keyframe.html: Added. Canonical link: https://commits.webkit.org/224849@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-15 20:07:26 +00:00