nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/transitions/visited-link-color-expected...

16 lines
1.0 KiB
Plaintext
Raw Permalink Normal View History

https://bugs.webkit.org/show_bug.cgi?id=73954 REGRESSION (r97745): Transitions don't work on links Source/WebCore: Reviewed by Andreas Kling. Test: transitions/visited-link-color.html Since visited link colors are now part of the RenderStyle, they need to be transitioned along with the corresponding regular colors. * page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor): (WebCore::PropertyWrapperVisitedAffectedColor::equals): (WebCore::PropertyWrapperVisitedAffectedColor::blend): (WebCore::AnimationBase::ensurePropertyMap): Add new wrapper class that applies both regular and visited color. * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::visitedLinkColor): (WebCore::InheritedFlags::visitedLinkBackgroundColor): (WebCore::InheritedFlags::visitedLinkBorderLeftColor): (WebCore::InheritedFlags::visitedLinkBorderRightColor): (WebCore::InheritedFlags::visitedLinkBorderBottomColor): (WebCore::InheritedFlags::visitedLinkBorderTopColor): (WebCore::InheritedFlags::visitedLinkOutlineColor): (WebCore::InheritedFlags::visitedLinkColumnRuleColor): (WebCore::InheritedFlags::visitedLinkTextEmphasisColor): (WebCore::InheritedFlags::visitedLinkTextFillColor): (WebCore::InheritedFlags::visitedLinkTextStrokeColor): Add accessors. * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Opportunistic fix. Don't know how to test. LayoutTests: Reviewed by Andreas Kling. Unfortunately the automatic test provides code coverage only as reading back the properties from the style always gives back non-visited values. The bug is visible running the test manually. * transitions/visited-link-color-expected.txt: Added. * transitions/visited-link-color.html: Added. Canonical link: https://commits.webkit.org/91556@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-12-18 23:47:15 +00:00
All the colors of the link below should be animating:
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
link
https://bugs.webkit.org/show_bug.cgi?id=73954 REGRESSION (r97745): Transitions don't work on links Source/WebCore: Reviewed by Andreas Kling. Test: transitions/visited-link-color.html Since visited link colors are now part of the RenderStyle, they need to be transitioned along with the corresponding regular colors. * page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor): (WebCore::PropertyWrapperVisitedAffectedColor::equals): (WebCore::PropertyWrapperVisitedAffectedColor::blend): (WebCore::AnimationBase::ensurePropertyMap): Add new wrapper class that applies both regular and visited color. * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::visitedLinkColor): (WebCore::InheritedFlags::visitedLinkBackgroundColor): (WebCore::InheritedFlags::visitedLinkBorderLeftColor): (WebCore::InheritedFlags::visitedLinkBorderRightColor): (WebCore::InheritedFlags::visitedLinkBorderBottomColor): (WebCore::InheritedFlags::visitedLinkBorderTopColor): (WebCore::InheritedFlags::visitedLinkOutlineColor): (WebCore::InheritedFlags::visitedLinkColumnRuleColor): (WebCore::InheritedFlags::visitedLinkTextEmphasisColor): (WebCore::InheritedFlags::visitedLinkTextFillColor): (WebCore::InheritedFlags::visitedLinkTextStrokeColor): Add accessors. * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Opportunistic fix. Don't know how to test. LayoutTests: Reviewed by Andreas Kling. Unfortunately the automatic test provides code coverage only as reading back the properties from the style always gives back non-visited values. The bug is visible running the test manually. * transitions/visited-link-color-expected.txt: Added. * transitions/visited-link-color.html: Added. Canonical link: https://commits.webkit.org/91556@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-12-18 23:47:15 +00:00
PASS - "color" property for "link" element at 0.5s saw something close to: 127,127,0
PASS - "background-color" property for "link" element at 0.5s saw something close to: 0,127,127
PASS - "border-left-color" property for "link" element at 0.5s saw something close to: 127,0,127
PASS - "border-right-color" property for "link" element at 0.5s saw something close to: 127,0,127
PASS - "border-top-color" property for "link" element at 0.5s saw something close to: 127,0,127
PASS - "border-bottom-color" property for "link" element at 0.5s saw something close to: 127,0,127
PASS - "outline-color" property for "link" element at 0.5s saw something close to: 127,127,0
PASS - "-webkit-column-rule-color" property for "link" element at 0.5s saw something close to: 127,127,0
PASS - "-webkit-text-stroke-color" property for "link" element at 0.5s saw something close to: 127,127,0
PASS - "-webkit-text-fill-color" property for "link" element at 0.5s saw something close to: 0,127,127