nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/transitions/transitions-parsing.html

753 lines
35 KiB
HTML
Raw Permalink Normal View History

Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
<!DOCTYPE html>
<html>
<head>
Change LayoutTests' t* files to use pre and post js files in LayoutTests/resources. https://bugs.webkit.org/show_bug.cgi?id=120899. Rubber stamped by Filip Pizlo. * touchadjustment/big-div.html: * touchadjustment/block-testing.html: * touchadjustment/context-menu-select-text.html: * touchadjustment/context-menu-shadow-node.html: * touchadjustment/context-menu-text-subtargets.html: * touchadjustment/context-menu.html: * touchadjustment/disabled-formelements.html: * touchadjustment/editable-content.html: * touchadjustment/event-triggered-widgets.html: * touchadjustment/html-label.html: * touchadjustment/iframe.html: * touchadjustment/nested-shadow-node.html: * touchadjustment/nested-touch.html: * touchadjustment/plugin.html: * touchadjustment/rotated-node.html: * touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html: * touchadjustment/scroll-offset.html: * touchadjustment/search-cancel.html: * touchadjustment/small-target-test.html: * touchadjustment/touch-inlines.html: * touchadjustment/touch-links-active.html: * touchadjustment/touch-links-longpress.html: * touchadjustment/touch-links-two-finger-tap.html: * touchadjustment/zoom-basic.html: * touchadjustment/zoom-fatfinger.html: * transforms/2d/computed-style-origin.html: * transforms/2d/transform-value-types.html: * transforms/cssmatrix-2d-interface.xhtml: * transforms/cssmatrix-3d-interface.xhtml: * transitions/transition-end-event-create.html: * transitions/transition-end-event-prefixed-01.html: * transitions/transition-end-event-prefixed-02.html: * transitions/transition-end-event-prefixed-03.html: * transitions/transitions-parsing.html: * traversal/acid3-test-2.html: * traversal/exception-forwarding.html: * traversal/script-tests/TEMPLATE.html: Canonical link: https://commits.webkit.org/138889@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-09-08 05:47:54 +00:00
<script src="../resources/js-test-pre.js"></script>
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
</head>
<body>
<script>
description("Test the parsing and the computed style values of the transitions properties.")
var testContainer = document.createElement("div");
document.body.appendChild(testContainer);
testContainer.innerHTML = '<div style="width:500px;height:500px"><div id="test">hello</div></div>';
e = document.getElementById('test');
style = e.style;
computedStyle = window.getComputedStyle(e, null);
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
// This function checks the return value of computedStyle.transition and verifies WebKit can parse it.
function checkTransitionShorthandValue() {
var before = computedStyle.getPropertyValue('transition');
e.style.transition = '';
e.style.transition = before;
return (computedStyle.getPropertyValue('transition') == before);
}
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Valid transition-property values.");
// Initial test.
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "none";
shouldBe("style.transitionProperty", "'none'");
shouldBe("computedStyle.transitionProperty", "'none'");
shouldBe("style.webkitTransitionProperty", "'none'");
shouldBe("computedStyle.webkitTransitionProperty", "'none'");
style.transitionProperty = "all";
shouldBe("style.transitionProperty", "'all'");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "'all'");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
transition-property property and transition shorthand property doesn't accept "all, all". https://bugs.webkit.org/show_bug.cgi?id=111201 Reviewed by Simon Fraser. Source/WebCore: Relax the parsing of transition-property to allow all, all as a value. It is not very useful per say but it is possible by the spec and we align with Firefox, IE and Opera. Test: LayoutTests/transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationProperty): LayoutTests: Updated the tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/129689@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-03-04 18:49:29 +00:00
style.transitionProperty = "all, all";
shouldBe("style.transitionProperty", "'all, all'");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "'all, all'");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionProperty = "background-position";
shouldBe("style.transitionProperty", "'background-position'");
shouldBe("computedStyle.transitionProperty", "'background-position'");
shouldBe("style.webkitTransitionProperty", "'background-position'");
shouldBe("computedStyle.webkitTransitionProperty", "'background-position'");
style.transitionProperty = "background-position, font-size";
shouldBe("style.transitionProperty", "'background-position, font-size'");
shouldBe("computedStyle.transitionProperty", "'background-position, font-size'");
shouldBe("style.webkitTransitionProperty", "'background-position, font-size'");
shouldBe("computedStyle.webkitTransitionProperty", "'background-position, font-size'");
style.transitionProperty = "background-position, font-size, color";
shouldBe("style.transitionProperty", "'background-position, font-size, color'");
shouldBe("computedStyle.transitionProperty", "'background-position, font-size, color'");
shouldBe("style.webkitTransitionProperty", "'background-position, font-size, color'");
shouldBe("computedStyle.webkitTransitionProperty", "'background-position, font-size, color'");
transition-property property doesn't accept "all, <IDENT>". https://bugs.webkit.org/show_bug.cgi?id=110074 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-property-property allows all, <IDENT> as a value for the transition-property property. In fact thanks to http://trac.webkit.org/changeset/143019 we correctly implemented that behavior for transition shorthand property while fixing bugs on the previous implementation. We did introduce a AnimationParseContext to track whether the parsing of the transition-property was finished or not in relation to the keyword. This patch extend that mechanism to the longhand by renaming the boolean and the functions to use it in the context class and set it correctly while parsing the longhand property. Test: LayoutTests/transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitAnimationPropertyKeyword): (WebCore::AnimationParseContext::animationPropertyKeywordAllowed): (AnimationParseContext): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): We can remove the condition inShorthand() here, if 'none' is parsed then no more keyword can appear, if 'all' is parsed then we can continue the parsing but invalidate the property if another keyword is encountered. These conditions are valid for the shorthand and the longhand. LayoutTests: Extend exising test to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/129058@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-25 18:56:19 +00:00
style.transitionProperty = "all, font-size, color";
shouldBe("style.transitionProperty", "'all, font-size, color'");
shouldBe("computedStyle.transitionProperty", "'all, font-size, color'");
shouldBe("style.webkitTransitionProperty", "'all, font-size, color'");
shouldBe("computedStyle.webkitTransitionProperty", "'all, font-size, color'");
style.transitionProperty = "font-size, color, all";
shouldBe("style.transitionProperty", "'font-size, color, all'");
shouldBe("computedStyle.transitionProperty", "'font-size, color, all'");
shouldBe("style.webkitTransitionProperty", "'font-size, color, all'");
shouldBe("computedStyle.webkitTransitionProperty", "'font-size, color, all'");
style.transitionProperty = "font-size, all, color";
shouldBe("style.transitionProperty", "'font-size, all, color'");
shouldBe("computedStyle.transitionProperty", "'font-size, all, color'");
shouldBe("style.webkitTransitionProperty", "'font-size, all, color'");
shouldBe("computedStyle.webkitTransitionProperty", "'font-size, all, color'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Invalid transition-property values.");
style.transitionProperty = "";
style.transitionProperty = "solid, font-size";
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.transitionProperty", "'solid, font-size'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.transitionProperty", "'solid, font-size'");
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.webkitTransitionProperty", "'solid, font-size'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.webkitTransitionProperty", "'solid, font-size'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionProperty = "solid, left";
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.transitionProperty", "'solid, left'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.transitionProperty", "'solid, left'");
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.webkitTransitionProperty", "'solid, left'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.webkitTransitionProperty", "'solid, left'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionProperty = "solid";
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.transitionProperty", "'solid'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.transitionProperty", "'solid'");
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.webkitTransitionProperty", "'solid'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.webkitTransitionProperty", "'solid'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
style.transitionProperty = '';
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionProperty = "20px";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "0";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "'font-size'";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "all none";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "opacity width";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
transition-property accepts incorrect "all, none" as value https://bugs.webkit.org/show_bug.cgi?id=105428 Reviewed by Dean Jackson. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-property-property disallows any value like none, all or all, none as it doesn't make sense. This patch fixes the problem by rejecting the value if set by the user. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: LayoutTests: Extend the existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/125896@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-23 19:27:38 +00:00
style.transitionProperty = "all, none";
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
transition-property accepts incorrect "all, none" as value https://bugs.webkit.org/show_bug.cgi?id=105428 Reviewed by Dean Jackson. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-property-property disallows any value like none, all or all, none as it doesn't make sense. This patch fixes the problem by rejecting the value if set by the user. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: LayoutTests: Extend the existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/125896@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-23 19:27:38 +00:00
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "none, none";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "none, all";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "width, none";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
style.transitionProperty = "none, width";
shouldBe("style.transitionProperty", "''");
shouldBe("computedStyle.transitionProperty", "'all'");
shouldBe("style.webkitTransitionProperty", "''");
shouldBe("computedStyle.webkitTransitionProperty", "'all'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionProperty = "";
debug("Valid transition-duration values.");
// Initial test.
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "0s";
shouldBe("style.transitionDuration", "'0s'");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "'0s'");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "5s";
shouldBe("style.transitionDuration", "'5s'");
shouldBe("computedStyle.transitionDuration", "'5s'");
shouldBe("style.webkitTransitionDuration", "'5s'");
shouldBe("computedStyle.webkitTransitionDuration", "'5s'");
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
style.transitionDuration = "10ms";
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.transitionDuration", "'10ms'");
shouldBe("computedStyle.transitionDuration", "'0.01s'");
shouldBe("style.webkitTransitionDuration", "'10ms'");
shouldBe("computedStyle.webkitTransitionDuration", "'0.01s'");
style.transitionProperty = "opacity, width";
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
style.transitionDuration = "10ms, 20s";
shouldBe("style.transitionDuration", "'10ms, 20s'");
shouldBe("computedStyle.transitionDuration", "'0.01s, 20s'");
shouldBe("style.webkitTransitionDuration", "'10ms, 20s'");
shouldBe("computedStyle.webkitTransitionDuration", "'0.01s, 20s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Invalid transition-duration values.");
style.transitionProperty = "opacity";
style.transitionDuration = "";
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
// Negative values are invalid.
style.transitionDuration = "-10ms";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionDuration = "'5ms'";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "30px";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "solid";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "20";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "20%";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
style.transitionDuration = "0s, 20px";
shouldBe("style.transitionDuration", "''");
shouldBe("computedStyle.transitionDuration", "'0s'");
shouldBe("style.webkitTransitionDuration", "''");
shouldBe("computedStyle.webkitTransitionDuration", "'0s'");
debug("Valid transition-timing-function values.");
// Initial test.
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
style.transitionTimingFunction = "linear";
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.transitionTimingFunction", "'linear'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'linear'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'linear'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'linear'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "ease";
shouldBe("style.transitionTimingFunction", "'ease'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'ease'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "ease-in";
shouldBe("style.transitionTimingFunction", "'ease-in'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease-in'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'ease-in'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease-in'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "ease-out";
shouldBe("style.transitionTimingFunction", "'ease-out'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease-out'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'ease-out'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease-out'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "ease-in-out";
shouldBe("style.transitionTimingFunction", "'ease-in-out'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease-in-out'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'ease-in-out'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease-in-out'");
style.transitionTimingFunction = "cubic-bezier(0.25, 0.1, 0.25, 1)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "cubic-bezier(0.1, 0, 0.23, 0.4)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 0.4)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 0.4)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 0.4)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 0.4)'");
Add tests to cover what transition-timing-function accepts for cubic-bezier values. https://bugs.webkit.org/show_bug.cgi?id=105426 Reviewed by Simon Fraser. http://www.w3.org/TR/css3-transitions/#transition-timing-function-property has not yet been updated following the discussions http://lists.w3.org/Archives/Public/www-style/2010Apr/0489.html and http://lists.w3.org/Archives/Public/www-style/2010Jun/0254.html where the range restriction of Y values for cubic-bezier type has been removed. This patch add tests to cover that behavior to avoid breakage in the future and test also various other different cubic-bezier use cases. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124200@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 19:05:44 +00:00
style.transitionTimingFunction = "cubic-bezier(0.1, 0, 0.23, 3)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
style.transitionTimingFunction = "cubic-bezier(0.1, 5, 0.23, 3)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
style.transitionTimingFunction = "cubic-bezier(0.1, 5, 0.23, 0)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
style.transitionTimingFunction = "cubic-bezier(0.2, 2, 0.2, -0.4)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
style.transitionTimingFunction = "cubic-bezier(0.2, -2, 0.2, 0.4)";
shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "step-start";
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
shouldBe("style.transitionTimingFunction", "'steps(1, start)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'steps(1, start)'");
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'steps(1, start)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(1, start)'");
style.transitionTimingFunction = "step-end";
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
shouldBe("style.transitionTimingFunction", "'steps(1)'");
shouldBe("computedStyle.transitionTimingFunction", "'steps(1)'");
shouldBe("style.webkitTransitionTimingFunction", "'steps(1)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(1)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "steps(3)";
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
shouldBe("style.transitionTimingFunction", "'steps(3)'");
shouldBe("computedStyle.transitionTimingFunction", "'steps(3)'");
shouldBe("style.webkitTransitionTimingFunction", "'steps(3)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(3)'");
style.transitionTimingFunction = "steps(4)";
shouldBe("style.transitionTimingFunction", "'steps(4)'");
shouldBe("computedStyle.transitionTimingFunction", "'steps(4)'");
shouldBe("style.webkitTransitionTimingFunction", "'steps(4)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(4)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "steps(5, start)";
shouldBe("style.transitionTimingFunction", "'steps(5, start)'");
shouldBe("computedStyle.transitionTimingFunction", "'steps(5, start)'");
shouldBe("style.webkitTransitionTimingFunction", "'steps(5, start)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(5, start)'");
Add support for the frames() timing function https://bugs.webkit.org/show_bug.cgi?id=181585 <rdar://problem/36463317> Reviewed by Dean. Source/WebCore: Implement the frames() timing function as specified in the CSS Timing Functions Level 1 specification, specifically https://www.w3.org/TR/css-timing-1/#frames-timing-functions. A frames timing function is a type of timing function that divides the input time into a specified number of intervals of equal length. Test: transitions/frames-timing-function.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSTimingFunctionValue.cpp: (WebCore::CSSFramesTimingFunctionValue::customCSSText const): (WebCore::CSSFramesTimingFunctionValue::equals const): * css/CSSTimingFunctionValue.h: * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSValue.cpp: (WebCore::CSSValue::equals const): (WebCore::CSSValue::cssText const): (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::isFramesTimingFunctionValue const): * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeFrames): (WebCore::consumeAnimationTimingFunction): * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime const): * platform/animation/TimingFunction.h: (WebCore::TimingFunction::isFramesTimingFunction const): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasFramesTimingFunction): (WebCore::GraphicsLayerCA::animationCanBeAccelerated const): Source/WebKit: Add the ability to endode and decode the frames() timing function. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<FramesTimingFunction>::encode): (IPC::ArgumentCoder<FramesTimingFunction>::decode): * Shared/WebCoreArgumentCoders.h: * WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode): LayoutTests: Add a new test that checks that the frames() timing function applies as expected and expand an existing test to check that the frames() timing function is parsed correctly. We also mark progressions in imported WPT tests. * imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt: * imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt: * transitions/frames-timing-function-expected.txt: Added. * transitions/frames-timing-function.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/197453@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-01-12 13:26:50 +00:00
style.transitionTimingFunction = "frames(2)";
shouldBe("style.transitionTimingFunction", "'frames(2)'");
shouldBe("computedStyle.transitionTimingFunction", "'frames(2)'");
shouldBe("style.webkitTransitionTimingFunction", "'frames(2)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'frames(2)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionProperty = "opacity, width";
style.transitionTimingFunction = "ease-in-out, ease-in";
shouldBe("style.transitionTimingFunction", "'ease-in-out, ease-in'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease-in-out, ease-in'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'ease-in-out, ease-in'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease-in-out, ease-in'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)";
shouldBe("style.transitionTimingFunction", "'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "steps(3, start), ease-in-out";
shouldBe("style.transitionTimingFunction", "'steps(3, start), ease-in-out'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'steps(3, start), ease-in-out'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "'steps(3, start), ease-in-out'");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(3, start), ease-in-out'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Invalid transition-timing-function values.");
style.transitionProperty = "";
style.transitionTimingFunction = "";
WebKit does not reject some cubic-bezier form values for transition-timing-function. https://bugs.webkit.org/show_bug.cgi?id=106369 Reviewed by Dean Jackson. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property describes restricitions on cubic-bezier values where the x values of the curve should be between [0, 1] and y values can exceed this range. WebKit was not following the specification by allowing x values exceeding the range. The spec also says that we should reject the defintion if the condition is not respected which is what the new code does. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationTimingFunction): LayoutTests: Extended existing tests to cover the bug. Updated an existing test which was checking wrong values. * fast/css/transition-timing-function.html: Change the tested values as they are considered wrong by the spec. * fast/css/transition-timing-function-expected.txt: Canonical link: https://commits.webkit.org/124562@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 21:44:22 +00:00
style.transitionTimingFunction = "cubic-bezier(3, 0.1, 4, 1)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
style.transitionTimingFunction = "cubic-bezier(1, 0.1, 3, 1)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
style.transitionTimingFunction = "cubic-bezier(0.1, 0, 4, 0.4)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
style.transitionTimingFunction = "cubic-bezier(3, 0, 4, 0.4)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
style.transitionTimingFunction = "cubic-bezier(3, 0, 0.2, 0.4)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
style.transitionTimingFunction = "cubic-bezier(-0.2, 0, 0.2, 0.4)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
style.transitionTimingFunction = "cubic-bezier(0.2, 2, -0.2, 0.4)";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "steps(5, 3)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "steps(-5, start)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "steps(5, start, end)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "step(5)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "red";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "cubic-bezier(0.25, 0.1, 0.25)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "cubic-bezier(0.25, 0.1, 0.25, 1, 2)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionTimingFunction = "cubic-foo(0.25, 0.1, 0.25, 1)";
shouldBe("style.transitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.transitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionTimingFunction", "''");
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Valid transition-delay values.");
// Initial test.
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "0s";
shouldBe("style.transitionDelay", "'0s'");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "'0s'");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "5s";
shouldBe("style.transitionDelay", "'5s'");
shouldBe("computedStyle.transitionDelay", "'5s'");
shouldBe("style.webkitTransitionDelay", "'5s'");
shouldBe("computedStyle.webkitTransitionDelay", "'5s'");
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
style.transitionDelay = "10ms";
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.transitionDelay", "'10ms'");
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
shouldBe("computedStyle.transitionDelay", "'0.01s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransitionDelay", "'10ms'");
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
shouldBe("computedStyle.webkitTransitionDelay", "'0.01s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transitionDelay = "-10ms";
shouldBe("style.transitionDelay", "'-10ms'");
shouldBe("computedStyle.transitionDelay", "'-0.01s'");
shouldBe("style.webkitTransitionDelay", "'-10ms'");
shouldBe("computedStyle.webkitTransitionDelay", "'-0.01s'");
style.transitionProperty = "opacity, width";
style.transitionDelay = "-10ms, 20s";
shouldBe("style.transitionDelay", "'-10ms, 20s'");
shouldBe("computedStyle.transitionDelay", "'-0.01s, 20s'");
shouldBe("style.webkitTransitionDelay", "'-10ms, 20s'");
transition-delay and transition-duration return incorrect values when querying using the computed style. https://bugs.webkit.org/show_bug.cgi?id=105432 Reviewed by Dean Jackson. Source/WebCore: When setting the transition-delay to 10ms for example the value of transition-delay on the computed style was incorrect, it should return 0.01s but it was returning something like 0.0099999999...s. In fact the bug was after the parsing step when creating the Animation object where a conversion from a double to float was done. This conversion is not needed as the animation class expects double for delay and transition times. Test: transitions/transitions-parsing.html * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationDelay): (WebCore::CSSToStyleMap::mapAnimationDuration): LayoutTests: Uncomment existing tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124526@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-08 18:08:02 +00:00
shouldBe("computedStyle.webkitTransitionDelay", "'-0.01s, 20s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Invalid transition-duration values.");
style.transitionProperty = "opacity";
style.transitionDelay = "";
style.transitionDelay = "'5ms'";
shouldBe("style.transitionDelay", "''");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "''");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "30px";
shouldBe("style.transitionDelay", "''");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "''");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "solid";
shouldBe("style.transitionDelay", "''");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "''");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "20";
shouldBe("style.transitionDelay", "''");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "''");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "20%";
shouldBe("style.transitionDelay", "''");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "''");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
style.transitionDelay = "0s, 20px";
shouldBe("style.transitionDelay", "''");
shouldBe("computedStyle.transitionDelay", "'0s'");
shouldBe("style.webkitTransitionDelay", "''");
shouldBe("computedStyle.webkitTransitionDelay", "'0s'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
debug("Valid transition shorthand values.");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "";
// Initial test.
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "none";
shouldBe("style.transition", "'none'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'none 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "'none'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'none 0s ease 0s'");
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "none 20s";
shouldBe("style.transition", "'none 20s'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'none 20s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "'none 20s'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'none 20s ease 0s'");
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "ease-in none 20s";
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("style.transition", "'none 20s ease-in'");
shouldBe("computedStyle.transition", "'none 20s ease-in 0s'");
shouldBe("style.webkitTransition", "'none 20s ease-in'");
shouldBe("computedStyle.webkitTransition", "'none 20s ease-in 0s'");
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "ease-in opacity 20s";
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("style.transition", "'opacity 20s ease-in'");
shouldBe("computedStyle.transition", "'opacity 20s ease-in 0s'");
shouldBe("style.webkitTransition", "'opacity 20s ease-in'");
shouldBe("computedStyle.webkitTransition", "'opacity 20s ease-in 0s'");
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "ease-in opacity 20s 10s";
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("style.transition", "'opacity 20s ease-in 10s'");
shouldBe("computedStyle.transition", "'opacity 20s ease-in 10s'");
shouldBe("style.webkitTransition", "'opacity 20s ease-in 10s'");
shouldBe("computedStyle.webkitTransition", "'opacity 20s ease-in 10s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
// Let's double check here the delay and duration. As stated in the spec the first value parsed
// is assigned to the duration.
shouldBe("computedStyle.transitionDuration", "'20s'");
shouldBe("computedStyle.webkitTransitionDuration", "'20s'");
shouldBe("computedStyle.transitionDelay", "'10s'");
shouldBe("computedStyle.webkitTransitionDelay", "'10s'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "20s ease-in opacity 10s";
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("style.transition", "'opacity 20s ease-in 10s'");
shouldBe("computedStyle.transition", "'opacity 20s ease-in 10s'");
shouldBe("style.webkitTransition", "'opacity 20s ease-in 10s'");
shouldBe("computedStyle.webkitTransition", "'opacity 20s ease-in 10s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("computedStyle.transitionDuration", "'20s'");
shouldBe("computedStyle.webkitTransitionDuration", "'20s'");
shouldBe("computedStyle.transitionDelay", "'10s'");
shouldBe("computedStyle.webkitTransitionDelay", "'10s'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "ease-in opacity 20s 10s, cubic-bezier(0.32, 0, 1, 1) 10s width 20s";
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("style.transition", "'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'");
shouldBe("computedStyle.transition", "'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'");
shouldBe("style.webkitTransition", "'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'");
shouldBe("computedStyle.webkitTransition", "'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
// Let's double check here the delay and duration. As stated in the spec the first value parsed
// is assigned to the duration.
shouldBe("computedStyle.transitionDuration", "'20s, 10s'");
shouldBe("computedStyle.webkitTransitionDuration", "'20s, 10s'");
shouldBe("computedStyle.transitionDelay", "'10s, 20s'");
shouldBe("computedStyle.webkitTransitionDelay", "'10s, 20s'");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
transition-property property and transition shorthand property doesn't accept "all, all". https://bugs.webkit.org/show_bug.cgi?id=111201 Reviewed by Simon Fraser. Source/WebCore: Relax the parsing of transition-property to allow all, all as a value. It is not very useful per say but it is possible by the spec and we align with Firefox, IE and Opera. Test: LayoutTests/transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationProperty): LayoutTests: Updated the tests to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/129689@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-03-04 18:49:29 +00:00
style.transition = "all, all";
shouldBe("style.transition", "'all, all'");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "'all, all'");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
style.transition = "all 20s 10s ease-in, all ease-out 20s";
shouldBe("style.transition", "'all 20s ease-in 10s, all 20s ease-out'");
shouldBe("computedStyle.transition", "'all 20s ease-out 0s'");
shouldBe("style.webkitTransition", "'all 20s ease-in 10s, all 20s ease-out'");
shouldBe("computedStyle.webkitTransition", "'all 20s ease-out 0s'");
WebKit shouldn't accept "none, none" in transition shorthand property. https://bugs.webkit.org/show_bug.cgi?id=108751 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property specifies that if there is more than one transition defined in the shorthand and any of them has a value of 'none' then the declaration is invalid. This patch fixes the problem by passing a parsing context to track if a keyword has been set for the transition-property and if so then use it to invalidate or not the declaration. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (AnimationParseContext): (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitFirstAnimation): track whether it's the first <single-transition/animation> or not defined in the shorthand. (WebCore::AnimationParseContext::hasCommittedFirstAnimation): (WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand): In the shorthand as soon as a keyword has been found then the parsing is 'finished', if any other animation/transition declaration part of the shorthand are with a keyword then it's invalid. (WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed): (WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword): (WebCore::AnimationParseContext::sawAnimationPropertyKeyword): (WebCore): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: (WebCore): LayoutTests: Extend exisiting tests to cover the bug. Modify old tests with invalid declarations. * fast/css/transform-inline-style-expected.txt: * fast/css/transform-inline-style-remove-expected.txt: * fast/css/transform-inline-style-remove.html: * fast/css/transform-inline-style.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/128234@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-15 19:06:30 +00:00
style.transition = "ease-in opacity 20s 10s, all ease-out 20s";
shouldBe("style.transition", "'opacity 20s ease-in 10s, all 20s ease-out'");
shouldBe("computedStyle.transition", "'opacity 20s ease-in 10s, all 20s ease-out 0s'");
shouldBe("style.webkitTransition", "'opacity 20s ease-in 10s, all 20s ease-out'");
shouldBe("computedStyle.webkitTransition", "'opacity 20s ease-in 10s, all 20s ease-out 0s'");
shouldBe("checkTransitionShorthandValue()", "true");
style.transition = " all ease-out 20s, ease-in opacity 20s 10s";
shouldBe("style.transition", "'all 20s ease-out, opacity 20s ease-in 10s'");
shouldBe("computedStyle.transition", "'all 20s ease-out 0s, opacity 20s ease-in 10s'");
shouldBe("style.webkitTransition", "'all 20s ease-out, opacity 20s ease-in 10s'");
shouldBe("computedStyle.webkitTransition", "'all 20s ease-out 0s, opacity 20s ease-in 10s'");
shouldBe("checkTransitionShorthandValue()", "true");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
debug("Invalid transition shorthand values.");
style.transition = "";
style.transition = "20";
shouldBe("style.transition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "20, 20";
shouldBe("style.transition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "widthFoo";
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.transition", "'widthFoo'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.transition", "'widthFoo 0s ease 0s'");
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
shouldBe("style.webkitTransition", "'widthFoo'");
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
shouldBe("computedStyle.webkitTransition", "'widthFoo 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
[CSS Parser] Unskip more tests https://bugs.webkit.org/show_bug.cgi?id=165602 Reviewed by Zalan Bujtas. * TestExpectations: * fast/css/remove-shorthand-expected.txt: * fast/css/transform-inline-style-expected.txt: * fast/regions/region-styling/parsing-region-style-rule.html: * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: * fast/shapes/parsing/parsing-shape-image-threshold.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: * svg/webarchive/svg-cursor-subresources.svg: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/183199@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 16:47:12 +00:00
style.transition = '';
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "all 30s width ease-in";
shouldBe("style.transition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "all 30s ease-in 20px";
shouldBe("style.transition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "all 30s ease-in 20s, 20px";
shouldBe("style.transition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
style.transition = "all 30s ease-in 20s, step-start(2)";
shouldBe("style.transition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
shouldBe("style.webkitTransition", "''");
Implement CSS computed style value for transition shorthand https://bugs.webkit.org/show_bug.cgi?id=105035 Reviewed by Dean Jackson. Source/WebCore: Implement support for query the transition and webkit-transition shorthand from the computed style. Test: transitions/transitions-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Factor the code to create the correct value into a function to reuse it for the shorthand. (WebCore::getTransitionPropertyValue): (WebCore::createTimingFunctionValue): Little refactor, the intermediate local variables are not needed. (WebCore::getTimingFunctionValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): LayoutTests: Uncomment existing tests to cover the new feature. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124649@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-09 18:04:04 +00:00
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
WebKit shouldn't accept "none, none" in transition shorthand property. https://bugs.webkit.org/show_bug.cgi?id=108751 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property specifies that if there is more than one transition defined in the shorthand and any of them has a value of 'none' then the declaration is invalid. This patch fixes the problem by passing a parsing context to track if a keyword has been set for the transition-property and if so then use it to invalidate or not the declaration. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (AnimationParseContext): (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitFirstAnimation): track whether it's the first <single-transition/animation> or not defined in the shorthand. (WebCore::AnimationParseContext::hasCommittedFirstAnimation): (WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand): In the shorthand as soon as a keyword has been found then the parsing is 'finished', if any other animation/transition declaration part of the shorthand are with a keyword then it's invalid. (WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed): (WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword): (WebCore::AnimationParseContext::sawAnimationPropertyKeyword): (WebCore): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: (WebCore): LayoutTests: Extend exisiting tests to cover the bug. Modify old tests with invalid declarations. * fast/css/transform-inline-style-expected.txt: * fast/css/transform-inline-style-remove-expected.txt: * fast/css/transform-inline-style-remove.html: * fast/css/transform-inline-style.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/128234@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-15 19:06:30 +00:00
style.transition = "ease-in opacity 20s 10s, none";
shouldBe("style.transition", "''");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "''");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
style.transition = "none, ease-in opacity 20s 10s, none";
shouldBe("style.transition", "''");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "''");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
style.transition = "none, ease-in opacity 20s 10s";
shouldBe("style.transition", "''");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "''");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
style.transition = "ease-in opacity 20s 10s, all 20s ease-out 0s, none";
shouldBe("style.transition", "''");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "''");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
style.transition = "ease-in opacity 20s 10s, ease-in width 20s 10s, none";
shouldBe("style.transition", "''");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "''");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
style.transition = "none, none";
shouldBe("style.transition", "''");
shouldBe("computedStyle.transition", "'all 0s ease 0s'");
shouldBe("style.webkitTransition", "''");
shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
document.body.removeChild(testContainer);
Add support for the frames() timing function https://bugs.webkit.org/show_bug.cgi?id=181585 <rdar://problem/36463317> Reviewed by Dean. Source/WebCore: Implement the frames() timing function as specified in the CSS Timing Functions Level 1 specification, specifically https://www.w3.org/TR/css-timing-1/#frames-timing-functions. A frames timing function is a type of timing function that divides the input time into a specified number of intervals of equal length. Test: transitions/frames-timing-function.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSTimingFunctionValue.cpp: (WebCore::CSSFramesTimingFunctionValue::customCSSText const): (WebCore::CSSFramesTimingFunctionValue::equals const): * css/CSSTimingFunctionValue.h: * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSValue.cpp: (WebCore::CSSValue::equals const): (WebCore::CSSValue::cssText const): (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::isFramesTimingFunctionValue const): * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeFrames): (WebCore::consumeAnimationTimingFunction): * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime const): * platform/animation/TimingFunction.h: (WebCore::TimingFunction::isFramesTimingFunction const): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasFramesTimingFunction): (WebCore::GraphicsLayerCA::animationCanBeAccelerated const): Source/WebKit: Add the ability to endode and decode the frames() timing function. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<FramesTimingFunction>::encode): (IPC::ArgumentCoder<FramesTimingFunction>::decode): * Shared/WebCoreArgumentCoders.h: * WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode): LayoutTests: Add a new test that checks that the frames() timing function applies as expected and expand an existing test to check that the frames() timing function is parsed correctly. We also mark progressions in imported WPT tests. * imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt: * imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt: * transitions/frames-timing-function-expected.txt: Added. * transitions/frames-timing-function.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/197453@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-01-12 13:26:50 +00:00
let framesInvalidElement;
[-10, 0, 1, 2.5, "", "eggs", NaN, new Array, {}].forEach(invalidValue => {
framesInvalidElement = document.body.appendChild(document.createElement("div"));
const value = `frames(${invalidValue})`;
debug("");
debug(`Testing frames() invalid values: ${value}`);
framesInvalidElement.style.transitionTimingFunction = value;
shouldBe("framesInvalidElement.style.transitionTimingFunction", "''");
shouldBe("getComputedStyle(framesInvalidElement).transitionTimingFunction", "'ease'");
shouldBe("framesInvalidElement.style.webkitTransitionTimingFunction", "''");
shouldBe("getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction", "'ease'");
framesInvalidElement.remove();
});
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
</script>
Change LayoutTests' t* files to use pre and post js files in LayoutTests/resources. https://bugs.webkit.org/show_bug.cgi?id=120899. Rubber stamped by Filip Pizlo. * touchadjustment/big-div.html: * touchadjustment/block-testing.html: * touchadjustment/context-menu-select-text.html: * touchadjustment/context-menu-shadow-node.html: * touchadjustment/context-menu-text-subtargets.html: * touchadjustment/context-menu.html: * touchadjustment/disabled-formelements.html: * touchadjustment/editable-content.html: * touchadjustment/event-triggered-widgets.html: * touchadjustment/html-label.html: * touchadjustment/iframe.html: * touchadjustment/nested-shadow-node.html: * touchadjustment/nested-touch.html: * touchadjustment/plugin.html: * touchadjustment/rotated-node.html: * touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html: * touchadjustment/scroll-offset.html: * touchadjustment/search-cancel.html: * touchadjustment/small-target-test.html: * touchadjustment/touch-inlines.html: * touchadjustment/touch-links-active.html: * touchadjustment/touch-links-longpress.html: * touchadjustment/touch-links-two-finger-tap.html: * touchadjustment/zoom-basic.html: * touchadjustment/zoom-fatfinger.html: * transforms/2d/computed-style-origin.html: * transforms/2d/transform-value-types.html: * transforms/cssmatrix-2d-interface.xhtml: * transforms/cssmatrix-3d-interface.xhtml: * transitions/transition-end-event-create.html: * transitions/transition-end-event-prefixed-01.html: * transitions/transition-end-event-prefixed-02.html: * transitions/transition-end-event-prefixed-03.html: * transitions/transitions-parsing.html: * traversal/acid3-test-2.html: * traversal/exception-forwarding.html: * traversal/script-tests/TEMPLATE.html: Canonical link: https://commits.webkit.org/138889@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-09-08 05:47:54 +00:00
<script src="../resources/js-test-post.js"></script>
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
</body>
</html>