haikuwebkit/LayoutTests/transitions/transitions-parsing-expecte...

521 lines
27 KiB
Plaintext
Raw Permalink Normal View History

Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Test the parsing and the computed style values of the transitions properties.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Valid transition-property values.
PASS computedStyle.transitionProperty is 'all'
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is 'none'
PASS computedStyle.transitionProperty is 'none'
PASS style.webkitTransitionProperty is 'none'
PASS computedStyle.webkitTransitionProperty is 'none'
PASS style.transitionProperty is 'all'
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is 'all'
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is 'all, all'
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is 'all, all'
PASS computedStyle.webkitTransitionProperty is 'all'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionProperty is 'background-position'
PASS computedStyle.transitionProperty is 'background-position'
PASS style.webkitTransitionProperty is 'background-position'
PASS computedStyle.webkitTransitionProperty is 'background-position'
PASS style.transitionProperty is 'background-position, font-size'
PASS computedStyle.transitionProperty is 'background-position, font-size'
PASS style.webkitTransitionProperty is 'background-position, font-size'
PASS computedStyle.webkitTransitionProperty is 'background-position, font-size'
PASS style.transitionProperty is 'background-position, font-size, color'
PASS computedStyle.transitionProperty is 'background-position, font-size, color'
PASS style.webkitTransitionProperty is 'background-position, font-size, color'
PASS computedStyle.webkitTransitionProperty is 'background-position, font-size, color'
transition-property property doesn't accept "all, <IDENT>". https://bugs.webkit.org/show_bug.cgi?id=110074 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-property-property allows all, <IDENT> as a value for the transition-property property. In fact thanks to http://trac.webkit.org/changeset/143019 we correctly implemented that behavior for transition shorthand property while fixing bugs on the previous implementation. We did introduce a AnimationParseContext to track whether the parsing of the transition-property was finished or not in relation to the keyword. This patch extend that mechanism to the longhand by renaming the boolean and the functions to use it in the context class and set it correctly while parsing the longhand property. Test: LayoutTests/transitions/transitions-parsing.html * css/CSSParser.cpp: (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitAnimationPropertyKeyword): (WebCore::AnimationParseContext::animationPropertyKeywordAllowed): (AnimationParseContext): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): We can remove the condition inShorthand() here, if 'none' is parsed then no more keyword can appear, if 'all' is parsed then we can continue the parsing but invalidate the property if another keyword is encountered. These conditions are valid for the shorthand and the longhand. LayoutTests: Extend exising test to cover the bug. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/129058@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-25 18:56:19 +00:00
PASS style.transitionProperty is 'all, font-size, color'
PASS computedStyle.transitionProperty is 'all, font-size, color'
PASS style.webkitTransitionProperty is 'all, font-size, color'
PASS computedStyle.webkitTransitionProperty is 'all, font-size, color'
PASS style.transitionProperty is 'font-size, color, all'
PASS computedStyle.transitionProperty is 'font-size, color, all'
PASS style.webkitTransitionProperty is 'font-size, color, all'
PASS computedStyle.webkitTransitionProperty is 'font-size, color, all'
PASS style.transitionProperty is 'font-size, all, color'
PASS computedStyle.transitionProperty is 'font-size, all, color'
PASS style.webkitTransitionProperty is 'font-size, all, color'
PASS computedStyle.webkitTransitionProperty is 'font-size, all, color'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Invalid transition-property values.
PASS style.transitionProperty is 'solid, font-size'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.transitionProperty is 'solid, font-size'
PASS style.webkitTransitionProperty is 'solid, font-size'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.webkitTransitionProperty is 'solid, font-size'
PASS style.transitionProperty is 'solid, left'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.transitionProperty is 'solid, left'
PASS style.webkitTransitionProperty is 'solid, left'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.webkitTransitionProperty is 'solid, left'
PASS style.transitionProperty is 'solid'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.transitionProperty is 'solid'
PASS style.webkitTransitionProperty is 'solid'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.webkitTransitionProperty is 'solid'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
PASS style.transitionProperty is ''
PASS computedStyle.transitionProperty is 'all'
PASS style.webkitTransitionProperty is ''
PASS computedStyle.webkitTransitionProperty is 'all'
Valid transition-duration values.
PASS computedStyle.transitionDuration is '0s'
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is '0s'
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is '0s'
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is '5s'
PASS computedStyle.transitionDuration is '5s'
PASS style.webkitTransitionDuration is '5s'
PASS computedStyle.webkitTransitionDuration is '5s'
PASS style.transitionDuration is '10ms'
PASS computedStyle.transitionDuration is '0.01s'
PASS style.webkitTransitionDuration is '10ms'
PASS computedStyle.webkitTransitionDuration is '0.01s'
PASS style.transitionDuration is '10ms, 20s'
PASS computedStyle.transitionDuration is '0.01s, 20s'
PASS style.webkitTransitionDuration is '10ms, 20s'
PASS computedStyle.webkitTransitionDuration is '0.01s, 20s'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Invalid transition-duration values.
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
PASS style.transitionDuration is ''
PASS computedStyle.transitionDuration is '0s'
PASS style.webkitTransitionDuration is ''
PASS computedStyle.webkitTransitionDuration is '0s'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Valid transition-timing-function values.
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is 'linear'
PASS computedStyle.transitionTimingFunction is 'linear'
PASS style.webkitTransitionTimingFunction is 'linear'
PASS computedStyle.webkitTransitionTimingFunction is 'linear'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'ease'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'ease'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'ease-in'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease-in'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'ease-in'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease-in'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'ease-out'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease-out'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'ease-out'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease-out'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'ease-in-out'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease-in-out'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'ease-in-out'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease-in-out'
PASS style.transitionTimingFunction is 'cubic-bezier(0.25, 0.1, 0.25, 1)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.25, 0.1, 0.25, 1)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.25, 0.1, 0.25, 1)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.25, 0.1, 0.25, 1)'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 0.4)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 0.4)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 0.4)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 0.4)'
PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
PASS style.transitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
PASS style.transitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
PASS style.transitionTimingFunction is 'steps(1, start)'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS computedStyle.transitionTimingFunction is 'steps(1, start)'
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
PASS style.webkitTransitionTimingFunction is 'steps(1, start)'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'steps(1, start)'
[CSS Easing 1] implement `jump-*` step positions https://bugs.webkit.org/show_bug.cgi?id=211271 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: * web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: * web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: * web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: Add support for `jump-start`, `jump-end`, `jump-none`, and `jump-both` step positions inside the `steps()` CSS timing function <https://drafts.csswg.org/css-easing-1/#step-position>. Adjust existing serialization logic to match the spec <https://drafts.csswg.org/css-easing-1/#serialization>: - omit `end` (and `jump-end`) - the value `step-start` should result in `steps(1, start)` instead of `step-start` - the value `step-end` should result in `steps(1)` instead of `step-end` Tests: animations/computed-style.html fast/css/animation-steps-calculated-value.html transitions/transitions-parsing.html web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html web-platform-tests/css/css-easing/step-timing-functions-output.html web-platform-tests/css/css-easing/step-timing-functions-syntax.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeAnimationTimingFunction): * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSTimingFunctionValue.h: (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::stepPosition const): Added. (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::stepAtStart const): Deleted. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSStepsTimingFunctionValue::customCSSText const): (WebCore::CSSStepsTimingFunctionValue::equals const): * platform/animation/TimingFunction.h: (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::StepsTimingFunction): (WebCore::StepsTimingFunction::stepPosition): Added. (WebCore::StepsTimingFunction::setStepPosition): Added. (WebCore::StepsTimingFunction::clone): (WebCore::StepsTimingFunction::stepAtStart): Deleted. (WebCore::StepsTimingFunction::setStepAtStart): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime): (WebCore::TimingFunction::createFromCSSValue): (WebCore::TimingFunction::cssText const): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forFunction): Include the step position keywords when autocompleting the `steps()` CSS function. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<StepsTimingFunction>::encode): (IPC::ArgumentCoder<StepsTimingFunction>::decode): LayoutTests: * animations/computed-style.html: * animations/computed-style-expected.txt: * fast/css/animation-steps-calculated-value.html: * fast/css/animation-steps-calculated-value-expected.txt: * transitions/transitions-parsing.html: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/224221@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-02 09:34:30 +00:00
PASS style.transitionTimingFunction is 'steps(1)'
PASS computedStyle.transitionTimingFunction is 'steps(1)'
PASS style.webkitTransitionTimingFunction is 'steps(1)'
PASS computedStyle.webkitTransitionTimingFunction is 'steps(1)'
PASS style.transitionTimingFunction is 'steps(3)'
PASS computedStyle.transitionTimingFunction is 'steps(3)'
PASS style.webkitTransitionTimingFunction is 'steps(3)'
PASS computedStyle.webkitTransitionTimingFunction is 'steps(3)'
PASS style.transitionTimingFunction is 'steps(4)'
PASS computedStyle.transitionTimingFunction is 'steps(4)'
PASS style.webkitTransitionTimingFunction is 'steps(4)'
PASS computedStyle.webkitTransitionTimingFunction is 'steps(4)'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'steps(5, start)'
PASS computedStyle.transitionTimingFunction is 'steps(5, start)'
PASS style.webkitTransitionTimingFunction is 'steps(5, start)'
PASS computedStyle.webkitTransitionTimingFunction is 'steps(5, start)'
Remove the frames() timing function https://bugs.webkit.org/show_bug.cgi?id=190034 <rdar://problem/44827544> Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt: * web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt: * web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt: * web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt: * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Source/WebCore: * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSTimingFunctionValue.cpp: (WebCore::CSSFramesTimingFunctionValue::customCSSText const): Deleted. (WebCore::CSSFramesTimingFunctionValue::equals const): Deleted. * css/CSSTimingFunctionValue.h: * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSValue.cpp: (WebCore::CSSValue::equals const): (WebCore::CSSValue::cssText const): (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::isStepsTimingFunctionValue const): (WebCore::CSSValue::isFramesTimingFunctionValue const): Deleted. * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeAnimationTimingFunction): (WebCore::consumeFrames): Deleted. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime const): (WebCore::TimingFunction::createFromCSSValue): * platform/animation/TimingFunction.h: (WebCore::TimingFunction::isStepsTimingFunction const): (WebCore::TimingFunction::isFramesTimingFunction const): Deleted. * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::animationCanBeAccelerated const): (WebCore::animationHasFramesTimingFunction): Deleted. Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<FramesTimingFunction>::encode): Deleted. (IPC::ArgumentCoder<FramesTimingFunction>::decode): Deleted. * Shared/WebCoreArgumentCoders.h: * WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode): LayoutTests: * legacy-animation-engine/transitions/frames-timing-function-expected.txt: * legacy-animation-engine/transitions/transitions-parsing-expected.txt: * transitions/frames-timing-function-expected.txt: * transitions/transitions-parsing-expected.txt: Canonical link: https://commits.webkit.org/205379@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-10-10 06:55:24 +00:00
FAIL style.transitionTimingFunction should be frames(2). Was steps(5, start).
FAIL computedStyle.transitionTimingFunction should be frames(2). Was steps(5, start).
FAIL style.webkitTransitionTimingFunction should be frames(2). Was steps(5, start).
FAIL computedStyle.webkitTransitionTimingFunction should be frames(2). Was steps(5, start).
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'ease-in-out, ease-in'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease-in-out, ease-in'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'ease-in-out, ease-in'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease-in-out, ease-in'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease-in-out, cubic-bezier(0.1, 0, 0.23, 0.4)'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is 'steps(3, start), ease-in-out'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'steps(3, start), ease-in-out'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is 'steps(3, start), ease-in-out'
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'steps(3, start), ease-in-out'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Invalid transition-timing-function values.
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
PASS computedStyle.transitionTimingFunction is 'ease'
PASS style.webkitTransitionTimingFunction is ''
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.transitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.transitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS style.webkitTransitionTimingFunction is ''
Querying transition-timing-function value on the computed style does not return keywords when it should. https://bugs.webkit.org/show_bug.cgi?id=105442 Reviewed by Simon Fraser. Source/WebCore: http://www.w3.org/TR/css3-transitions/#transition-timing-function-property contains a set of predefined timing functions which under the hood are implemented using cubic-bezier but it's an implementation detail that should not be exposed. It seems to be more clear to return a CSS keyword rather than the cubic-bezier form when querying the value of the property on the computed style. In fact the spec even say that for example the initial value is "ease" and not cubic-bezier(0.25, 0.1, 0.25, 1.0). We could also imagine that in the future these predefined values could contain other values not represented by a cubic-bezier form. This behavior also align with the "linear" keyword which return "linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0). Test: transitions/transitions-parsing.html has been updated to cover the new behavior as well as making sure that an explicitly set value of cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the cubic-bezier() form. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createAnimationValue): (WebCore): (WebCore::getTimingFunctionValue): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the preset value of the timing function if it is one when creating it so we can use it later from the computed style. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): Source/WebKit2: Update the code to pass the animations from one process to another as the constructor of TimingFunction changed to take an extra parameter holding the type of the cubic-bezier form. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::encodeTimingFunction): (CoreIPC::decodeTimingFunction): LayoutTests: Update the tests to match the correct behavior of returning a keyword rather than a cubic-bezier() form when using predefined values for the transition-timing-function property. * animations/animation-shorthand-name-order-expected.txt: * animations/animation-shorthand-name-order.html: * animations/animation-shorthand-removed.html: * animations/animation-shorthand.html: * animations/computed-style-expected.txt: * animations/computed-style.html: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * transitions/inherit-other-props-expected.txt: * transitions/inherit-other-props.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/124207@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-01-03 20:22:47 +00:00
PASS computedStyle.webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Valid transition-delay values.
PASS computedStyle.transitionDelay is '0s'
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is '0s'
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is '0s'
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is '5s'
PASS computedStyle.transitionDelay is '5s'
PASS style.webkitTransitionDelay is '5s'
PASS computedStyle.webkitTransitionDelay is '5s'
PASS style.transitionDelay is '10ms'
PASS computedStyle.transitionDelay is '0.01s'
PASS style.webkitTransitionDelay is '10ms'
PASS computedStyle.webkitTransitionDelay is '0.01s'
PASS style.transitionDelay is '-10ms'
PASS computedStyle.transitionDelay is '-0.01s'
PASS style.webkitTransitionDelay is '-10ms'
PASS computedStyle.webkitTransitionDelay is '-0.01s'
PASS style.transitionDelay is '-10ms, 20s'
PASS computedStyle.transitionDelay is '-0.01s, 20s'
PASS style.webkitTransitionDelay is '-10ms, 20s'
PASS computedStyle.webkitTransitionDelay is '-0.01s, 20s'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
Invalid transition-duration values.
PASS style.transitionDelay is ''
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is ''
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is ''
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is ''
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is ''
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is ''
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is ''
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is ''
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is ''
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is ''
PASS computedStyle.webkitTransitionDelay is '0s'
PASS style.transitionDelay is ''
PASS computedStyle.transitionDelay is '0s'
PASS style.webkitTransitionDelay is ''
PASS computedStyle.webkitTransitionDelay is '0s'
Valid transition shorthand values.
PASS computedStyle.transition is 'all 0s ease 0s'
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is 'none'
PASS computedStyle.transition is 'none 0s ease 0s'
PASS style.webkitTransition is 'none'
PASS computedStyle.webkitTransition is 'none 0s ease 0s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'none 20s'
PASS computedStyle.transition is 'none 20s ease 0s'
PASS style.webkitTransition is 'none 20s'
PASS computedStyle.webkitTransition is 'none 20s ease 0s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'none 20s ease-in'
PASS computedStyle.transition is 'none 20s ease-in 0s'
PASS style.webkitTransition is 'none 20s ease-in'
PASS computedStyle.webkitTransition is 'none 20s ease-in 0s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'opacity 20s ease-in'
PASS computedStyle.transition is 'opacity 20s ease-in 0s'
PASS style.webkitTransition is 'opacity 20s ease-in'
PASS computedStyle.webkitTransition is 'opacity 20s ease-in 0s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'opacity 20s ease-in 10s'
PASS computedStyle.transition is 'opacity 20s ease-in 10s'
PASS style.webkitTransition is 'opacity 20s ease-in 10s'
PASS computedStyle.webkitTransition is 'opacity 20s ease-in 10s'
PASS computedStyle.transitionDuration is '20s'
PASS computedStyle.webkitTransitionDuration is '20s'
PASS computedStyle.transitionDelay is '10s'
PASS computedStyle.webkitTransitionDelay is '10s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'opacity 20s ease-in 10s'
PASS computedStyle.transition is 'opacity 20s ease-in 10s'
PASS style.webkitTransition is 'opacity 20s ease-in 10s'
PASS computedStyle.webkitTransition is 'opacity 20s ease-in 10s'
PASS computedStyle.transitionDuration is '20s'
PASS computedStyle.webkitTransitionDuration is '20s'
PASS computedStyle.transitionDelay is '10s'
PASS computedStyle.webkitTransitionDelay is '10s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'
PASS computedStyle.transition is 'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'
PASS style.webkitTransition is 'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'
PASS computedStyle.webkitTransition is 'opacity 20s ease-in 10s, width 10s cubic-bezier(0.32, 0, 1, 1) 20s'
PASS computedStyle.transitionDuration is '20s, 10s'
PASS computedStyle.webkitTransitionDuration is '20s, 10s'
PASS computedStyle.transitionDelay is '10s, 20s'
PASS computedStyle.webkitTransitionDelay is '10s, 20s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'all, all'
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is 'all, all'
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is 'all 20s ease-in 10s, all 20s ease-out'
PASS computedStyle.transition is 'all 20s ease-out 0s'
PASS style.webkitTransition is 'all 20s ease-in 10s, all 20s ease-out'
PASS computedStyle.webkitTransition is 'all 20s ease-out 0s'
WebKit shouldn't accept "none, none" in transition shorthand property. https://bugs.webkit.org/show_bug.cgi?id=108751 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property specifies that if there is more than one transition defined in the shorthand and any of them has a value of 'none' then the declaration is invalid. This patch fixes the problem by passing a parsing context to track if a keyword has been set for the transition-property and if so then use it to invalidate or not the declaration. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (AnimationParseContext): (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitFirstAnimation): track whether it's the first <single-transition/animation> or not defined in the shorthand. (WebCore::AnimationParseContext::hasCommittedFirstAnimation): (WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand): In the shorthand as soon as a keyword has been found then the parsing is 'finished', if any other animation/transition declaration part of the shorthand are with a keyword then it's invalid. (WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed): (WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword): (WebCore::AnimationParseContext::sawAnimationPropertyKeyword): (WebCore): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: (WebCore): LayoutTests: Extend exisiting tests to cover the bug. Modify old tests with invalid declarations. * fast/css/transform-inline-style-expected.txt: * fast/css/transform-inline-style-remove-expected.txt: * fast/css/transform-inline-style-remove.html: * fast/css/transform-inline-style.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/128234@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-15 19:06:30 +00:00
PASS style.transition is 'opacity 20s ease-in 10s, all 20s ease-out'
PASS computedStyle.transition is 'opacity 20s ease-in 10s, all 20s ease-out 0s'
PASS style.webkitTransition is 'opacity 20s ease-in 10s, all 20s ease-out'
PASS computedStyle.webkitTransition is 'opacity 20s ease-in 10s, all 20s ease-out 0s'
PASS checkTransitionShorthandValue() is true
PASS style.transition is 'all 20s ease-out, opacity 20s ease-in 10s'
PASS computedStyle.transition is 'all 20s ease-out 0s, opacity 20s ease-in 10s'
PASS style.webkitTransition is 'all 20s ease-out, opacity 20s ease-in 10s'
PASS computedStyle.webkitTransition is 'all 20s ease-out 0s, opacity 20s ease-in 10s'
PASS checkTransitionShorthandValue() is true
Invalid transition shorthand values.
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
WebKit shouldn't accept "none, none" in transition shorthand property. https://bugs.webkit.org/show_bug.cgi?id=108751 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property specifies that if there is more than one transition defined in the shorthand and any of them has a value of 'none' then the declaration is invalid. This patch fixes the problem by passing a parsing context to track if a keyword has been set for the transition-property and if so then use it to invalidate or not the declaration. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (AnimationParseContext): (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitFirstAnimation): track whether it's the first <single-transition/animation> or not defined in the shorthand. (WebCore::AnimationParseContext::hasCommittedFirstAnimation): (WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand): In the shorthand as soon as a keyword has been found then the parsing is 'finished', if any other animation/transition declaration part of the shorthand are with a keyword then it's invalid. (WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed): (WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword): (WebCore::AnimationParseContext::sawAnimationPropertyKeyword): (WebCore): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: (WebCore): LayoutTests: Extend exisiting tests to cover the bug. Modify old tests with invalid declarations. * fast/css/transform-inline-style-expected.txt: * fast/css/transform-inline-style-remove-expected.txt: * fast/css/transform-inline-style-remove.html: * fast/css/transform-inline-style.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/128234@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-15 19:06:30 +00:00
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is 'widthFoo'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.transition is 'widthFoo 0s ease 0s'
PASS style.webkitTransition is 'widthFoo'
REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned https://bugs.webkit.org/show_bug.cgi?id=171250 <rdar://problem/31827243> Reviewed by Geoffrey Garen. Source/WebCore: We were mapping unknown properties to 'all' animation. With this patch we ignore them instead. The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko. Test: transitions/transition-unknown-property-ignore.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTransitionPropertyValue): Return the correct name for unknown properties. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationProperty): Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll. Save the unknown property name so we can roundtrip it properly. * page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): Ignore AnimateUnknownProperty like AnimateNone. * platform/animation/Animation.h: (WebCore::Animation::unknownProperty): (WebCore::Animation::setUnknownProperty): LayoutTests: * transitions/transition-unknown-property-ignore-expected.txt: Added. * transitions/transition-unknown-property-ignore.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko. Canonical link: https://commits.webkit.org/188584@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-05-04 20:16:01 +00:00
PASS computedStyle.webkitTransition is 'widthFoo 0s ease 0s'
WebKit shouldn't accept "none, none" in transition shorthand property. https://bugs.webkit.org/show_bug.cgi?id=108751 Reviewed by Dean Jackson. Source/WebCore: http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property specifies that if there is more than one transition defined in the shorthand and any of them has a value of 'none' then the declaration is invalid. This patch fixes the problem by passing a parsing context to track if a keyword has been set for the transition-property and if so then use it to invalidate or not the declaration. Test: transitions/transitions-parsing.html * css/CSSParser.cpp: (AnimationParseContext): (WebCore::AnimationParseContext::AnimationParseContext): (WebCore::AnimationParseContext::commitFirstAnimation): track whether it's the first <single-transition/animation> or not defined in the shorthand. (WebCore::AnimationParseContext::hasCommittedFirstAnimation): (WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand): In the shorthand as soon as a keyword has been found then the parsing is 'finished', if any other animation/transition declaration part of the shorthand are with a keyword then it's invalid. (WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed): (WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword): (WebCore::AnimationParseContext::sawAnimationPropertyKeyword): (WebCore): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: (WebCore): LayoutTests: Extend exisiting tests to cover the bug. Modify old tests with invalid declarations. * fast/css/transform-inline-style-expected.txt: * fast/css/transform-inline-style-remove-expected.txt: * fast/css/transform-inline-style-remove.html: * fast/css/transform-inline-style.html: * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/128234@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-02-15 19:06:30 +00:00
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
PASS style.transition is ''
PASS computedStyle.transition is 'all 0s ease 0s'
PASS style.webkitTransition is ''
PASS computedStyle.webkitTransition is 'all 0s ease 0s'
Add support for the frames() timing function https://bugs.webkit.org/show_bug.cgi?id=181585 <rdar://problem/36463317> Reviewed by Dean. Source/WebCore: Implement the frames() timing function as specified in the CSS Timing Functions Level 1 specification, specifically https://www.w3.org/TR/css-timing-1/#frames-timing-functions. A frames timing function is a type of timing function that divides the input time into a specified number of intervals of equal length. Test: transitions/frames-timing-function.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): * css/CSSTimingFunctionValue.cpp: (WebCore::CSSFramesTimingFunctionValue::customCSSText const): (WebCore::CSSFramesTimingFunctionValue::equals const): * css/CSSTimingFunctionValue.h: * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSValue.cpp: (WebCore::CSSValue::equals const): (WebCore::CSSValue::cssText const): (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::isFramesTimingFunctionValue const): * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeSteps): (WebCore::consumeFrames): (WebCore::consumeAnimationTimingFunction): * platform/animation/TimingFunction.cpp: (WebCore::operator<<): (WebCore::TimingFunction::transformTime const): * platform/animation/TimingFunction.h: (WebCore::TimingFunction::isFramesTimingFunction const): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasFramesTimingFunction): (WebCore::GraphicsLayerCA::animationCanBeAccelerated const): Source/WebKit: Add the ability to endode and decode the frames() timing function. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<FramesTimingFunction>::encode): (IPC::ArgumentCoder<FramesTimingFunction>::decode): * Shared/WebCoreArgumentCoders.h: * WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode): LayoutTests: Add a new test that checks that the frames() timing function applies as expected and expand an existing test to check that the frames() timing function is parsed correctly. We also mark progressions in imported WPT tests. * imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt: * imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt: * transitions/frames-timing-function-expected.txt: Added. * transitions/frames-timing-function.html: Added. * transitions/transitions-parsing-expected.txt: * transitions/transitions-parsing.html: Canonical link: https://commits.webkit.org/197453@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-01-12 13:26:50 +00:00
Testing frames() invalid values: frames(-10)
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames(0)
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames(1)
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames(2.5)
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames()
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames(eggs)
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames(NaN)
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames()
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Testing frames() invalid values: frames([object Object])
PASS framesInvalidElement.style.transitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).transitionTimingFunction is 'ease'
PASS framesInvalidElement.style.webkitTransitionTimingFunction is ''
PASS getComputedStyle(framesInvalidElement).webkitTransitionTimingFunction is 'ease'
Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. .: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: * configure.ac: Source/JavaScriptCore: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. Test: transitions/transitions-parsing.html * Configurations/FeatureDefines.xcconfig: * GNUmakefile.am: * GNUmakefile.features.am.in: * css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions. Source/WebKit/chromium: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * features.gypi: Source/WebKit/mac: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: Tools: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: WebKitLibraries: Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: LayoutTests: Add new tests to cover the unprefixed version as well as the prefixed version of the properties. It only covers the parsing and the computed style values. * transitions/transitions-parsing.html: Added. Canonical link: https://commits.webkit.org/123683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-12-19 19:35:57 +00:00
PASS successfullyParsed is true
TEST COMPLETE