haikuwebkit/LayoutTests/svg/dynamic-updates/SVGFESpecularLightingElemen...

12 lines
261 B
Plaintext
Raw Permalink Normal View History

2011-02-25 Renata Hodovan <reni@webkit.org> Reviewed by Nikolas Zimmermann. FESpecularLightingElement changes doesn't require relayout. https://bugs.webkit.org/show_bug.cgi?id=54451 When the FESpecularLightingElement receives an update message but the given value remains the same we don't need to relayout the filter. Otherwise, the light source requests a repaint on the specular lighting filter. Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null. No new tests are needed to check the repaint because it is covered by the dynamic update tests of FESpecularLighting. We only test what happens if we remove the light source of specularLight. Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html * platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setSurfaceScale): (WebCore::FESpecularLighting::setSpecularConstant): (WebCore::FESpecularLighting::setSpecularExponent): (WebCore::FESpecularLighting::setKernelUnitLengthX): (WebCore::FESpecularLighting::setKernelUnitLengthY): * platform/graphics/filters/FESpecularLighting.h: * rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource): * svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute): (WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged): (WebCore::SVGFEDiffuseLightingElement::build): * svg/SVGFEDiffuseLightingElement.h: * svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::findLightElement): (WebCore::SVGFELightElement::findLight): (WebCore::SVGFELightElement::svgAttributeChanged): * svg/SVGFELightElement.h: * svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute): (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): (WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged): (WebCore::SVGFESpecularLightingElement::build): * svg/SVGFESpecularLightingElement.h: 2011-02-25 Renata Hodovan <reni@webkit.org> Reviewed by Nikolas Zimmermann. FESpecularLightingElement changes doesn't require relayout. https://bugs.webkit.org/show_bug.cgi?id=54451 Test what happens if we remove the light source of specularLight. * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.checksum: Added. * platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added. * svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.txt: Added. * svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html: Added. * svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-remove-lightSource.js: Added. (executeTest): Canonical link: https://commits.webkit.org/69593@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-02-25 12:59:58 +00:00
SVG 1.1 dynamic update tests
Tests dynamic updates of the SVGFESpecularLightingElement object when removing its light source.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS successfullyParsed is true
TEST COMPLETE