haikuwebkit/LayoutTests/svg/dom/SVGAnimatedNumberList-expec...

28 lines
1.1 KiB
Plaintext
Raw Permalink Normal View History

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Rob Buis. Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept https://bugs.webkit.org/show_bug.cgi?id=48686 Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept. Tests: svg/dom/SVGAnimatedNumber.html svg/dom/SVGAnimatedNumberList.html svg/dom/SVGNumber.html * GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash. * bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now. * bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace. * bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now. * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling. * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. * svg/SVGAnimatedNumber.h: Added. * svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking. * svg/SVGAnimatedNumberList.h: Added. * svg/SVGAnimatedNumberList.idl: Ditto. * svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction): * svg/SVGComponentTransferFunctionElement.h: * svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build): * svg/SVGFEColorMatrixElement.h: * svg/SVGFECompositeElement.h: Ditto. * svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build): * svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto. * svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFEDisplacementMapElement.h: Ditto. * svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto. * svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFELightElement.h: Ditto. * svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto. * svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFEOffsetElement.h: Ditto. * svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto. * svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto. * svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto. * svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker. * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto. * svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking. * svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString): * svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList): * svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGStopElement.h: Ditto. * svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute): * svg/SVGTextPositioningElement.h: Ditto. * svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling. 2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Rob Buis. Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept https://bugs.webkit.org/show_bug.cgi?id=48686 Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList. Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed) * platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: * platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: * svg/dom/SVGAnimatedNumber-expected.txt: Added. * svg/dom/SVGAnimatedNumber.html: Added. * svg/dom/SVGAnimatedNumberList-expected.txt: Added. * svg/dom/SVGAnimatedNumberList.html: Added. * svg/dom/SVGNumber-expected.txt: Added. * svg/dom/SVGNumber.html: Added. * svg/dom/script-tests/SVGAnimatedNumber.js: Added. * svg/dom/script-tests/SVGAnimatedNumberList.js: Added. * svg/dom/script-tests/SVGNumber.js: Added. * svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled. * svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list. * svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js: Canonical link: https://commits.webkit.org/61477@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-30 13:23:55 +00:00
This test checks the SVGAnimatedNumberList API - utilizing the rotate property of SVGTextElement
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Check initial rotate value
PASS textElement.rotate.toString() is "[object SVGAnimatedNumberList]"
PASS textElement.rotate.baseVal.toString() is "[object SVGNumberList]"
PASS textElement.rotate.baseVal.getItem(0).value is 50
Check that number lists are dynamic, caching value in a local variable and modifying it, should take effect
PASS numRef.getItem(0).value is 100
PASS textElement.rotate.baseVal.getItem(0).value is 100
2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Rob Buis. Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff https://bugs.webkit.org/show_bug.cgi?id=48715 Enable StrictTypeChecking for all readwrite attributes and function calls of all types using the new SVG(Animated)PropertyTearOff concept. Also enable RequiresAllArguments=Raise for all function calls of these new types. Cover this functionality by tests for each of them. When testing SVGLength it became obvious that quite a lot of functionality was missing. Conversion from relative arguments (percentage, ems, exs) to user specified units was missing, added that functionality and tested it. User units to pt conversion was wrong, fixed that. Tests: svg/dom/SVGAnimatedAngle.html svg/dom/SVGAnimatedBoolean.html svg/dom/SVGAnimatedEnumeration.html svg/dom/SVGAnimatedInteger.html svg/dom/SVGAnimatedLength.html svg/dom/SVGAnimatedLengthList.html svg/dom/SVGAnimatedRect.html svg/dom/SVGLength-px-with-context.html svg/dom/SVGLength-px.html svg/dom/SVGLength.html * bindings/js/JSSVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits): * bindings/scripts/CodeGeneratorObjC.pm: Remove FIXMEs, pass real context instead off null pointer. DOMSVGLength::value is functional now. * bindings/v8/custom/V8SVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): * rendering/style/SVGRenderStyle.h: Adapt to SVGLength API changes. (WebCore::SVGRenderStyle::initialBaselineShiftValue): (WebCore::SVGRenderStyle::initialKerning): (WebCore::SVGRenderStyle::initialStrokeDashOffset): (WebCore::SVGRenderStyle::initialStrokeWidth): * svg/SVGAngle.idl: Add StrictTypeChecking, RequiresAllArguments=Raise to all methods. * svg/SVGAnimatedBoolean.idl: Remove StrictTypeChecking from animVal, it's readonly so this is useless. * svg/SVGAnimatedEnumeration.idl: Add StrictTypeChecking to all attributes. * svg/SVGAnimatedInteger.idl: Ditto. * svg/SVGLength.cpp: Implement all missing features of SVGLength. Conform to our style guide (s/.0f// etc) (WebCore::lengthTypeToString): (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): Throw NOT_SUPPORTED_ERR when trying to obtain to relative units, when no context is given (SVGLength created by createSVGLength()). (WebCore::SVGLength::setValue): Ditto, for the setter. (WebCore::SVGLength::valueAsPercentage): Use m_valueInSpecifiedUnits instead of valueInSpecifiedUnits(). (WebCore::SVGLength::setValueAsString): Throw SYNTAX_ERR if parsing failed. (WebCore::SVGLength::valueAsString): Use makeString() instead of String and operator+. (WebCore::SVGLength::newValueSpecifiedUnits): Add ExceptionCode parameter, throw NOT_SUPPORTED_ERR, if the given unit type is invalid. (WebCore::SVGLength::convertToSpecifiedUnits): Ditto. (WebCore::SVGLength::determineViewport): Added helper function used by convertValue*Percentage*. (WebCore::SVGLength::convertValueFromUserUnitsToPercentage): Add new helper functions, used by value/setValue. (WebCore::SVGLength::convertValueFromPercentageToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEMS): Ditto. (WebCore::SVGLength::convertValueFromEMSToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): Ditto. (WebCore::SVGLength::convertValueFromEXSToUserUnits): Ditto. (WebCore::SVGLength::fromCSSPrimitiveValue): Adapt to newValueSpecifiedUnits API change. (WebCore::SVGLength::toCSSPrimitiveValue): Remove default switch case. * svg/SVGLength.h: (WebCore::SVGLength::valueInSpecifiedUnits): Inlined. (WebCore::SVGLength::setValueInSpecifiedUnits): Ditto. (WebCore::SVGLength::isRelative): * svg/SVGLength.idl: Add StrictTypeChecking for all attributes/functions and RequiresAllArguments=Raise for all functions. * svg/SVGLengthList.cpp: Adapt to SVGLength API changes. (WebCore::SVGLengthList::parse): 2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Rob Buis. Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff https://bugs.webkit.org/show_bug.cgi?id=48715 * svg/dom/SVGAngle-expected.txt: * svg/dom/SVGAnimatedAngle-expected.txt: Added. * svg/dom/SVGAnimatedAngle.html: Added. * svg/dom/SVGAnimatedBoolean-expected.txt: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired-expected.txt. * svg/dom/SVGAnimatedBoolean.html: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired.html. * svg/dom/SVGAnimatedEnumeration-expected.txt: Added. * svg/dom/SVGAnimatedEnumeration.html: Added. * svg/dom/SVGAnimatedInteger-expected.txt: Added. * svg/dom/SVGAnimatedInteger.html: Added. * svg/dom/SVGAnimatedLength-expected.txt: Added. * svg/dom/SVGAnimatedLength.html: Added. * svg/dom/SVGAnimatedLengthList-expected.txt: Added. * svg/dom/SVGAnimatedLengthList.html: Added. * svg/dom/SVGAnimatedRect-expected.txt: Added. * svg/dom/SVGAnimatedRect.html: Added. * svg/dom/SVGExternalResourcesRequired-expected.txt: Removed. * svg/dom/SVGExternalResourcesRequired.html: Removed. * svg/dom/SVGLength-expected.txt: Added. * svg/dom/SVGLength-px-expected.txt: Added. * svg/dom/SVGLength-px-with-context-expected.txt: Added. * svg/dom/SVGLength-px-with-context.html: Added. * svg/dom/SVGLength-px.html: Added. * svg/dom/SVGLength.html: Added. * svg/dom/script-tests/SVGAngle.js: * svg/dom/script-tests/SVGAnimatedAngle.js: Added. * svg/dom/script-tests/SVGAnimatedBoolean.js: Copied from LayoutTests/svg/dom/script-tests/SVGExternalResourcesRequired.js. * svg/dom/script-tests/SVGAnimatedEnumeration.js: Added. * svg/dom/script-tests/SVGAnimatedInteger.js: Added. * svg/dom/script-tests/SVGAnimatedLength.js: Added. * svg/dom/script-tests/SVGAnimatedLengthList.js: Added. * svg/dom/script-tests/SVGAnimatedRect.js: Added. * svg/dom/script-tests/SVGExternalResourcesRequired.js: Removed. * svg/dom/script-tests/SVGLength-px-with-context.js: Added. Tests various operations on a SVGLength object obtained via rectElement.x.baseVal. * svg/dom/script-tests/SVGLength-px.js: Added. Tests various operations on a SVGLength object created via svgElement.createSVGLength(). * svg/dom/script-tests/SVGLength.js: Added. * svg/dom/svg-length-units-expected.txt: Removed. * svg/dom/svg-length-units.html: Removed. Test is obsolete now, as SVGLength* covers this in detail. * svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js: (executeTest): Fixed StrictTypeChecking correctness, don't assign strings as SVGLength value. * svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js: (executeTest): Ditto. * svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js: (executeTest): Ditto. Canonical link: https://commits.webkit.org/61512@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-11-01 08:57:11 +00:00
Check that assigning to baseVal has no effect, as no setter is defined
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Rob Buis. Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept https://bugs.webkit.org/show_bug.cgi?id=48686 Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept. Tests: svg/dom/SVGAnimatedNumber.html svg/dom/SVGAnimatedNumberList.html svg/dom/SVGNumber.html * GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash. * bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now. * bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace. * bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now. * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling. * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. * svg/SVGAnimatedNumber.h: Added. * svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking. * svg/SVGAnimatedNumberList.h: Added. * svg/SVGAnimatedNumberList.idl: Ditto. * svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction): * svg/SVGComponentTransferFunctionElement.h: * svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build): * svg/SVGFEColorMatrixElement.h: * svg/SVGFECompositeElement.h: Ditto. * svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build): * svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto. * svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFEDisplacementMapElement.h: Ditto. * svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto. * svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFELightElement.h: Ditto. * svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto. * svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFEOffsetElement.h: Ditto. * svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto. * svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto. * svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto. * svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker. * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto. * svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking. * svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString): * svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList): * svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List). * svg/SVGStopElement.h: Ditto. * svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute): * svg/SVGTextPositioningElement.h: Ditto. * svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling. 2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Rob Buis. Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept https://bugs.webkit.org/show_bug.cgi?id=48686 Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList. Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed) * platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: * platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: * svg/dom/SVGAnimatedNumber-expected.txt: Added. * svg/dom/SVGAnimatedNumber.html: Added. * svg/dom/SVGAnimatedNumberList-expected.txt: Added. * svg/dom/SVGAnimatedNumberList.html: Added. * svg/dom/SVGNumber-expected.txt: Added. * svg/dom/SVGNumber.html: Added. * svg/dom/script-tests/SVGAnimatedNumber.js: Added. * svg/dom/script-tests/SVGAnimatedNumberList.js: Added. * svg/dom/script-tests/SVGNumber.js: Added. * svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled. * svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list. * svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js: Canonical link: https://commits.webkit.org/61477@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-30 13:23:55 +00:00
PASS textElement.rotate.baseVal = -1 is -1
PASS textElement.rotate.baseVal = 'aString' is "aString"
PASS textElement.rotate.baseVal = textElement is textElement
Check that the rotate value remained 100, and the baseVal type has not been changed
PASS textElement.rotate.baseVal.toString() is "[object SVGNumberList]"
PASS textElement.rotate.baseVal.getItem(0).value is 100
PASS successfullyParsed is true
TEST COMPLETE