haikuwebkit/LayoutTests/svg/custom/use-external-crash-expected...

3 lines
44 B
Plaintext
Raw Permalink Normal View History

2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com> External <use> xlink:href references do not work https://bugs.webkit.org/show_bug.cgi?id=12499 Reviewed by Zoltan Herczeg. Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes. Replace xml:id with id everywhere, to make the new tiny tests work. * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: * platform/mac/svg/batik/filters/feTile-expected.png: * platform/mac/svg/batik/filters/filterRegions-expected.png: * platform/mac/svg/batik/text/textEffect-expected.png: * platform/mac/svg/batik/text/textEffect3-expected.png: * platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg: * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg: * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg: * svg/custom/use-external-crash-expected.txt: Added. * svg/custom/use-external-crash.svg: Added. 2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com> External <use> xlink:href references do not work https://bugs.webkit.org/show_bug.cgi?id=12499 Reviewed by Zoltan Herczeg. Follow-up fix after r110676. Assertions are firing due last minute changes in isExternalURIReference. Fix detecting local resources properly, when the given iri contains a /complex/path. Use document->completeURL() instead, and compare with the document->url() to decide if its a local reference or not. If an external document load fails with an error (eg. file missing) don't assert in debug builds, instead handle it gracefully. I decided to clean the code up as well, to make it more safe & obvious. Test: svg/custom/use-external-crash.svg * svg/SVGURIReference.cpp: (WebCore::SVGURIReference::targetElementFromIRIString): * svg/SVGURIReference.h: (WebCore::SVGURIReference::isExternalURIReference): * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::externalDocument): (WebCore::SVGUseElement::buildPendingResource): Canonical link: https://commits.webkit.org/98266@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-03-14 12:00:44 +00:00
PASS if it doesn't assert in debug builds.