nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/svg/custom/add-event-listener-shadow-t...

3 lines
44 B
Plaintext
Raw Permalink Normal View History

REGRESSION (r244995): Assertion failure when addEventListener to an SVGElement which has an. instance in shadow tree https://bugs.webkit.org/show_bug.cgi?id=200083 Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-07-25 Reviewed by Ryosuke Niwa. Source/WebCore: When adding an event listener to an SVGElement, the same event listener has to be add to all the instances of SVGElement in the shadow tree. See SVGElement::addEventListener(). In r244995, an assertion was added to ensure if the event listener is attached to an event target, the new event target has be the same as the attached one. This assertion isn't correct for the event targets which were copied from the targetElement sub tree of an SVGUseElement to the shadow tree. Test: svg/custom/add-event-listener-shadow-tree-element.html * bindings/js/JSLazyEventListener.cpp: (WebCore::isCloneInShadowTreeOfSVGUseElement): (WebCore::JSLazyEventListener::checkValidityForEventTarget): LayoutTests: * svg/custom/add-event-listener-shadow-tree-element-expected.txt: Added. * svg/custom/add-event-listener-shadow-tree-element.html: Added. Canonical link: https://commits.webkit.org/213949@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-07-25 17:56:45 +00:00
PASS if it doesn't assert in debug builds.