nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/resize-observer/delete-observers-in-callbac...

6 lines
78 B
Plaintext
Raw Permalink Normal View History

Crash in Document::deliverResizeObservations https://bugs.webkit.org/show_bug.cgi?id=200635 Patch by Cathie Chen <cathiechen@igalia.com> on 2019-08-18 Reviewed by Simon Fraser. Source/WebCore: Document::deliverResizeObservations will crash if m_resizeObservers in Document is modified in JS callbacks when we are traversing observers in m_resizeObservers. This patch copy m_resizeObservers to a new vector, and check null for observers. Test: resize-observer/delete-observers-in-callbacks.html * dom/Document.cpp: (WebCore::Document::deliverResizeObservations): LayoutTests: Test deleting the next/previous sibling of observer list in callbacks, and the order of notifications. * resize-observer/delete-observers-in-callbacks-expected.txt: Added. * resize-observer/delete-observers-in-callbacks.html: Added. Canonical link: https://commits.webkit.org/214604@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-08-18 14:07:02 +00:00
t1
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS ResizeObserver implemented
PASS Test deleting observer in callbacks
Crash in Document::deliverResizeObservations https://bugs.webkit.org/show_bug.cgi?id=200635 Patch by Cathie Chen <cathiechen@igalia.com> on 2019-08-18 Reviewed by Simon Fraser. Source/WebCore: Document::deliverResizeObservations will crash if m_resizeObservers in Document is modified in JS callbacks when we are traversing observers in m_resizeObservers. This patch copy m_resizeObservers to a new vector, and check null for observers. Test: resize-observer/delete-observers-in-callbacks.html * dom/Document.cpp: (WebCore::Document::deliverResizeObservations): LayoutTests: Test deleting the next/previous sibling of observer list in callbacks, and the order of notifications. * resize-observer/delete-observers-in-callbacks-expected.txt: Added. * resize-observer/delete-observers-in-callbacks.html: Added. Canonical link: https://commits.webkit.org/214604@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-08-18 14:07:02 +00:00