nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/media/video-buffering-allowed-exp...

39 lines
1.5 KiB
Plaintext
Raw Permalink Normal View History

Media continues loading after rendered invisible (removed from DOM; scrolled off screen) https://bugs.webkit.org/show_bug.cgi?id=185487 Reviewed by Eric Carlson. Source/WebCore: Test: media/video-buffering-allowed.html When a media element is removed from the dom (e.g. through innerHTML=""), it doesn't necessarily stop loading media data; it will continue to do so until its destructor is called through garbage collection. Similarly, when a media element is rendered not-visible by being scrolled off-screen or being made display:none, media loading continues. There are legitimate use cases for out-of-DOM media loading, so only temporarily block loading when the element transitions out of the document. Similarly, only block loading for non-visible media elements when returning from the "page is hidden" state, and only until the media element is asked to play or is otherwise made visible. Note: this refactors a lot of code out of PlatformMediaSession and into MediaElementSession, since this code is specific to "media elements". * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::insertedIntoAncestor): (WebCore::HTMLMediaElement::removedFromAncestor): (WebCore::HTMLMediaElement::playInternal): (WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): (WebCore::HTMLMediaElement::resume): (WebCore::HTMLMediaElement::visibilityStateChanged): (WebCore::HTMLMediaElement::createMediaPlayer): (WebCore::HTMLMediaElement::setShouldBufferData): (WebCore::HTMLMediaElement::purgeBufferedDataIfPossible): (WebCore::HTMLMediaElement::isVisibleInViewportChanged): (WebCore::HTMLMediaElement::fullscreenModeChanged): (WebCore::HTMLMediaElement::setInActiveDocument): * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::shouldBufferData const): (WebCore::HTMLMediaElement::elementIsHidden const): * html/MediaElementSession.cpp: (WebCore::MediaElementSession::MediaElementSession): (WebCore::MediaElementSession::clientWillBeginAutoplaying): (WebCore::MediaElementSession::clientWillBeginPlayback): (WebCore::MediaElementSession::clientWillPausePlayback): (WebCore::MediaElementSession::visibilityChanged): (WebCore::MediaElementSession::isVisibleInViewportChanged): (WebCore::MediaElementSession::inActiveDocumentChanged): (WebCore::MediaElementSession::scheduleClientDataBufferingCheck): (WebCore::MediaElementSession::clientDataBufferingTimerFired): (WebCore::MediaElementSession::updateClientDataBuffering): (WebCore::MediaElementSession::dataBufferingPermitted const): (WebCore::MediaElementSession::wantsToObserveViewportVisibilityForAutoplay const): * html/MediaElementSession.h: * platform/audio/PlatformMediaSession.cpp: (WebCore::PlatformMediaSession::PlatformMediaSession): (WebCore::PlatformMediaSession::clientWillBeginAutoplaying): (WebCore::PlatformMediaSession::clientWillBeginPlayback): (WebCore::PlatformMediaSession::clientWillPausePlayback): (): Deleted. (WebCore::PlatformMediaSession::visibilityChanged): Deleted. (WebCore::PlatformMediaSession::scheduleClientDataBufferingCheck): Deleted. (WebCore::PlatformMediaSession::clientDataBufferingTimerFired): Deleted. (WebCore::PlatformMediaSession::updateClientDataBuffering): Deleted. (WebCore::PlatformMediaSession::isHidden const): Deleted. * platform/audio/PlatformMediaSession.h: (WebCore::PlatformMediaSessionClient::setShouldBufferData): Deleted. (WebCore::PlatformMediaSessionClient::elementIsHidden const): Deleted. * platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::sessionCanLoadMedia const): Deleted. * platform/audio/PlatformMediaSessionManager.h: * platform/audio/ios/MediaSessionManagerIOS.h: * platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::sessionCanLoadMedia const): Deleted. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): * testing/Internals.cpp: (WebCore::Internals::elementShouldBufferData): * testing/Internals.h: * testing/Internals.idl: LayoutTests: * media/video-buffering-allowed-expected.txt: Added. * media/video-buffering-allowed.html: Added. * media/video-test.js: (compare): (testExpected): (sleepFor): (testArraysEqual): Deleted. Canonical link: https://commits.webkit.org/201128@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-05-15 23:01:14 +00:00
RUN(video.src = findMediaFile("video", "content/test"))
EVENT(canplaythrough)
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
* Remove the video element from the document.
RUN(video.parentNode.removeChild(video))
EXPECTED (internals.elementShouldBufferData(video) == 'false') OK
* Play the video.
RUN(video.play())
EVENT(playing)
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
* Pause the video.
RUN(video.pause())
EVENT(pause)
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
* Re-insert the video element into the document.
RUN(document.body.insertBefore(video, document.body.firstChild))
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in https://bugs.webkit.org/show_bug.cgi?id=186326 <rdar://problem/40778157> Reviewed by Eric Carlson. Source/WebCore: Check whether the element is visible in the viewport when the web view itself becomes visible, and if so, clear the m_elementIsHiddenUntilVisibleInViewport flag. * html/MediaElementSession.cpp: (WebCore::MediaElementSession::visibilityChanged): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: LayoutTests: * media/video-buffering-allowed-expected.txt: * media/video-buffering-allowed.html: Canonical link: https://commits.webkit.org/201715@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-06-06 04:25:48 +00:00
* Simulate the view becoming invisible.
RUN(internals.setPageVisibility(false))
EXPECTED (internals.elementShouldBufferData(video) == 'false') OK
* Simulate the view becoming visible.
RUN(internals.setPageVisibility(true))
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
Media continues loading after rendered invisible (removed from DOM; scrolled off screen) https://bugs.webkit.org/show_bug.cgi?id=185487 Reviewed by Eric Carlson. Source/WebCore: Test: media/video-buffering-allowed.html When a media element is removed from the dom (e.g. through innerHTML=""), it doesn't necessarily stop loading media data; it will continue to do so until its destructor is called through garbage collection. Similarly, when a media element is rendered not-visible by being scrolled off-screen or being made display:none, media loading continues. There are legitimate use cases for out-of-DOM media loading, so only temporarily block loading when the element transitions out of the document. Similarly, only block loading for non-visible media elements when returning from the "page is hidden" state, and only until the media element is asked to play or is otherwise made visible. Note: this refactors a lot of code out of PlatformMediaSession and into MediaElementSession, since this code is specific to "media elements". * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::insertedIntoAncestor): (WebCore::HTMLMediaElement::removedFromAncestor): (WebCore::HTMLMediaElement::playInternal): (WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): (WebCore::HTMLMediaElement::resume): (WebCore::HTMLMediaElement::visibilityStateChanged): (WebCore::HTMLMediaElement::createMediaPlayer): (WebCore::HTMLMediaElement::setShouldBufferData): (WebCore::HTMLMediaElement::purgeBufferedDataIfPossible): (WebCore::HTMLMediaElement::isVisibleInViewportChanged): (WebCore::HTMLMediaElement::fullscreenModeChanged): (WebCore::HTMLMediaElement::setInActiveDocument): * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::shouldBufferData const): (WebCore::HTMLMediaElement::elementIsHidden const): * html/MediaElementSession.cpp: (WebCore::MediaElementSession::MediaElementSession): (WebCore::MediaElementSession::clientWillBeginAutoplaying): (WebCore::MediaElementSession::clientWillBeginPlayback): (WebCore::MediaElementSession::clientWillPausePlayback): (WebCore::MediaElementSession::visibilityChanged): (WebCore::MediaElementSession::isVisibleInViewportChanged): (WebCore::MediaElementSession::inActiveDocumentChanged): (WebCore::MediaElementSession::scheduleClientDataBufferingCheck): (WebCore::MediaElementSession::clientDataBufferingTimerFired): (WebCore::MediaElementSession::updateClientDataBuffering): (WebCore::MediaElementSession::dataBufferingPermitted const): (WebCore::MediaElementSession::wantsToObserveViewportVisibilityForAutoplay const): * html/MediaElementSession.h: * platform/audio/PlatformMediaSession.cpp: (WebCore::PlatformMediaSession::PlatformMediaSession): (WebCore::PlatformMediaSession::clientWillBeginAutoplaying): (WebCore::PlatformMediaSession::clientWillBeginPlayback): (WebCore::PlatformMediaSession::clientWillPausePlayback): (): Deleted. (WebCore::PlatformMediaSession::visibilityChanged): Deleted. (WebCore::PlatformMediaSession::scheduleClientDataBufferingCheck): Deleted. (WebCore::PlatformMediaSession::clientDataBufferingTimerFired): Deleted. (WebCore::PlatformMediaSession::updateClientDataBuffering): Deleted. (WebCore::PlatformMediaSession::isHidden const): Deleted. * platform/audio/PlatformMediaSession.h: (WebCore::PlatformMediaSessionClient::setShouldBufferData): Deleted. (WebCore::PlatformMediaSessionClient::elementIsHidden const): Deleted. * platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::sessionCanLoadMedia const): Deleted. * platform/audio/PlatformMediaSessionManager.h: * platform/audio/ios/MediaSessionManagerIOS.h: * platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::sessionCanLoadMedia const): Deleted. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): * testing/Internals.cpp: (WebCore::Internals::elementShouldBufferData): * testing/Internals.h: * testing/Internals.idl: LayoutTests: * media/video-buffering-allowed-expected.txt: Added. * media/video-buffering-allowed.html: Added. * media/video-test.js: (compare): (testExpected): (sleepFor): (testArraysEqual): Deleted. Canonical link: https://commits.webkit.org/201128@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-05-15 23:01:14 +00:00
* display:none the video element.
RUN(video.style.display = "none")
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
* Simulate the view becoming invisible.
RUN(internals.setPageVisibility(false))
EXPECTED (internals.elementShouldBufferData(video) == 'false') OK
* Simulate the view becoming visible.
RUN(internals.setPageVisibility(true))
EXPECTED (internals.elementShouldBufferData(video) == 'false') OK
* Remove display:none from the video element.
RUN(video.style.removeProperty("display"))
EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
END OF TEST