This website requires JavaScript.
Explore
Help
Sign In
nephele
/
haikuwebkit
Watch
1
Star
0
Fork
You've already forked haikuwebkit
0
Code
Issues
Releases
Activity
haiku
haikuwebkit
/
LayoutTests
/
media
/
media-controls-shadow-const...
2 lines
1 B
Raw
Permalink
Normal View
History
Unescape
Escape
Source/WebCore: REGRESSION (r207669): Crash under media controls shadow root construction https://bugs.webkit.org/show_bug.cgi?id=164381 <rdar://problem/28935401> Reviewed by Simon Fraser. The problem is that we are running a script for media control UA shadow tree in HTMLMediaElement::insertedInto. It is not safe to run scripts in insertedInto as the tree is in inconsistent state. Instead finishedInsertingSubtree callback should be used. Test: media/media-controls-shadow-construction-crash.html Seen on https://www.theguardian.com/artanddesign/video/2013/oct/14/banksy-central-park-new-york-video * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedInto): (WebCore::HTMLMediaElement::finishedInsertingSubtree): Move configureMediaControls() to finishedInsertingSubtree(). * html/HTMLMediaElement.h: * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveComposedTree): Add an assert to make the bad state easier to hit in tests. LayoutTests: REGRESSION (r207669): Crash under SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending https://bugs.webkit.org/show_bug.cgi?id=164381 <rdar://problem/28935401> Reviewed by Simon Fraser. * media/media-controls-shadow-construction-crash-expected.txt: Added. * media/media-controls-shadow-construction-crash.html: Added. Canonical link: https://commits.webkit.org/182115@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@208370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-11-04 05:08:29 +00:00
