nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/mathml/opentype/large-operators-munderover-...

10 lines
196 B
Plaintext
Raw Permalink Normal View History

Bad position of large operators inside an munderover element https://bugs.webkit.org/show_bug.cgi?id=151916 Reviewed by Alejandro G. Castro. Source/WebCore: Test: mathml/opentype/large-operators-munderover.html * rendering/mathml/RenderMathMLOperator.h: (WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator. * rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators. LayoutTests: * mathml/opentype/large-operators-munderover-expected.txt: Added. * mathml/opentype/large-operators-munderover.html: Added. Add a test to verify the position and size of a large operator used as an munderover base. Canonical link: https://commits.webkit.org/170204@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@193829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-12-09 14:46:11 +00:00
This test passes if you see a large black square with a green bar overscript and a red bar underscript.
Refactor RenderMathMLOperator and RenderMathMLToken to avoid using anonymous renderers. https://bugs.webkit.org/show_bug.cgi?id=155018 Patch by Frederic Wang <fwang@igalia.com> on 2016-06-24 Reviewed by Martin Robinson. Source/WebCore: No new tests, already covered by existing tests. We use MathOperator for RenderMathMLOperator to avoid creating anonymous text nodes again and again. We reimplement implicit mathvariant="italic" on single-char mi in a way that does not rely on creating anonymous text nodes. Finally, we improve the determination/update of when mathvariant is italic to avoid breaking foreign-mi-dynamic test. The change in the render tree structure breaks mfenced accessibility support but that will be fixed in follow-up patches. The simplifications made here will also allow to simplify the accessibility code. * css/mathml.css: (mo): Deleted. This flexbox rule is no longer needed. * rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::createAnonymousMathMLBlock): Deleted. We no longer need to create anonymous renderer with this function. * rendering/mathml/RenderMathMLBlock.h: Delete createAnonymousMathMLBlock. * rendering/mathml/RenderMathMLOperator.cpp: Implement layout functions without relying on flexbox or anonymous. (WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Handle the case of !useMathOperator() for which we need to add extra operator spacing after the RenderMathMLToken layout. (WebCore::RenderMathMLOperator::layoutBlock): Ditto. (WebCore::RenderMathMLOperator::isChildAllowed): Deleted. We allow the non-anonymous text. (WebCore::RenderMathMLOperator::rebuildTokenContent): No longer destroy and rebuild anonymous wrapper. Remove updateStyle call. (WebCore::RenderMathMLOperator::updateStyle): Deleted. We no longer need anonymous style for the spacing. * rendering/mathml/RenderMathMLOperator.h: Remove updateStyle() and isChildAllowed(). Make textContent() public so that it can be accessed from the accessibility code. * rendering/mathml/RenderMathMLToken.cpp: Reimplement implicit mathvariant="italic" by painting MATHEMATICAL ITALIC characters instead of styling an anonymous wrapper. (WebCore::RenderMathMLToken::RenderMathMLToken): Init m_mathVariantGlyph and m_mathVariantGlyphDirty (WebCore::RenderMathMLToken::updateTokenContent): Set mathvariant glyph dirty when the content changes. (WebCore::transformToItalic): Helper function to map latin and greek alphabets to their MATHEMATICAL ITALIC counterpart. (WebCore::RenderMathMLToken::computePreferredLogicalWidths): Implement this function to handle the case where the mathvariant glyph is used. (WebCore::RenderMathMLToken::updateMathVariantGlyph): Helper function to update the mathvariant glyph. For now, we try and keep with the old (and limited) implementation: a mathvariant glyph may only used for single-char <mi> without mathvariant attribute attached to it. (WebCore::RenderMathMLToken::styleDidChange): Set the mathvariant glyph dirty when the style changes. (WebCore::RenderMathMLToken::updateFromElement): Remove updateStyle call and set mathvariant glyph dirty. (WebCore::RenderMathMLToken::firstLineBaseline): Implement this function to handle the case where the mathvariant glyph is used. (WebCore::RenderMathMLToken::layoutBlock): Ditto. (WebCore::RenderMathMLToken::paint): Ditto. (WebCore::RenderMathMLToken::paintChildren): Ditto. (WebCore::RenderMathMLToken::addChild): Deleted. No need to bother with anonymous renderer or style. (WebCore::RenderMathMLToken::createWrapperIfNeeded): Deleted. Ditto. (WebCore::RenderMathMLToken::updateStyle): Deleted. Ditto. * rendering/mathml/RenderMathMLToken.h: Update declarations of functions. (WebCore::RenderMathMLToken::setMathVariantGlyphDirty): Helper function to indicate that the mathvariant glyph will need to be updated. LayoutTests: We update the test expectations. Most of the adjustments are irrelevant visual modifications (small shift and size differences) or due to changes in the renderer tree structure (removal of anonymous, operator text appearing in the dumped text). We disable the accessibility for mfenced for now, but this will be enabled again and improved in follow-up accessibility patches. * platform/ios-simulator/TestExpectations: We disable two reftests that use a character from the Mathematical Alphanumeric Symbols block as a reference, since iOS does not have appropriate fonts pre-installed. * accessibility/mac/mathml-elements.html: Disable the mfenced test for now. * accessibility/mac/mathml-elements-expected.txt: Ditto. * accessibility/ios-simulator/math-expected.txt: Update the reference now that the text of the operator appears in the render tree. * accessibility/mac/math-alttext-expected.txt: Ditto. * mathml/opentype/large-operators-italic-correction-expected.txt: Ditto. * mathml/opentype/large-operators-munderover-expected.txt: Ditto. * mathml/presentation/inferred-mrow-stretchy-expected.txt: Ditto. * mathml/presentation/mfrac-nested-expected.txt: Ditto. * mathml/presentation/stretchy-depth-height-expected.txt: Ditto. * mathml/presentation/stretchy-depth-height-symmetric-expected.txt: Ditto. * mathml/presentation/sup-nested-expected.txt: Ditto. * mathml/very-large-stretchy-operators-expected.txt: Ditto. * platform/mac/accessibility/math-text-expected.txt: Ditto. * platform/gtk/accessibility/math-text-expected.txt: Ditto. * fast/css/readonly-pseudoclass-common-element-expected.txt: Ditto. * fast/css/readwrite-pseudoclass-editable-expected.txt: Ditto. * imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-expected.txt: Ditto. * imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt: Ditto. * mathml/presentation/attributes-background-color.html: Add some padding to workaround some small rendering failures. * mathml/presentation/attributes-background-color-expected.html: Ditto. * mathml/presentation/attributes-display.html: Ditto. * mathml/presentation/attributes-display-expected.html: Ditto. * mathml/presentation/bug97990-expected.html: Ditto. * mathml/presentation/bug97990.html: Ditto. * mathml/presentation/attributes-mathvariant-expected.html: Update the reftest to use italic characters from the Mathematical Alphanumeric Symbols. * mathml/presentation/tokenElements-mathvariant-expected.html: Ditto. * mathml/presentation/mo-whitespaces-expected.html: Adjust one edge case since we now only collapse whitespace for operators that use MathOperator. * accessibility/math-multiscript-attributes-expected.txt: Small size/coordinate adjustment. * platform/gtk/accessibility/math-multiscript-attributes-expected.txt: Dottp. * platform/gtk/mathml/presentation/roots-expected.txt: Size/coordinate adjustment, removal of anonymous renderers and use italic characters from the Mathematical Alphanumeric Symbols. * platform/gtk/mathml/presentation/roots-expected.png: Ditto. * platform/ios-simulator/mathml/presentation/roots-expected.txt: Ditto. * platform/gtk/mathml/opentype/horizontal-expected.txt: Size/coordinate adjustment and removal of anonymous renderers. * platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Ditto. * platform/gtk/mathml/opentype/large-operators-expected.txt: Ditto. * platform/gtk/mathml/opentype/opentype-stretchy-expected.txt: Ditto. * platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto. * platform/gtk/mathml/opentype/vertical-expected.txt: Ditto. * platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto. * platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Ditto. * platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto. * platform/mac/mathml/opentype/large-operators-expected.txt: Ditto. * platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto. * platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto. * platform/mac/mathml/opentype/vertical-expected.txt: Ditto. Canonical link: https://commits.webkit.org/177180@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-06-24 14:39:58 +00:00
⨜
Use Testharness.js for the MathML script tests https://bugs.webkit.org/show_bug.cgi?id=154065 Reviewed by Darin Adler. * mathml/opentype/large-operators-munderover-expected.txt: * mathml/opentype/large-operators-munderover.html: * mathml/presentation/inferred-mrow-baseline-expected.txt: * mathml/presentation/inferred-mrow-baseline.html: * mathml/presentation/inferred-mrow-stretchy-expected.txt: * mathml/presentation/inferred-mrow-stretchy.html: * mathml/presentation/stretchy-depth-height-expected.txt: * mathml/presentation/stretchy-depth-height-symmetric-expected.txt: * mathml/presentation/stretchy-depth-height-symmetric.html: * mathml/presentation/stretchy-depth-height.html: Canonical link: https://commits.webkit.org/172214@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-02-11 10:40:03 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS largeop width
PASS largeop height
PASS green bar is above
PASS red bar is below
Bad position of large operators inside an munderover element https://bugs.webkit.org/show_bug.cgi?id=151916 Reviewed by Alejandro G. Castro. Source/WebCore: Test: mathml/opentype/large-operators-munderover.html * rendering/mathml/RenderMathMLOperator.h: (WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator. * rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators. LayoutTests: * mathml/opentype/large-operators-munderover-expected.txt: Added. * mathml/opentype/large-operators-munderover.html: Added. Add a test to verify the position and size of a large operator used as an munderover base. Canonical link: https://commits.webkit.org/170204@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@193829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-12-09 14:46:11 +00:00