nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/js/dfg-constant-fold-logical-n...

12 lines
434 B
Plaintext
Raw Permalink Normal View History

DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant https://bugs.webkit.org/show_bug.cgi?id=89511 <rdar://problem/11700089> Reviewed by Geoffrey Garen. Source/JavaScriptCore: * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::execute): LayoutTests: * fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added. * fast/js/dfg-constant-fold-logical-not-branch.html: Added. * fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added. (foo1): (foo2): (Stuff): (Stuff.prototype.thingy): (Stuff.prototype.otherThingy): Canonical link: https://commits.webkit.org/107372@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-06-19 23:10:12 +00:00
Tests what happens if we fail to constant fold a LogicalNot that leads into a branch, when the CFA proves that the LogicalNot has a constant value.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG https://bugs.webkit.org/show_bug.cgi?id=120781 Reviewed by Mark Hahnenberg. Roll this back in with a build fix. - Use some method table hacks to detect if the CheckStructure optimization is valid for to_this. - Introduce a FinalObjectUse and use it for ToThis->Identity conversion. This looks like it might be perf-neutral on the major benchmarks, but it introduces some horrible performance cliffs. For example if you add methods to the Array prototype, you'll get horrible performance cliffs. As in virtual calls to C++ every time you call a JS function even if it's inlined. LongSpider/3d-cube appears to hit this. * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::::executeEffects): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGRepatch.cpp: (JSC::DFG::emitPutTransitionStub): * dfg/DFGSafeToExecute.h: (JSC::DFG::SafeToExecuteEdge::operator()): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::speculateFinalObject): (JSC::DFG::SpeculativeJIT::speculate): * dfg/DFGSpeculativeJIT.h: * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGUseKind.cpp: (WTF::printInternal): * dfg/DFGUseKind.h: (JSC::DFG::typeFilterFor): (JSC::DFG::isCell): Canonical link: https://commits.webkit.org/138810@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2013-09-06 19:01:21 +00:00
PASS foo1(new Stuff()) is 43 on all iterations including after DFG tier-up.
PASS foo2(new Stuff()) is 58 on all iterations including after DFG tier-up.
DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant https://bugs.webkit.org/show_bug.cgi?id=89511 <rdar://problem/11700089> Reviewed by Geoffrey Garen. Source/JavaScriptCore: * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::execute): LayoutTests: * fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added. * fast/js/dfg-constant-fold-logical-not-branch.html: Added. * fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added. (foo1): (foo2): (Stuff): (Stuff.prototype.thingy): (Stuff.prototype.otherThingy): Canonical link: https://commits.webkit.org/107372@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-06-19 23:10:12 +00:00
PASS successfullyParsed is true
TEST COMPLETE