nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/js/destructuring-parameters-sh...

11 lines
279 B
HTML
Raw Permalink Normal View History

Deconstructed parameters aren't being placed in the correct scope https://bugs.webkit.org/show_bug.cgi?id=128126 Reviewed by Antti Koivisto. Source/JavaScriptCore: Make sure we declare the bound parameter names as variables when we reparse. In the BytecodeGenerator we now also directly ensure that bound parameters are placed in the symbol table of the function we're currently compiling. We then delay binding until just before we start codegen for the body of the function so that we can ensure the function has completely initialised all scope details. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator): * bytecompiler/BytecodeGenerator.h: * parser/Parser.cpp: (JSC::Parser<LexerType>::Parser): (JSC::Parser<LexerType>::createBindingPattern): LayoutTests: Added tests for correct behaviour. * js/deconstructing-parameters-should-be-locals-expected.txt: Added. * js/deconstructing-parameters-should-be-locals.html: Added. * js/script-tests/deconstructing-parameters-should-be-locals.js: Added. (description.value.string_appeared_here.readDeconstructedParameter): (overwriteDeconstructedParameter): (readCapturedDeconstructedParameter): (overwriteCapturedDeconstructedParameter): Canonical link: https://commits.webkit.org/146139@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-02-03 22:43:28 +00:00
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<script src="../resources/js-test-pre.js"></script>
</head>
<body>
Rename "Deconstruction" to "Destructuring" throughout JSC https://bugs.webkit.org/show_bug.cgi?id=146100 Reviewed by Mark Lam. Source/JavaScriptCore: It is good to use the same naming conventions as the ES6 spec because it is the de facto way of speaking about these language features. This also has the benefit of improving JSC's hackability because it improves code readability for newcomers to JSC or newcomers to this part of the code base. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::initializeNextParameter): (JSC::BytecodeGenerator::visibleNameForParameter): * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::registerFor): * bytecompiler/NodesCodegen.cpp: (JSC::ForInNode::tryGetBoundLocal): (JSC::ForInNode::emitLoopHeader): (JSC::ForOfNode::emitBytecode): (JSC::ClassExprNode::emitBytecode): (JSC::DestructuringAssignmentNode::emitBytecode): (JSC::DestructuringPatternNode::~DestructuringPatternNode): (JSC::ArrayPatternNode::collectBoundIdentifiers): (JSC::DeconstructingAssignmentNode::emitBytecode): Deleted. (JSC::DeconstructionPatternNode::~DeconstructionPatternNode): Deleted. * parser/ASTBuilder.h: (JSC::ASTBuilder::createElementList): (JSC::ASTBuilder::createFormalParameterList): (JSC::ASTBuilder::createClause): (JSC::ASTBuilder::createClauseList): (JSC::ASTBuilder::createForInLoop): (JSC::ASTBuilder::createForOfLoop): (JSC::ASTBuilder::isBindingNode): (JSC::ASTBuilder::isResolve): (JSC::ASTBuilder::createDestructuringAssignment): (JSC::ASTBuilder::createArrayPattern): (JSC::ASTBuilder::appendArrayPatternSkipEntry): (JSC::ASTBuilder::appendArrayPatternEntry): (JSC::ASTBuilder::appendArrayPatternRestEntry): (JSC::ASTBuilder::createObjectPattern): (JSC::ASTBuilder::appendObjectPatternEntry): (JSC::ASTBuilder::createDeconstructingAssignment): Deleted. * parser/NodeConstructors.h: (JSC::TryNode::TryNode): (JSC::ParameterNode::ParameterNode): (JSC::ForOfNode::ForOfNode): (JSC::DestructuringPatternNode::DestructuringPatternNode): (JSC::ArrayPatternNode::ArrayPatternNode): (JSC::ArrayPatternNode::create): (JSC::ObjectPatternNode::ObjectPatternNode): (JSC::BindingNode::create): (JSC::BindingNode::BindingNode): (JSC::DestructuringAssignmentNode::DestructuringAssignmentNode): (JSC::DeconstructionPatternNode::DeconstructionPatternNode): Deleted. (JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode): Deleted. * parser/Nodes.cpp: (JSC::FunctionParameters::create): * parser/Nodes.h: (JSC::ExpressionNode::isResolveNode): (JSC::ExpressionNode::isBracketAccessorNode): (JSC::ExpressionNode::isDotAccessorNode): (JSC::ExpressionNode::isDestructuringNode): (JSC::ExpressionNode::isFuncExprNode): (JSC::ExpressionNode::isCommaNode): (JSC::ExpressionNode::isSimpleArray): (JSC::ParameterNode::pattern): (JSC::ParameterNode::nextParam): (JSC::FunctionParameters::size): (JSC::FunctionParameters::at): (JSC::FunctionParameters::patterns): (JSC::DestructuringPatternNode::isBindingNode): (JSC::DestructuringPatternNode::emitDirectBinding): (JSC::ArrayPatternNode::appendIndex): (JSC::ObjectPatternNode::appendEntry): (JSC::BindingNode::boundProperty): (JSC::DestructuringAssignmentNode::bindings): (JSC::ExpressionNode::isDeconstructionNode): Deleted. (JSC::DeconstructionPatternNode::isBindingNode): Deleted. (JSC::DeconstructionPatternNode::emitDirectBinding): Deleted. (JSC::DeconstructingAssignmentNode::bindings): Deleted. * parser/Parser.cpp: (JSC::Parser<LexerType>::parseVarDeclaration): (JSC::Parser<LexerType>::parseWhileStatement): (JSC::Parser<LexerType>::parseVarDeclarationList): (JSC::Parser<LexerType>::createBindingPattern): (JSC::Parser<LexerType>::tryParseDestructuringPatternExpression): (JSC::Parser<LexerType>::parseDestructuringPattern): (JSC::Parser<LexerType>::parseDefaultValueForDestructuringPattern): (JSC::Parser<LexerType>::parseForStatement): (JSC::Parser<LexerType>::parseFormalParameters): (JSC::Parser<LexerType>::parseFunctionParameters): (JSC::Parser<LexerType>::parseAssignmentExpression): (JSC::Parser<LexerType>::tryParseDeconstructionPatternExpression): Deleted. (JSC::Parser<LexerType>::parseDeconstructionPattern): Deleted. (JSC::Parser<LexerType>::parseDefaultValueForDeconstructionPattern): Deleted. * parser/Parser.h: (JSC::isEvalNode): * parser/SyntaxChecker.h: (JSC::SyntaxChecker::createPropertyList): (JSC::SyntaxChecker::createElementList): (JSC::SyntaxChecker::createFormalParameterList): (JSC::SyntaxChecker::createClause): (JSC::SyntaxChecker::createClauseList): (JSC::SyntaxChecker::operatorStackPop): * tests/stress/reserved-word-with-escape.js: * tests/stress/rest-elements.js: LayoutTests: * js/deconstructing-parameters-should-be-locals-expected.txt: Removed. * js/deconstructing-parameters-should-be-locals.html: Removed. * js/destructuring-assignment-expected.txt: * js/destructuring-parameters-should-be-locals-expected.txt: Copied from LayoutTests/js/deconstructing-parameters-should-be-locals-expected.txt. * js/destructuring-parameters-should-be-locals.html: Copied from LayoutTests/js/deconstructing-parameters-should-be-locals.html. * js/regress/deconstructing-parameters-overridden-by-function-expected.txt: Removed. * js/regress/deconstructing-parameters-overridden-by-function.html: Removed. * js/regress/destructuring-parameters-overridden-by-function-expected.txt: Copied from LayoutTests/js/regress/deconstructing-parameters-overridden-by-function-expected.txt. * js/regress/destructuring-parameters-overridden-by-function.html: Copied from LayoutTests/js/regress/deconstructing-parameters-overridden-by-function.html. * js/regress/script-tests/deconstructing-parameters-overridden-by-function.js: Removed. * js/regress/script-tests/destructuring-parameters-overridden-by-function.js: Copied from LayoutTests/js/regress/script-tests/deconstructing-parameters-overridden-by-function.js. * js/script-tests/deconstructing-parameters-should-be-locals.js: Removed. * js/script-tests/destructuring-assignment.js: (testDestructuredArgs): (testDestructuredArgLength): (testDeconstructArgs): Deleted. (testDeconstructArgLength): Deleted. * js/script-tests/destructuring-parameters-should-be-locals.js: Copied from LayoutTests/js/script-tests/deconstructing-parameters-should-be-locals.js. (description.value.string_appeared_here.readDestructuredParameter): (overwriteDestructuredParameter): (readCapturedDestructuredParameter): (overwriteCapturedDestructuredParameter): (description.value.string_appeared_here.readDeconstructedParameter): Deleted. (overwriteDeconstructedParameter): Deleted. (readCapturedDeconstructedParameter): Deleted. (overwriteCapturedDeconstructedParameter): Deleted. Canonical link: https://commits.webkit.org/164658@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-07-02 23:53:10 +00:00
<script src="script-tests/destructuring-parameters-should-be-locals.js"></script>
Deconstructed parameters aren't being placed in the correct scope https://bugs.webkit.org/show_bug.cgi?id=128126 Reviewed by Antti Koivisto. Source/JavaScriptCore: Make sure we declare the bound parameter names as variables when we reparse. In the BytecodeGenerator we now also directly ensure that bound parameters are placed in the symbol table of the function we're currently compiling. We then delay binding until just before we start codegen for the body of the function so that we can ensure the function has completely initialised all scope details. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator): * bytecompiler/BytecodeGenerator.h: * parser/Parser.cpp: (JSC::Parser<LexerType>::Parser): (JSC::Parser<LexerType>::createBindingPattern): LayoutTests: Added tests for correct behaviour. * js/deconstructing-parameters-should-be-locals-expected.txt: Added. * js/deconstructing-parameters-should-be-locals.html: Added. * js/script-tests/deconstructing-parameters-should-be-locals.js: Added. (description.value.string_appeared_here.readDeconstructedParameter): (overwriteDeconstructedParameter): (readCapturedDeconstructedParameter): (overwriteCapturedDeconstructedParameter): Canonical link: https://commits.webkit.org/146139@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-02-03 22:43:28 +00:00
<script src="../resources/js-test-post.js"></script>
</body>
</html>