nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/js/class-constructor-return-ex...

96 lines
4.7 KiB
Plaintext
Raw Permalink Normal View History

ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance https://bugs.webkit.org/show_bug.cgi?id=143012 Reviewed by Ryosuke Niwa. Source/JavaScriptCore: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): Fix handling of "undefined" when returned from a Derived class. It was returning "undefined" when it should have returned "this". LayoutTests: * js/class-constructor-return-expected.txt: Added. * js/class-constructor-return.html: Added. * js/script-tests/class-constructor-return.js: Added. New test covering different return values from constructors. * js/class-syntax-super-expected.txt: * js/script-tests/class-syntax-super.js: Fix test. Returning undefined is the same as an implicit return and should return `this`. Canonical link: https://commits.webkit.org/161052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-25 01:18:18 +00:00
Tests for ES6 class constructor return values
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Base class
ES6 class syntax should use block scoping https://bugs.webkit.org/show_bug.cgi?id=142567 Reviewed by Geoffrey Garen. Source/JavaScriptCore: We treat class declarations like we do "let" declarations. The class name is under TDZ until the class declaration statement is evaluated. Class declarations also follow the same rules as "let": No duplicate definitions inside a lexical environment. * parser/ASTBuilder.h: (JSC::ASTBuilder::createClassDeclStatement): * parser/Parser.cpp: (JSC::Parser<LexerType>::parseClassDeclaration): * tests/stress/class-syntax-block-scoping.js: Added. (assert): (truth): (.): * tests/stress/class-syntax-definition-semantics.js: Added. (shouldBeSyntaxError): (shouldNotBeSyntaxError): (truth): * tests/stress/class-syntax-tdz.js: (assert): (shouldThrowTDZ): (truth): (.): LayoutTests: * js/class-constructor-return-expected.txt: * js/class-syntax-call-expected.txt: * js/class-syntax-declaration-expected.txt: * js/class-syntax-default-constructor-expected.txt: * js/class-syntax-extends-expected.txt: * js/class-syntax-name-expected.txt: * js/class-syntax-super-expected.txt: * js/script-tests/class-constructor-return.js: (shouldThrow): (shouldNotThrow): (shouldBeTrue): (shouldBeFalse): * js/script-tests/class-syntax-call.js: (A): (B): (shouldThrow): (shouldNotThrow): * js/script-tests/class-syntax-declaration.js: (shouldThrow): (shouldNotThrow): (shouldBe): * js/script-tests/class-syntax-default-constructor.js: (shouldThrow): (shouldBe): (shouldBeTrue): (assert): (A): (B): * js/script-tests/class-syntax-extends.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (Base): (Base.prototype.baseMethod): * js/script-tests/class-syntax-name.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (runTestShouldBe): * js/script-tests/class-syntax-super.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (shouldBeFalse): Canonical link: https://commits.webkit.org/165577@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-07-31 21:05:19 +00:00
PASS (new BaseNoReturn) instanceof BaseNoReturn
PASS (new BaseReturnImplicit) instanceof BaseReturnImplicit
PASS (new BaseReturnImplicit) !== undefined
PASS (new BaseReturnUndefined) instanceof BaseReturnUndefined
PASS (new BaseReturnUndefined) !== undefined
PASS (new BaseReturnThis) instanceof BaseReturnThis
PASS (new BaseReturnObject) instanceof BaseReturnObject
PASS typeof (new BaseReturnObject) === "object"
PASS (new BaseReturnObject2) instanceof BaseReturnObject
PASS (new BaseReturnObject2) === globalVariable
PASS (new BaseReturnString) instanceof BaseReturnString
PASS typeof (new BaseReturnString) !== "string"
PASS (new BaseReturnNumber) instanceof BaseReturnNumber
PASS typeof (new BaseReturnNumber) !== "number"
PASS (new BaseReturnNull) instanceof BaseReturnNull
PASS (new BaseReturnNull) !== null
PASS (new BaseReturnSymbol) instanceof BaseReturnSymbol
PASS (new BaseReturnSymbol) !== globalSymbol
PASS (new BaseThrow)
ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance https://bugs.webkit.org/show_bug.cgi?id=143012 Reviewed by Ryosuke Niwa. Source/JavaScriptCore: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): Fix handling of "undefined" when returned from a Derived class. It was returning "undefined" when it should have returned "this". LayoutTests: * js/class-constructor-return-expected.txt: Added. * js/class-constructor-return.html: Added. * js/script-tests/class-constructor-return.js: Added. New test covering different return values from constructors. * js/class-syntax-super-expected.txt: * js/script-tests/class-syntax-super.js: Fix test. Returning undefined is the same as an implicit return and should return `this`. Canonical link: https://commits.webkit.org/161052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-25 01:18:18 +00:00
Function constructor (non-class)
ES6 class syntax should use block scoping https://bugs.webkit.org/show_bug.cgi?id=142567 Reviewed by Geoffrey Garen. Source/JavaScriptCore: We treat class declarations like we do "let" declarations. The class name is under TDZ until the class declaration statement is evaluated. Class declarations also follow the same rules as "let": No duplicate definitions inside a lexical environment. * parser/ASTBuilder.h: (JSC::ASTBuilder::createClassDeclStatement): * parser/Parser.cpp: (JSC::Parser<LexerType>::parseClassDeclaration): * tests/stress/class-syntax-block-scoping.js: Added. (assert): (truth): (.): * tests/stress/class-syntax-definition-semantics.js: Added. (shouldBeSyntaxError): (shouldNotBeSyntaxError): (truth): * tests/stress/class-syntax-tdz.js: (assert): (shouldThrowTDZ): (truth): (.): LayoutTests: * js/class-constructor-return-expected.txt: * js/class-syntax-call-expected.txt: * js/class-syntax-declaration-expected.txt: * js/class-syntax-default-constructor-expected.txt: * js/class-syntax-extends-expected.txt: * js/class-syntax-name-expected.txt: * js/class-syntax-super-expected.txt: * js/script-tests/class-constructor-return.js: (shouldThrow): (shouldNotThrow): (shouldBeTrue): (shouldBeFalse): * js/script-tests/class-syntax-call.js: (A): (B): (shouldThrow): (shouldNotThrow): * js/script-tests/class-syntax-declaration.js: (shouldThrow): (shouldNotThrow): (shouldBe): * js/script-tests/class-syntax-default-constructor.js: (shouldThrow): (shouldBe): (shouldBeTrue): (assert): (A): (B): * js/script-tests/class-syntax-extends.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (Base): (Base.prototype.baseMethod): * js/script-tests/class-syntax-name.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (runTestShouldBe): * js/script-tests/class-syntax-super.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (shouldBeFalse): Canonical link: https://commits.webkit.org/165577@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-07-31 21:05:19 +00:00
PASS (new FunctionNoReturn) instanceof FunctionNoReturn
PASS (new FunctionReturnImplicit) instanceof FunctionReturnImplicit
PASS (new FunctionReturnImplicit) !== undefined
PASS (new FunctionReturnUndefined) instanceof FunctionReturnUndefined
PASS (new FunctionReturnUndefined) !== undefined
PASS (new FunctionReturnThis) instanceof FunctionReturnThis
PASS (new FunctionReturnObject) instanceof FunctionReturnObject
PASS typeof (new FunctionReturnObject) === "object"
PASS (new FunctionReturnObject2) instanceof FunctionReturnObject
PASS (new FunctionReturnObject2) === globalVariable
PASS (new FunctionReturnString) instanceof FunctionReturnString
PASS typeof (new FunctionReturnString) !== "string"
PASS (new FunctionReturnNumber) instanceof FunctionReturnNumber
PASS typeof (new FunctionReturnNumber) !== "number"
PASS (new FunctionReturnNull) instanceof FunctionReturnNull
PASS (new FunctionReturnNull) !== null
PASS (new FunctionReturnSymbol) instanceof FunctionReturnSymbol
PASS (new FunctionReturnSymbol) !== globalSymbol
PASS (new FunctionThrow)
ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance https://bugs.webkit.org/show_bug.cgi?id=143012 Reviewed by Ryosuke Niwa. Source/JavaScriptCore: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): Fix handling of "undefined" when returned from a Derived class. It was returning "undefined" when it should have returned "this". LayoutTests: * js/class-constructor-return-expected.txt: Added. * js/class-constructor-return.html: Added. * js/script-tests/class-constructor-return.js: Added. New test covering different return values from constructors. * js/class-syntax-super-expected.txt: * js/script-tests/class-syntax-super.js: Fix test. Returning undefined is the same as an implicit return and should return `this`. Canonical link: https://commits.webkit.org/161052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-25 01:18:18 +00:00
Derived class calling super()
ES6 class syntax should use block scoping https://bugs.webkit.org/show_bug.cgi?id=142567 Reviewed by Geoffrey Garen. Source/JavaScriptCore: We treat class declarations like we do "let" declarations. The class name is under TDZ until the class declaration statement is evaluated. Class declarations also follow the same rules as "let": No duplicate definitions inside a lexical environment. * parser/ASTBuilder.h: (JSC::ASTBuilder::createClassDeclStatement): * parser/Parser.cpp: (JSC::Parser<LexerType>::parseClassDeclaration): * tests/stress/class-syntax-block-scoping.js: Added. (assert): (truth): (.): * tests/stress/class-syntax-definition-semantics.js: Added. (shouldBeSyntaxError): (shouldNotBeSyntaxError): (truth): * tests/stress/class-syntax-tdz.js: (assert): (shouldThrowTDZ): (truth): (.): LayoutTests: * js/class-constructor-return-expected.txt: * js/class-syntax-call-expected.txt: * js/class-syntax-declaration-expected.txt: * js/class-syntax-default-constructor-expected.txt: * js/class-syntax-extends-expected.txt: * js/class-syntax-name-expected.txt: * js/class-syntax-super-expected.txt: * js/script-tests/class-constructor-return.js: (shouldThrow): (shouldNotThrow): (shouldBeTrue): (shouldBeFalse): * js/script-tests/class-syntax-call.js: (A): (B): (shouldThrow): (shouldNotThrow): * js/script-tests/class-syntax-declaration.js: (shouldThrow): (shouldNotThrow): (shouldBe): * js/script-tests/class-syntax-default-constructor.js: (shouldThrow): (shouldBe): (shouldBeTrue): (assert): (A): (B): * js/script-tests/class-syntax-extends.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (Base): (Base.prototype.baseMethod): * js/script-tests/class-syntax-name.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (runTestShouldBe): * js/script-tests/class-syntax-super.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (shouldBeFalse): Canonical link: https://commits.webkit.org/165577@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-07-31 21:05:19 +00:00
PASS (new DerivedNoReturn) instanceof DerivedNoReturn
PASS (new DerivedReturnImplicit) instanceof DerivedReturnImplicit
PASS (new DerivedReturnImplicit) !== undefined
PASS (new DerivedReturnUndefined) instanceof DerivedReturnUndefined
PASS (new DerivedReturnUndefined) !== undefined
PASS (new DerivedReturnThis) instanceof DerivedReturnThis
PASS (new DerivedReturnObject) instanceof DerivedReturnObject
PASS typeof (new DerivedReturnObject) === "object"
PASS (new DerivedReturnObject2) instanceof DerivedReturnObject2
PASS (new DerivedReturnObject2) === globalVariable
PASS (new DerivedReturnString)
PASS (new DerivedReturnNumber)
PASS (new DerivedReturnNull)
PASS (new DerivedReturnSymbol)
PASS (new DerivedThrow)
ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance https://bugs.webkit.org/show_bug.cgi?id=143012 Reviewed by Ryosuke Niwa. Source/JavaScriptCore: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): Fix handling of "undefined" when returned from a Derived class. It was returning "undefined" when it should have returned "this". LayoutTests: * js/class-constructor-return-expected.txt: Added. * js/class-constructor-return.html: Added. * js/script-tests/class-constructor-return.js: Added. New test covering different return values from constructors. * js/class-syntax-super-expected.txt: * js/script-tests/class-syntax-super.js: Fix test. Returning undefined is the same as an implicit return and should return `this`. Canonical link: https://commits.webkit.org/161052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-25 01:18:18 +00:00
Derived class not calling super()
ES6 class syntax should use block scoping https://bugs.webkit.org/show_bug.cgi?id=142567 Reviewed by Geoffrey Garen. Source/JavaScriptCore: We treat class declarations like we do "let" declarations. The class name is under TDZ until the class declaration statement is evaluated. Class declarations also follow the same rules as "let": No duplicate definitions inside a lexical environment. * parser/ASTBuilder.h: (JSC::ASTBuilder::createClassDeclStatement): * parser/Parser.cpp: (JSC::Parser<LexerType>::parseClassDeclaration): * tests/stress/class-syntax-block-scoping.js: Added. (assert): (truth): (.): * tests/stress/class-syntax-definition-semantics.js: Added. (shouldBeSyntaxError): (shouldNotBeSyntaxError): (truth): * tests/stress/class-syntax-tdz.js: (assert): (shouldThrowTDZ): (truth): (.): LayoutTests: * js/class-constructor-return-expected.txt: * js/class-syntax-call-expected.txt: * js/class-syntax-declaration-expected.txt: * js/class-syntax-default-constructor-expected.txt: * js/class-syntax-extends-expected.txt: * js/class-syntax-name-expected.txt: * js/class-syntax-super-expected.txt: * js/script-tests/class-constructor-return.js: (shouldThrow): (shouldNotThrow): (shouldBeTrue): (shouldBeFalse): * js/script-tests/class-syntax-call.js: (A): (B): (shouldThrow): (shouldNotThrow): * js/script-tests/class-syntax-declaration.js: (shouldThrow): (shouldNotThrow): (shouldBe): * js/script-tests/class-syntax-default-constructor.js: (shouldThrow): (shouldBe): (shouldBeTrue): (assert): (A): (B): * js/script-tests/class-syntax-extends.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (Base): (Base.prototype.baseMethod): * js/script-tests/class-syntax-name.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (runTestShouldBe): * js/script-tests/class-syntax-super.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (shouldBeFalse): Canonical link: https://commits.webkit.org/165577@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-07-31 21:05:19 +00:00
PASS (new DerivedNoSuperNoReturn)
PASS (new DerivedNoSuperReturnImplicit)
PASS (new DerivedNoSuperReturnUndefined)
PASS (new DerivedNoSuperReturnThis)
PASS (new DerivedNoSuperReturnObject)
PASS (new DerivedNoSuperReturnObject2)
PASS (new DerivedNoSuperReturnString)
PASS (new DerivedNoSuperReturnNumber)
PASS (new DerivedNoSuperReturnNull)
PASS (new DerivedNoSuperReturnSymbol)
PASS (new DerivedNoSuperThrow)
ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance https://bugs.webkit.org/show_bug.cgi?id=143012 Reviewed by Ryosuke Niwa. Source/JavaScriptCore: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): Fix handling of "undefined" when returned from a Derived class. It was returning "undefined" when it should have returned "this". LayoutTests: * js/class-constructor-return-expected.txt: Added. * js/class-constructor-return.html: Added. * js/script-tests/class-constructor-return.js: Added. New test covering different return values from constructors. * js/class-syntax-super-expected.txt: * js/script-tests/class-syntax-super.js: Fix test. Returning undefined is the same as an implicit return and should return `this`. Canonical link: https://commits.webkit.org/161052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-25 01:18:18 +00:00
Derived class with default constructor and base class returning different values
ES6 class syntax should use block scoping https://bugs.webkit.org/show_bug.cgi?id=142567 Reviewed by Geoffrey Garen. Source/JavaScriptCore: We treat class declarations like we do "let" declarations. The class name is under TDZ until the class declaration statement is evaluated. Class declarations also follow the same rules as "let": No duplicate definitions inside a lexical environment. * parser/ASTBuilder.h: (JSC::ASTBuilder::createClassDeclStatement): * parser/Parser.cpp: (JSC::Parser<LexerType>::parseClassDeclaration): * tests/stress/class-syntax-block-scoping.js: Added. (assert): (truth): (.): * tests/stress/class-syntax-definition-semantics.js: Added. (shouldBeSyntaxError): (shouldNotBeSyntaxError): (truth): * tests/stress/class-syntax-tdz.js: (assert): (shouldThrowTDZ): (truth): (.): LayoutTests: * js/class-constructor-return-expected.txt: * js/class-syntax-call-expected.txt: * js/class-syntax-declaration-expected.txt: * js/class-syntax-default-constructor-expected.txt: * js/class-syntax-extends-expected.txt: * js/class-syntax-name-expected.txt: * js/class-syntax-super-expected.txt: * js/script-tests/class-constructor-return.js: (shouldThrow): (shouldNotThrow): (shouldBeTrue): (shouldBeFalse): * js/script-tests/class-syntax-call.js: (A): (B): (shouldThrow): (shouldNotThrow): * js/script-tests/class-syntax-declaration.js: (shouldThrow): (shouldNotThrow): (shouldBe): * js/script-tests/class-syntax-default-constructor.js: (shouldThrow): (shouldBe): (shouldBeTrue): (assert): (A): (B): * js/script-tests/class-syntax-extends.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (Base): (Base.prototype.baseMethod): * js/script-tests/class-syntax-name.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (runTestShouldBe): * js/script-tests/class-syntax-super.js: (shouldThrow): (shouldNotThrow): (shouldBe): (shouldBeTrue): (shouldBeFalse): Canonical link: https://commits.webkit.org/165577@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-07-31 21:05:19 +00:00
PASS (new DerivedDefaultConstructorWithBaseNoReturn) instanceof DerivedDefaultConstructorWithBaseNoReturn
PASS (new DerivedDefaultConstructorWithBaseReturnImplicit) instanceof DerivedDefaultConstructorWithBaseReturnImplicit
PASS (new DerivedDefaultConstructorWithBaseReturnUndefined) instanceof DerivedDefaultConstructorWithBaseReturnUndefined
PASS (new DerivedDefaultConstructorWithBaseReturnObject) instanceof DerivedDefaultConstructorWithBaseReturnObject
PASS typeof (new DerivedDefaultConstructorWithBaseReturnObject) === "object"
PASS (new DerivedDefaultConstructorWithBaseReturnObject2) instanceof DerivedDefaultConstructorWithBaseReturnObject2
PASS (new DerivedDefaultConstructorWithBaseReturnObject2) === globalVariable
PASS (new DerivedDefaultConstructorWithBaseReturnThis) instanceof DerivedDefaultConstructorWithBaseReturnThis
PASS (new DerivedDefaultConstructorWithBaseReturnString) instanceof DerivedDefaultConstructorWithBaseReturnString
PASS (new DerivedDefaultConstructorWithBaseReturnNumber) instanceof DerivedDefaultConstructorWithBaseReturnNumber
PASS (new DerivedDefaultConstructorWithBaseReturnNull) instanceof DerivedDefaultConstructorWithBaseReturnNull
PASS (new DerivedDefaultConstructorWithBaseReturnSymbol) instanceof DerivedDefaultConstructorWithBaseReturnSymbol
PASS (new DerivedDefaultConstructorWithBaseThrow)
PASS successfullyParsed
ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance https://bugs.webkit.org/show_bug.cgi?id=143012 Reviewed by Ryosuke Niwa. Source/JavaScriptCore: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): Fix handling of "undefined" when returned from a Derived class. It was returning "undefined" when it should have returned "this". LayoutTests: * js/class-constructor-return-expected.txt: Added. * js/class-constructor-return.html: Added. * js/script-tests/class-constructor-return.js: Added. New test covering different return values from constructors. * js/class-syntax-super-expected.txt: * js/script-tests/class-syntax-super.js: Fix test. Returning undefined is the same as an implicit return and should return `this`. Canonical link: https://commits.webkit.org/161052@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-25 01:18:18 +00:00
TEST COMPLETE