nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fetch/header-constructor-subclass...

11 lines
249 B
Plaintext
Raw Permalink Normal View History

Remove forEach use from Fetch Headers builtin constructor https://bugs.webkit.org/show_bug.cgi?id=155967 Reviewed by Joseph Pecoraro. Source/WebCore: Tests: fetch/shadowing-forEach.html streams/shadowing-Promise.html streams/shadowing-defineProperty.html * Modules/fetch/FetchHeaders.idl: Adding fillFromJS private method. * Modules/fetch/FetchHeaders.js: (initializeFetchHeaders): Using fillFromJS private method. Using instanceof test to check whether parameter is Headers or subclass of it. * bindings/js/WebCoreBuiltinNames.h: Adding fillFromJS private symbol. LayoutTests: Renaming tests covering user scripts breaking some WebCore JS built ins. * fetch/header-constructor-subclass-expected.txt: Added. * fetch/header-constructor-subclass.html: Added. * fetch/shadowing-forEach-expected.txt: Renamed from LayoutTests/streams/builtin-overrides-expected.txt. * fetch/shadowing-forEach.html: Renamed from LayoutTests/fetch/builtin-overrides.html. * streams/shadowing-Promise-expected.txt: Renamed from LayoutTests/streams/streams-promises-expected.txt. * streams/shadowing-Promise.html: Renamed from LayoutTests/streams/streams-promises.html. * streams/shadowing-defineProperty-expected.txt: Renamed from LayoutTests/fetch/builtin-overrides-expected.txt. * streams/shadowing-defineProperty.html: Renamed from LayoutTests/streams/builtin-overrides.html. Canonical link: https://commits.webkit.org/174179@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@198889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-03-31 08:31:25 +00:00
This test should create a Headers from an object which is a subclass of Headers.
Audit WebCore builtins for user overridable code https://bugs.webkit.org/show_bug.cgi?id=155923 Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-03-29 Reviewed by Youenn Fablet. Source/JavaScriptCore: * runtime/CommonIdentifiers.h: * runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::finishCreation): Expose @Object.@defineProperty to built-ins. Source/WebCore: Tests: fetch/builtin-overrides.html streams/builtin-overrides.html * Modules/fetch/FetchHeaders.js: (initializeFetchHeaders): Avoid using an Array.prototype.forEach that could be overriden. * Modules/streams/ByteLengthQueuingStrategy.js: (initializeByteLengthQueuingStrategy): * Modules/streams/CountQueuingStrategy.js: (initializeCountQueuingStrategy): Use the private Object.defineProperty not one that could be overriden. * Modules/streams/ReadableStreamInternals.js: (finishClosingReadableStream): Fix style. * Modules/streams/WritableStream.js: (write): Fix error message to use the correct function name. LayoutTests: * fetch/builtin-overrides-expected.txt: Added. * fetch/builtin-overrides.html: Added. * streams/builtin-overrides-expected.txt: Added. * streams/builtin-overrides.html: Added. Canonical link: https://commits.webkit.org/174077@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@198776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-03-29 08:14:39 +00:00
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Remove forEach use from Fetch Headers builtin constructor https://bugs.webkit.org/show_bug.cgi?id=155967 Reviewed by Joseph Pecoraro. Source/WebCore: Tests: fetch/shadowing-forEach.html streams/shadowing-Promise.html streams/shadowing-defineProperty.html * Modules/fetch/FetchHeaders.idl: Adding fillFromJS private method. * Modules/fetch/FetchHeaders.js: (initializeFetchHeaders): Using fillFromJS private method. Using instanceof test to check whether parameter is Headers or subclass of it. * bindings/js/WebCoreBuiltinNames.h: Adding fillFromJS private symbol. LayoutTests: Renaming tests covering user scripts breaking some WebCore JS built ins. * fetch/header-constructor-subclass-expected.txt: Added. * fetch/header-constructor-subclass.html: Added. * fetch/shadowing-forEach-expected.txt: Renamed from LayoutTests/streams/builtin-overrides-expected.txt. * fetch/shadowing-forEach.html: Renamed from LayoutTests/fetch/builtin-overrides.html. * streams/shadowing-Promise-expected.txt: Renamed from LayoutTests/streams/streams-promises-expected.txt. * streams/shadowing-Promise.html: Renamed from LayoutTests/streams/streams-promises.html. * streams/shadowing-defineProperty-expected.txt: Renamed from LayoutTests/fetch/builtin-overrides-expected.txt. * streams/shadowing-defineProperty.html: Renamed from LayoutTests/streams/builtin-overrides.html. Canonical link: https://commits.webkit.org/174179@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@198889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-03-31 08:31:25 +00:00
PASS otherHeaders.get('a') is "1"
Audit WebCore builtins for user overridable code https://bugs.webkit.org/show_bug.cgi?id=155923 Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-03-29 Reviewed by Youenn Fablet. Source/JavaScriptCore: * runtime/CommonIdentifiers.h: * runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::finishCreation): Expose @Object.@defineProperty to built-ins. Source/WebCore: Tests: fetch/builtin-overrides.html streams/builtin-overrides.html * Modules/fetch/FetchHeaders.js: (initializeFetchHeaders): Avoid using an Array.prototype.forEach that could be overriden. * Modules/streams/ByteLengthQueuingStrategy.js: (initializeByteLengthQueuingStrategy): * Modules/streams/CountQueuingStrategy.js: (initializeCountQueuingStrategy): Use the private Object.defineProperty not one that could be overriden. * Modules/streams/ReadableStreamInternals.js: (finishClosingReadableStream): Fix style. * Modules/streams/WritableStream.js: (write): Fix error message to use the correct function name. LayoutTests: * fetch/builtin-overrides-expected.txt: Added. * fetch/builtin-overrides.html: Added. * streams/builtin-overrides-expected.txt: Added. * streams/builtin-overrides.html: Added. Canonical link: https://commits.webkit.org/174077@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@198776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-03-29 08:14:39 +00:00
PASS successfullyParsed is true
TEST COMPLETE