nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fetch/header-constructor-is-array...

12 lines
260 B
Plaintext
Raw Permalink Normal View History

[WebIDL] Remove JS builtin bindings for FetchHeaders https://bugs.webkit.org/show_bug.cgi?id=174905 Patch by Sam Weinig <sam@webkit.org> on 2017-07-28 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/headers/headers-basic-expected.txt: * web-platform-tests/fetch/api/headers/headers-record-expected.txt: Update results for more passing tests. Source/WebCore: * CMakeLists.txt: * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * Modules/fetch/FetchHeaders.js: Removed. Remove FetchHeaders.js * Modules/fetch/FetchHeaders.cpp: (WebCore::appendToHeaderMap): (WebCore::FetchHeaders::create): (WebCore::FetchHeaders::append): * Modules/fetch/FetchHeaders.h: (WebCore::FetchHeaders::FetchHeaders): Add create function for generated constructor. Add appendToHeaderMap static function which takes the functionality from the existing append function, and makes it useable in create. * Modules/fetch/FetchHeaders.idl: Replace [JSBuiltinConstructor] with real constructor. Keep other builtin attributes as they are still used by other Fetch code. * bindings/js/JSDOMConvertRecord.h: Fix record conversion to work with proxies by changing to use the method table for getOwnPropertyNames, and undefined values by not excluding undefined values. LayoutTests: * fetch/header-constructor-is-array-expected.txt: * fetch/header-constructor-is-array.html: Update test to match spec. An array with out a prototype will not yield a valid Header as it is not iterable. Canonical link: https://commits.webkit.org/191755@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-07-29 02:35:56 +00:00
This test should create a Headers with strange Arrays.
[Fetch] Use @isArray instead of `instanceof @Array` https://bugs.webkit.org/show_bug.cgi?id=156682 Reviewed by Alex Christensen. Source/WebCore: Currently, we query whether the given value is Array by using `instanceof @Array`. But it is not enough; Array from the other realm should be accepted. And Array not inheriting @Array should be also accepted. Test: fetch/header-constructor-is-array.html * Modules/fetch/FetchHeaders.js: (initializeFetchHeaders): LayoutTests: * fetch/header-constructor-is-array-expected.txt: Added. * fetch/header-constructor-is-array.html: Added. Canonical link: https://commits.webkit.org/174789@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-04-18 08:01:07 +00:00
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
[WebIDL] Remove JS builtin bindings for FetchHeaders https://bugs.webkit.org/show_bug.cgi?id=174905 Patch by Sam Weinig <sam@webkit.org> on 2017-07-28 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/headers/headers-basic-expected.txt: * web-platform-tests/fetch/api/headers/headers-record-expected.txt: Update results for more passing tests. Source/WebCore: * CMakeLists.txt: * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * Modules/fetch/FetchHeaders.js: Removed. Remove FetchHeaders.js * Modules/fetch/FetchHeaders.cpp: (WebCore::appendToHeaderMap): (WebCore::FetchHeaders::create): (WebCore::FetchHeaders::append): * Modules/fetch/FetchHeaders.h: (WebCore::FetchHeaders::FetchHeaders): Add create function for generated constructor. Add appendToHeaderMap static function which takes the functionality from the existing append function, and makes it useable in create. * Modules/fetch/FetchHeaders.idl: Replace [JSBuiltinConstructor] with real constructor. Keep other builtin attributes as they are still used by other Fetch code. * bindings/js/JSDOMConvertRecord.h: Fix record conversion to work with proxies by changing to use the method table for getOwnPropertyNames, and undefined values by not excluding undefined values. LayoutTests: * fetch/header-constructor-is-array-expected.txt: * fetch/header-constructor-is-array.html: Update test to match spec. An array with out a prototype will not yield a valid Header as it is not iterable. Canonical link: https://commits.webkit.org/191755@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-07-29 02:35:56 +00:00
PASS headers.get('hello') is null
[Fetch] Use @isArray instead of `instanceof @Array` https://bugs.webkit.org/show_bug.cgi?id=156682 Reviewed by Alex Christensen. Source/WebCore: Currently, we query whether the given value is Array by using `instanceof @Array`. But it is not enough; Array from the other realm should be accepted. And Array not inheriting @Array should be also accepted. Test: fetch/header-constructor-is-array.html * Modules/fetch/FetchHeaders.js: (initializeFetchHeaders): LayoutTests: * fetch/header-constructor-is-array-expected.txt: Added. * fetch/header-constructor-is-array.html: Added. Canonical link: https://commits.webkit.org/174789@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-04-18 08:01:07 +00:00
PASS headers.get('hello') is "world"
PASS successfullyParsed is true
TEST COMPLETE