nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/text/textCombine-update-embedded...

2 lines
126 B
Plaintext
Raw Permalink Normal View History

ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects https://bugs.webkit.org/show_bug.cgi?id=191532 <rdar://problem/46151555> Patch by Jack Lee <shihchieh_lee@apple.com> on 2020-02-18 Reviewed by Darin Adler. Add reentrancy protection for FrameView::updateEmbeddedObjects(). Move the common code in renderWidgetLoadingPlugin() to inherited class, HTMLPlugInElement. Source/WebCore: Test: fast/text/textCombine-update-embeddedObj-assert.html * html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetLoadingPlugin const): * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin const): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderWidgetLoadingPlugin const): Deleted. * html/HTMLObjectElement.h: * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::renderWidgetLoadingPlugin const): * html/HTMLPlugInElement.h: * page/FrameView.cpp: (WebCore::FrameView::updateEmbeddedObjects): * page/FrameView.h: LayoutTests: * fast/text/textCombine-update-embeddedObj-assert-expected.txt: Added. * fast/text/textCombine-update-embeddedObj-assert.html: Added. Canonical link: https://commits.webkit.org/220904@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-02-19 04:57:30 +00:00
Tests updating embedded objects in text-combine rendering. The test passes if WebKit doesn't crash or hit an assertion.